You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "hdalsania (via GitHub)" <gi...@apache.org> on 2025/09/15 17:27:57 UTC
[PR] Fixed formattig and typo errors, added fontmatters and updated commit… [daffodil-vscode]
hdalsania opened a new pull request, #1417:
URL: https://github.com/apache/daffodil-vscode/pull/1417
… hashes instead of tags in workflow CI files
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
Closes #1416
#1415
## Description
- Fixed formatting in feature_request.md
- Fixed typo in pull_request.md
- Removed license header and added exceptions in Rat.scala for license check
- Added fontmatter header in all issue templates
- Updated tags with hashes for all dependencies in workflow CI files
## Wiki
- [x] I have determined that no documentation updates are needed for these changes
- [ ] I have added following documentation for these changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed formattig and typo errors, added fontmatters and updated commit… [daffodil-vscode]
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on code in PR #1417:
URL: https://github.com/apache/daffodil-vscode/pull/1417#discussion_r2349671740
##########
project/Rat.scala:
##########
@@ -62,6 +62,11 @@ object Rat {
file("src/svelte/src/resources/fonts/RedHatMono-Regular.woff2"),
// scalafmt-core files
file(".git-blame-ignore-revs")
Review Comment:
Add a common after this line, that's why the CI is failing
```suggestion
file(".git-blame-ignore-revs"),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed formattig and typo errors, added fontmatters and updated commit… [daffodil-vscode]
Posted by "hdalsania (via GitHub)" <gi...@apache.org>.
hdalsania commented on code in PR #1417:
URL: https://github.com/apache/daffodil-vscode/pull/1417#discussion_r2349692026
##########
project/Rat.scala:
##########
@@ -62,6 +62,11 @@ object Rat {
file("src/svelte/src/resources/fonts/RedHatMono-Regular.woff2"),
// scalafmt-core files
file(".git-blame-ignore-revs")
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed formatting and typo errors, added fontmatters and updated commit… [daffodil-vscode]
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell merged PR #1417:
URL: https://github.com/apache/daffodil-vscode/pull/1417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org