You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "charlesbluca (via GitHub)" <gi...@apache.org> on 2023/02/02 19:37:30 UTC

[GitHub] [arrow-datafusion-python] charlesbluca commented on a diff in pull request #162: CI Fixes

charlesbluca commented on code in PR #162:
URL: https://github.com/apache/arrow-datafusion-python/pull/162#discussion_r1095006512


##########
.github/workflows/test.yaml:
##########
@@ -119,15 +111,10 @@ jobs:
           args: --release --out dist
 
       - name: Run tests
+        env:
+          RUST_BACKTRACE: 1
         run: |
           git submodule update --init
-          export PATH=$PATH:$HOME/d/protoc/bin
-          export PROTOC=$HOME/d/protoc/bin
-          sudo chown -R $(whoami) $HOME/d/protoc
-          ls -l $HOME/d/protoc/
-          ls -l $HOME/d/protoc/bin
-          pip install datafusion-python --no-index --find-links dist --force-reinstall
-          pip install pytest
-          cargo clean
-          maturin develop
-          RUST_BACKTRACE=1 pytest -v .
+          source venv/bin/activate
+          pip install .

Review Comment:
   Think we'll want to do an editable install here:
   
   ```suggestion
             pip install -e . -vv
   ```
   
   Also added verbose flags so we can catch if anything goes wrong



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org