You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Gabor Kaszab (Code Review)" <ge...@cloudera.org> on 2021/01/27 16:46:44 UTC
[Impala-ASF-CR] IMPALA-9588: Add extra logging to cancel tests
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16985
Change subject: IMPALA-9588: Add extra logging to cancel tests
......................................................................
IMPALA-9588: Add extra logging to cancel tests
There have been some cancel tests that are flaky and their logs didn't
reveal the root cause of the failures. Adding some extra logging so
that we can see a bit more of the nature of the failure.
The extra log message contains:
- Query SQL
- Message of the exception thrown during fetching the results
- Query Status line from the query profile
Change-Id: Ied7100a9ea2e2f0611cf8e328e589b4c8e5d5100
---
M tests/util/cancel_util.py
1 file changed, 13 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/16985/1
--
To view, visit http://gerrit.cloudera.org:8080/16985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied7100a9ea2e2f0611cf8e328e589b4c8e5d5100
Gerrit-Change-Number: 16985
Gerrit-PatchSet: 1
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
[Impala-ASF-CR] IMPALA-9588: Add extra logging to cancel tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16985 )
Change subject: IMPALA-9588: Add extra logging to cancel tests
......................................................................
IMPALA-9588: Add extra logging to cancel tests
There have been some cancel tests that are flaky and their logs didn't
reveal the root cause of the failures. Adding some extra logging so
that we can see a bit more of the nature of the failure.
The extra log message contains:
- Query SQL
- Message of the exception thrown during fetching the results
- Query Status line from the query profile
Change-Id: Ied7100a9ea2e2f0611cf8e328e589b4c8e5d5100
Reviewed-on: http://gerrit.cloudera.org:8080/16985
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/util/cancel_util.py
1 file changed, 12 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied7100a9ea2e2f0611cf8e328e589b4c8e5d5100
Gerrit-Change-Number: 16985
Gerrit-PatchSet: 4
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9588: Add extra logging to cancel tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16985 )
Change subject: IMPALA-9588: Add extra logging to cancel tests
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6867/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied7100a9ea2e2f0611cf8e328e589b4c8e5d5100
Gerrit-Change-Number: 16985
Gerrit-PatchSet: 3
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Feb 2021 15:17:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9588: Add extra logging to cancel tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16985 )
Change subject: IMPALA-9588: Add extra logging to cancel tests
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied7100a9ea2e2f0611cf8e328e589b4c8e5d5100
Gerrit-Change-Number: 16985
Gerrit-PatchSet: 3
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Feb 2021 15:17:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9588: Add extra logging to cancel tests
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16985 )
Change subject: IMPALA-9588: Add extra logging to cancel tests
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied7100a9ea2e2f0611cf8e328e589b4c8e5d5100
Gerrit-Change-Number: 16985
Gerrit-PatchSet: 2
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Feb 2021 17:33:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9588: Add extra logging to cancel tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16985 )
Change subject: IMPALA-9588: Add extra logging to cancel tests
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8036/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied7100a9ea2e2f0611cf8e328e589b4c8e5d5100
Gerrit-Change-Number: 16985
Gerrit-PatchSet: 1
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Jan 2021 17:08:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9588: Add extra logging to cancel tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16985 )
Change subject: IMPALA-9588: Add extra logging to cancel tests
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied7100a9ea2e2f0611cf8e328e589b4c8e5d5100
Gerrit-Change-Number: 16985
Gerrit-PatchSet: 3
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Feb 2021 21:01:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9588: Add extra logging to cancel tests
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/16985 )
Change subject: IMPALA-9588: Add extra logging to cancel tests
......................................................................
Patch Set 1:
(2 comments)
Hi Gabor, found 2 nits, aside from those LGTM!
http://gerrit.cloudera.org:8080/#/c/16985/1/tests/util/cancel_util.py
File tests/util/cancel_util.py:
http://gerrit.cloudera.org:8080/#/c/16985/1/tests/util/cancel_util.py@42
PS1, Line 42: occured
nit: occurred
http://gerrit.cloudera.org:8080/#/c/16985/1/tests/util/cancel_util.py@48
PS1, Line 48: "\n"
nit: this could just go after the previous line, like
error_msg += str(thread.fetch_results_error) + "\n"
--
To view, visit http://gerrit.cloudera.org:8080/16985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied7100a9ea2e2f0611cf8e328e589b4c8e5d5100
Gerrit-Change-Number: 16985
Gerrit-PatchSet: 1
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Feb 2021 13:09:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9588: Add extra logging to cancel tests
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16985
to look at the new patch set (#2).
Change subject: IMPALA-9588: Add extra logging to cancel tests
......................................................................
IMPALA-9588: Add extra logging to cancel tests
There have been some cancel tests that are flaky and their logs didn't
reveal the root cause of the failures. Adding some extra logging so
that we can see a bit more of the nature of the failure.
The extra log message contains:
- Query SQL
- Message of the exception thrown during fetching the results
- Query Status line from the query profile
Change-Id: Ied7100a9ea2e2f0611cf8e328e589b4c8e5d5100
---
M tests/util/cancel_util.py
1 file changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/16985/2
--
To view, visit http://gerrit.cloudera.org:8080/16985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ied7100a9ea2e2f0611cf8e328e589b4c8e5d5100
Gerrit-Change-Number: 16985
Gerrit-PatchSet: 2
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9588: Add extra logging to cancel tests
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/16985 )
Change subject: IMPALA-9588: Add extra logging to cancel tests
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/16985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied7100a9ea2e2f0611cf8e328e589b4c8e5d5100
Gerrit-Change-Number: 16985
Gerrit-PatchSet: 2
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Feb 2021 09:23:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9588: Add extra logging to cancel tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16985 )
Change subject: IMPALA-9588: Add extra logging to cancel tests
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8062/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied7100a9ea2e2f0611cf8e328e589b4c8e5d5100
Gerrit-Change-Number: 16985
Gerrit-PatchSet: 2
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Feb 2021 09:20:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9588: Add extra logging to cancel tests
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16985 )
Change subject: IMPALA-9588: Add extra logging to cancel tests
......................................................................
Patch Set 2:
(2 comments)
Thanks for the review, Tamas!
http://gerrit.cloudera.org:8080/#/c/16985/1/tests/util/cancel_util.py
File tests/util/cancel_util.py:
http://gerrit.cloudera.org:8080/#/c/16985/1/tests/util/cancel_util.py@42
PS1, Line 42: occurre
> nit: occurred
Done
http://gerrit.cloudera.org:8080/#/c/16985/1/tests/util/cancel_util.py@48
PS1, Line 48: lien
> nit: this could just go after the previous line, like
Done
--
To view, visit http://gerrit.cloudera.org:8080/16985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied7100a9ea2e2f0611cf8e328e589b4c8e5d5100
Gerrit-Change-Number: 16985
Gerrit-PatchSet: 2
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Feb 2021 08:59:33 +0000
Gerrit-HasComments: Yes