You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@karaf.apache.org by David Jencks <da...@yahoo.com> on 2011/10/24 17:52:38 UTC
Re: svn commit: r1188071 - /karaf/trunk/assemblies/features/framework/src/main/feature/feature.xml
Why? The whole point is to make the framework as small as possible. Now you've gone and forced every karaf assembly to support spring, blueprint deployment, wrapping, etc etc. After a bunch of discussion with Guillaume I carefully took out everything that could be installed as a feature from the framework. Why are you putting it back?
Also, if you want to add these to your particular assembly (or even ones karaf ships) you can do it by adding a <startupFeature> element to the assembly's pom and you don't have to modify the framework pom.
thanks
david jencks
On Oct 24, 2011, at 2:59 AM, iocanel@apache.org wrote:
> Author: iocanel
> Date: Mon Oct 24 09:59:28 2011
> New Revision: 1188071
>
> URL: http://svn.apache.org/viewvc?rev=1188071&view=rev
> Log:
> Added to deployer bundles to framework feature, so that they can be added to startup.properties.
>
> Modified:
> karaf/trunk/assemblies/features/framework/src/main/feature/feature.xml
>
> Modified: karaf/trunk/assemblies/features/framework/src/main/feature/feature.xml
> URL: http://svn.apache.org/viewvc/karaf/trunk/assemblies/features/framework/src/main/feature/feature.xml?rev=1188071&r1=1188070&r2=1188071&view=diff
> ==============================================================================
> --- karaf/trunk/assemblies/features/framework/src/main/feature/feature.xml (original)
> +++ karaf/trunk/assemblies/features/framework/src/main/feature/feature.xml Mon Oct 24 09:59:28 2011
> @@ -33,6 +33,11 @@
> <bundle start="true" start-level="20">mvn:org.apache.aries.proxy/org.apache.aries.proxy/${aries.proxy.version}</bundle>
> <bundle start="true" start-level="20">mvn:org.apache.aries.blueprint/org.apache.aries.blueprint/${aries.blueprint.version}</bundle>
> <bundle start="true" start-level="25">mvn:org.apache.karaf.features/org.apache.karaf.features.core/${project.version}</bundle>
> + <bundle start="true" start-level="30">mvn:org.apache.karaf.deployer/org.apache.karaf.deployer.spring/${project.version}</bundle>
> + <bundle start="true" start-level="30">mvn:org.apache.karaf.deployer/org.apache.karaf.deployer.blueprint/${project.version}</bundle>
> + <bundle start="true" start-level="30">mvn:org.apache.karaf.deployer/org.apache.karaf.deployer.features/${project.version}</bundle>
> + <bundle start="true" start-level="30">mvn:org.apache.karaf.deployer/org.apache.karaf.deployer.kar/${project.version}</bundle>
> + <bundle start="true" start-level="30">mvn:org.apache.karaf.deployer/org.apache.karaf.deployer.wrap/${project.version}</bundle>
> </feature>
>
> </features>
>
>
Re: svn commit: r1188071 - /karaf/trunk/assemblies/features/framework/src/main/feature/feature.xml
Posted by Achim Nierbeck <bc...@googlemail.com>.
See also the discussion on IRC:
http://irclogs.dankulp.com/logs/irclogger_log/karaf?date=2011-10-24,Mon&sel=438#l434
2011/10/24 David Jencks <da...@yahoo.com>
> Why? The whole point is to make the framework as small as possible. Now
> you've gone and forced every karaf assembly to support spring, blueprint
> deployment, wrapping, etc etc. After a bunch of discussion with Guillaume I
> carefully took out everything that could be installed as a feature from the
> framework. Why are you putting it back?
>
> Also, if you want to add these to your particular assembly (or even ones
> karaf ships) you can do it by adding a <startupFeature> element to the
> assembly's pom and you don't have to modify the framework pom.
>
> thanks
> david jencks
>
>
> On Oct 24, 2011, at 2:59 AM, iocanel@apache.org wrote:
>
> > Author: iocanel
> > Date: Mon Oct 24 09:59:28 2011
> > New Revision: 1188071
> >
> > URL: http://svn.apache.org/viewvc?rev=1188071&view=rev
> > Log:
> > Added to deployer bundles to framework feature, so that they can be added
> to startup.properties.
> >
> > Modified:
> > karaf/trunk/assemblies/features/framework/src/main/feature/feature.xml
> >
> > Modified:
> karaf/trunk/assemblies/features/framework/src/main/feature/feature.xml
> > URL:
> http://svn.apache.org/viewvc/karaf/trunk/assemblies/features/framework/src/main/feature/feature.xml?rev=1188071&r1=1188070&r2=1188071&view=diff
> >
> ==============================================================================
> > ---
> karaf/trunk/assemblies/features/framework/src/main/feature/feature.xml
> (original)
> > +++
> karaf/trunk/assemblies/features/framework/src/main/feature/feature.xml Mon
> Oct 24 09:59:28 2011
> > @@ -33,6 +33,11 @@
> > <bundle start="true"
> start-level="20">mvn:org.apache.aries.proxy/org.apache.aries.proxy/${aries.proxy.version}</bundle>
> > <bundle start="true"
> start-level="20">mvn:org.apache.aries.blueprint/org.apache.aries.blueprint/${aries.blueprint.version}</bundle>
> > <bundle start="true"
> start-level="25">mvn:org.apache.karaf.features/org.apache.karaf.features.core/${project.version}</bundle>
> > + <bundle start="true"
> start-level="30">mvn:org.apache.karaf.deployer/org.apache.karaf.deployer.spring/${project.version}</bundle>
> > + <bundle start="true"
> start-level="30">mvn:org.apache.karaf.deployer/org.apache.karaf.deployer.blueprint/${project.version}</bundle>
> > + <bundle start="true"
> start-level="30">mvn:org.apache.karaf.deployer/org.apache.karaf.deployer.features/${project.version}</bundle>
> > + <bundle start="true"
> start-level="30">mvn:org.apache.karaf.deployer/org.apache.karaf.deployer.kar/${project.version}</bundle>
> > + <bundle start="true"
> start-level="30">mvn:org.apache.karaf.deployer/org.apache.karaf.deployer.wrap/${project.version}</bundle>
> > </feature>
> >
> > </features>
> >
> >
>
>
--
--
*Achim Nierbeck*
Apache Karaf <http://karaf.apache.org/> Committer & PMC
OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer &
Project Lead
blog <http://notizblog.nierbeck.de/>
Re: svn commit: r1188071 - /karaf/trunk/assemblies/features/framework/src/main/feature/feature.xml
Posted by David Jencks <da...@yahoo.com>.
I made some time to update the custom-distribution page of the manual. While researching it I realized I misled you a bit on irc.
The framework kar is listed with maven compile (default) scope. Therefore the features repos in the kar (there's only one) is not listed in the etc/org.apache.karaf.features.cfg file as a features repo, but all the features in it (there's only one) are installed into startup.properties.
Other features repos and kars (such as the missing full kar) are listed with maven runtime scope. Therefore those feature repos are all listed as repos in the features.cfg file but the features aren't automatically installed at all: you have to list the ones you want in the karaf-maven-plugin configuration.
Please look at the new docs and let me know if they are unclear and/or wrong.
I'll try to find some time soon to document the "build a feature repo" packaging too.
thanks
david jencks
On Oct 24, 2011, at 12:28 PM, David Jencks wrote:
> Hi Ioannis,
>
> I wish I'd got the documentation for this written and committed earlier :-(
>
> Basically what you say is correct. These deployers used to be in the full kar/feature that jb removed in 1181815. I think we should basically revert that commit and bring back this feature/kar.
>
> On the irc discussion I realized that the framework kar is currently a special case in that the feature isn't actually installed during assembly, the kar is just unpacked and it includes the base startup.properties file that the framework feature ought to generate. I think it would be better to actually install the framework feature as a <startup-feature> and have that installation process generate the startup.properties. I have some other things to work on this week but I'll try to experiment with that to see if it can be made to work..... plus hopefully some docs.
>
> thanks!
> david jencks
>
> On Oct 24, 2011, at 9:43 AM, Ioannis Canellos wrote:
>
>> Hi David,
>>
>> apparently there a things that I miss.
>>
>> As far as I understand assemblies use the framework feature to generate the
>> startup properties. I assume the the framework feature is to be used by all
>> assemblies and so it needs to be as minimal possible.
>> Then each assembly can customize the content of its system folder, boot
>> features etc by specifying the features,bootfeatures etc.
>> If I understand things right, we need to add the deployer bundles as part of
>> some existing features or add new features for them if they do not fit
>> anywhere.
>>
>> --
>> *Ioannis Canellos*
>> *
>> FuseSource <http://fusesource.com>
>>
>> **
>> Blog: http://iocanel.blogspot.com
>> **
>> Apache Karaf <http://karaf.apache.org/> Committer & PMC
>> Apache ServiceMix <http://servicemix.apache.org/> Committer
>> Apache Gora <http://incubator.apache.org/gora/> Committer
>> *
>
Re: svn commit: r1188071 - /karaf/trunk/assemblies/features/framework/src/main/feature/feature.xml
Posted by David Jencks <da...@yahoo.com>.
Hi Ioannis,
I wish I'd got the documentation for this written and committed earlier :-(
Basically what you say is correct. These deployers used to be in the full kar/feature that jb removed in 1181815. I think we should basically revert that commit and bring back this feature/kar.
On the irc discussion I realized that the framework kar is currently a special case in that the feature isn't actually installed during assembly, the kar is just unpacked and it includes the base startup.properties file that the framework feature ought to generate. I think it would be better to actually install the framework feature as a <startup-feature> and have that installation process generate the startup.properties. I have some other things to work on this week but I'll try to experiment with that to see if it can be made to work..... plus hopefully some docs.
thanks!
david jencks
On Oct 24, 2011, at 9:43 AM, Ioannis Canellos wrote:
> Hi David,
>
> apparently there a things that I miss.
>
> As far as I understand assemblies use the framework feature to generate the
> startup properties. I assume the the framework feature is to be used by all
> assemblies and so it needs to be as minimal possible.
> Then each assembly can customize the content of its system folder, boot
> features etc by specifying the features,bootfeatures etc.
> If I understand things right, we need to add the deployer bundles as part of
> some existing features or add new features for them if they do not fit
> anywhere.
>
> --
> *Ioannis Canellos*
> *
> FuseSource <http://fusesource.com>
>
> **
> Blog: http://iocanel.blogspot.com
> **
> Apache Karaf <http://karaf.apache.org/> Committer & PMC
> Apache ServiceMix <http://servicemix.apache.org/> Committer
> Apache Gora <http://incubator.apache.org/gora/> Committer
> *
Re: svn commit: r1188071 - /karaf/trunk/assemblies/features/framework/src/main/feature/feature.xml
Posted by Ioannis Canellos <io...@gmail.com>.
Hi David,
apparently there a things that I miss.
As far as I understand assemblies use the framework feature to generate the
startup properties. I assume the the framework feature is to be used by all
assemblies and so it needs to be as minimal possible.
Then each assembly can customize the content of its system folder, boot
features etc by specifying the features,bootfeatures etc.
If I understand things right, we need to add the deployer bundles as part of
some existing features or add new features for them if they do not fit
anywhere.
--
*Ioannis Canellos*
*
FuseSource <http://fusesource.com>
**
Blog: http://iocanel.blogspot.com
**
Apache Karaf <http://karaf.apache.org/> Committer & PMC
Apache ServiceMix <http://servicemix.apache.org/> Committer
Apache Gora <http://incubator.apache.org/gora/> Committer
*