[jira] [Commented] (FLINK-9932) If task executor offer slot to job master timeout the first time, the slot will leak

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633307#comment-16633307 ] 

ASF GitHub Bot commented on FLINK-9932:
---------------------------------------

shuai-xu opened a new pull request #6780: [FLINK-9932] [runtime] fix slot leak when task executor offer slot to job master timeout
URL: https://github.com/apache/flink/pull/6780
 
 
   
   ## What is the purpose of the change
   
   *(For example: This pull request fix that the slots in task executor will leak if task executor fail to offer it to job master due to rpc timeout.)*
   
   ## Verifying this change
   
     - *Add a test in TaskExecutorTest*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no )
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> If task executor offer slot to job master timeout the first time, the slot will leak
> ------------------------------------------------------------------------------------
>
>                 Key: FLINK-9932
>                 URL: https://issues.apache.org/jira/browse/FLINK-9932
>             Project: Flink
>          Issue Type: Bug
>          Components: Cluster Management
>    Affects Versions: 1.5.0
>            Reporter: shuai.xu
>            Assignee: shuai.xu
>            Priority: Major
>              Labels: pull-request-available
>
> When task executor offer slot to job master, it will first mark the slot as active.
> If the offer slot call timeout, the task executor will try to call offerSlotsToJobManager again,
> but it will only offer the slot in ALLOCATED state. As the slot has already be mark ACTIVE, it will never be offered and this will cause slot leak.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)