[jira] [Commented] (TEZ-3044) Split TaskCommunicatorContext.taskHeartbeat into separate methods

["TezQA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233266#comment-15233266 ] 

TezQA commented on TEZ-3044:
----------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12782593/TEZ-3044.1.wip.txt
  against master revision 53981d4.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1642//console

This message is automatically generated.

> Split TaskCommunicatorContext.taskHeartbeat into separate methods
> -----------------------------------------------------------------
>
>                 Key: TEZ-3044
>                 URL: https://issues.apache.org/jira/browse/TEZ-3044
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>         Attachments: TEZ-3044.1.wip.txt
>
>
> taskHeartbeat currently handles 3 different operations
> 1. The heartbeat itself to indicate that the container is alive.
> 2. Reporting new events sent over by the task
> 3. Fetching events which are to be consumed by the task.
> All three can be independent.
> This does not affect the Tez wire protocol itself, which will continue to use a single call for all three. However this would get split within the default Tez AM plugin.
> The eventual intent is to allow plugins to control this functionality independently.
> An example: The addition of a eventsAvailable(Task*) on the TaskCommunicator allows a Plugin to get events the moment they're available and push them into the executors. Meanwhile, the heartbeat becomes just that - a heartbeat - and the frequency can be reduced to multiple seconds instead of the current milliseconds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)