You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/31 18:11:56 UTC
[GitHub] [airflow] coopergillan opened a new pull request #7309:
[AIRFLOW-4681] Make sensors module pylint compatible
coopergillan opened a new pull request #7309: [AIRFLOW-4681] Make sensors module pylint compatible
URL: https://github.com/apache/airflow/pull/7309
Make sensor modules pylint compatible. Rename and use some local rather than class variables and add comments to ignore some pylint checks around higher impact code.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7309: [AIRFLOW-4681] Make
sensors module pylint compatible
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7309: [AIRFLOW-4681] Make sensors module pylint compatible
URL: https://github.com/apache/airflow/pull/7309#issuecomment-581188315
Thanks @coopergillan !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7309: [AIRFLOW-4681] Make
sensors module pylint compatible
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7309: [AIRFLOW-4681] Make sensors module pylint compatible
URL: https://github.com/apache/airflow/pull/7309#issuecomment-581185662
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7309?src=pr&el=h1) Report
> Merging [#7309](https://codecov.io/gh/apache/airflow/pull/7309?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a311d3d82e0c2e32bcb56e29f33c95ed0a2a2ddc?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `75%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7309/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7309?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7309 +/- ##
==========================================
- Coverage 86.25% 85.99% -0.26%
==========================================
Files 867 867
Lines 40564 40564
==========================================
- Hits 34990 34885 -105
- Misses 5574 5679 +105
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7309?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...viders/apache/hive/sensors/named\_hive\_partition.py](https://codecov.io/gh/apache/airflow/pull/7309/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvc2Vuc29ycy9uYW1lZF9oaXZlX3BhcnRpdGlvbi5weQ==) | `90.69% <ø> (ø)` | :arrow_up: |
| [airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7309/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5) | `85.52% <ø> (ø)` | :arrow_up: |
| [...ow/providers/apache/hive/sensors/hive\_partition.py](https://codecov.io/gh/apache/airflow/pull/7309/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvc2Vuc29ycy9oaXZlX3BhcnRpdGlvbi5weQ==) | `36.36% <0%> (ø)` | :arrow_up: |
| [airflow/providers/apache/hdfs/sensors/web\_hdfs.py](https://codecov.io/gh/apache/airflow/pull/7309/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hkZnMvc2Vuc29ycy93ZWJfaGRmcy5weQ==) | `50% <0%> (ø)` | :arrow_up: |
| [airflow/providers/qubole/sensors/qubole.py](https://codecov.io/gh/apache/airflow/pull/7309/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcXVib2xlL3NlbnNvcnMvcXVib2xlLnB5) | `69.44% <0%> (ø)` | :arrow_up: |
| [airflow/providers/http/sensors/http.py](https://codecov.io/gh/apache/airflow/pull/7309/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvaHR0cC9zZW5zb3JzL2h0dHAucHk=) | `96.66% <100%> (ø)` | :arrow_up: |
| [airflow/providers/apache/hdfs/sensors/hdfs.py](https://codecov.io/gh/apache/airflow/pull/7309/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hkZnMvc2Vuc29ycy9oZGZzLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/sensors/bash.py](https://codecov.io/gh/apache/airflow/pull/7309/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2gucHk=) | `93.75% <100%> (-0.19%)` | :arrow_down: |
| [airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/7309/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5) | `98.61% <100%> (ø)` | :arrow_up: |
| [...iders/amazon/aws/sensors/glue\_catalog\_partition.py](https://codecov.io/gh/apache/airflow/pull/7309/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9zZW5zb3JzL2dsdWVfY2F0YWxvZ19wYXJ0aXRpb24ucHk=) | `100% <100%> (ø)` | :arrow_up: |
| ... and [9 more](https://codecov.io/gh/apache/airflow/pull/7309/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7309?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7309?src=pr&el=footer). Last update [a311d3d...5c1b3b1](https://codecov.io/gh/apache/airflow/pull/7309?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] coopergillan commented on issue #7309: [AIRFLOW-4681]
Make sensors module pylint compatible
Posted by GitBox <gi...@apache.org>.
coopergillan commented on issue #7309: [AIRFLOW-4681] Make sensors module pylint compatible
URL: https://github.com/apache/airflow/pull/7309#issuecomment-581185723
All right, this one should be good to go now. Let me know if it needs anything else. Thanks for the reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] coopergillan commented on issue #7309: [AIRFLOW-4681]
Make sensors module pylint compatible
Posted by GitBox <gi...@apache.org>.
coopergillan commented on issue #7309: [AIRFLOW-4681] Make sensors module pylint compatible
URL: https://github.com/apache/airflow/pull/7309#issuecomment-581181461
Will actually wait for #7342 and rebase on top of that one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] coopergillan commented on issue #7309: [AIRFLOW-4681]
Make sensors module pylint compatible
Posted by GitBox <gi...@apache.org>.
coopergillan commented on issue #7309: [AIRFLOW-4681] Make sensors module pylint compatible
URL: https://github.com/apache/airflow/pull/7309#issuecomment-580937766
Build failures look unrelated and transient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] coopergillan commented on a change in pull request #7309:
[AIRFLOW-4681] Make sensors module pylint compatible
Posted by GitBox <gi...@apache.org>.
coopergillan commented on a change in pull request #7309: [AIRFLOW-4681] Make sensors module pylint compatible
URL: https://github.com/apache/airflow/pull/7309#discussion_r373697332
##########
File path: airflow/providers/jira/sensors/jira.py
##########
@@ -68,7 +68,7 @@ class JiraTicketSensor(JiraSensor):
:param jira_conn_id: reference to a pre-defined Jira Connection
:type jira_conn_id: str
- :param ticket_id: id of the ticket to be monitored
+ state:param ticket_id: id of the ticket to be monitored
Review comment:
Nice catch, thank you! This snuck in somehow. Just pushed up a change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7309:
[AIRFLOW-4681] Make sensors module pylint compatible
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7309: [AIRFLOW-4681] Make sensors module pylint compatible
URL: https://github.com/apache/airflow/pull/7309#issuecomment-581185662
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7309?src=pr&el=h1) Report
> Merging [#7309](https://codecov.io/gh/apache/airflow/pull/7309?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a311d3d82e0c2e32bcb56e29f33c95ed0a2a2ddc?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `75%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7309/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7309?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7309 +/- ##
==========================================
- Coverage 86.25% 85.99% -0.26%
==========================================
Files 867 867
Lines 40564 40564
==========================================
- Hits 34990 34885 -105
- Misses 5574 5679 +105
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7309?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...viders/apache/hive/sensors/named\_hive\_partition.py](https://codecov.io/gh/apache/airflow/pull/7309/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvc2Vuc29ycy9uYW1lZF9oaXZlX3BhcnRpdGlvbi5weQ==) | `90.69% <ø> (ø)` | :arrow_up: |
| [airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7309/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5) | `85.52% <ø> (ø)` | :arrow_up: |
| [...ow/providers/apache/hive/sensors/hive\_partition.py](https://codecov.io/gh/apache/airflow/pull/7309/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvc2Vuc29ycy9oaXZlX3BhcnRpdGlvbi5weQ==) | `36.36% <0%> (ø)` | :arrow_up: |
| [airflow/providers/apache/hdfs/sensors/web\_hdfs.py](https://codecov.io/gh/apache/airflow/pull/7309/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hkZnMvc2Vuc29ycy93ZWJfaGRmcy5weQ==) | `50% <0%> (ø)` | :arrow_up: |
| [airflow/providers/qubole/sensors/qubole.py](https://codecov.io/gh/apache/airflow/pull/7309/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcXVib2xlL3NlbnNvcnMvcXVib2xlLnB5) | `69.44% <0%> (ø)` | :arrow_up: |
| [airflow/providers/http/sensors/http.py](https://codecov.io/gh/apache/airflow/pull/7309/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvaHR0cC9zZW5zb3JzL2h0dHAucHk=) | `96.66% <100%> (ø)` | :arrow_up: |
| [airflow/providers/apache/hdfs/sensors/hdfs.py](https://codecov.io/gh/apache/airflow/pull/7309/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hkZnMvc2Vuc29ycy9oZGZzLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/sensors/bash.py](https://codecov.io/gh/apache/airflow/pull/7309/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2gucHk=) | `93.75% <100%> (-0.19%)` | :arrow_down: |
| [airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/7309/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5) | `98.61% <100%> (ø)` | :arrow_up: |
| [...iders/amazon/aws/sensors/glue\_catalog\_partition.py](https://codecov.io/gh/apache/airflow/pull/7309/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9zZW5zb3JzL2dsdWVfY2F0YWxvZ19wYXJ0aXRpb24ucHk=) | `100% <100%> (ø)` | :arrow_up: |
| ... and [9 more](https://codecov.io/gh/apache/airflow/pull/7309/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7309?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7309?src=pr&el=footer). Last update [a311d3d...5c1b3b1](https://codecov.io/gh/apache/airflow/pull/7309?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] coopergillan commented on issue #7309: [AIRFLOW-4681]
Make sensors module pylint compatible
Posted by GitBox <gi...@apache.org>.
coopergillan commented on issue #7309: [AIRFLOW-4681] Make sensors module pylint compatible
URL: https://github.com/apache/airflow/pull/7309#issuecomment-581181039
Yep just pushed up a fixup for that one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] coopergillan commented on issue #7309: [AIRFLOW-4681]
Make sensors module pylint compatible
Posted by GitBox <gi...@apache.org>.
coopergillan commented on issue #7309: [AIRFLOW-4681] Make sensors module pylint compatible
URL: https://github.com/apache/airflow/pull/7309#issuecomment-580926362
Seeing [AIRFLOW-4681](https://issues.apache.org/jira/browse/AIRFLOW-4681) was marked as "Won't Do". Should we close this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7309: [AIRFLOW-4681] Make
sensors module pylint compatible
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7309: [AIRFLOW-4681] Make sensors module pylint compatible
URL: https://github.com/apache/airflow/pull/7309#issuecomment-580930406
No. Don't worry. This can be fixed later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7309: [AIRFLOW-4681] Make
sensors module pylint compatible
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7309: [AIRFLOW-4681] Make sensors module pylint compatible
URL: https://github.com/apache/airflow/pull/7309#issuecomment-581181028
> It is unrelated changes. I also saw it in another PR - #7341
Created https://github.com/apache/airflow/pull/7342 to fix it on master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7309: [AIRFLOW-4681] Make
sensors module pylint compatible
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7309: [AIRFLOW-4681] Make sensors module pylint compatible
URL: https://github.com/apache/airflow/pull/7309#issuecomment-581032385
Yep. I am working on the build errors in master still. I will let you know when to rebase when it is all fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7309: [AIRFLOW-4681] Make
sensors module pylint compatible
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7309: [AIRFLOW-4681] Make sensors module pylint compatible
URL: https://github.com/apache/airflow/pull/7309#issuecomment-581180347
It is unrelated changes. I also saw it in another PR - https://github.com/apache/airflow/pull/7341
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] coopergillan commented on issue #7309: [AIRFLOW-4681]
Make sensors module pylint compatible
Posted by GitBox <gi...@apache.org>.
coopergillan commented on issue #7309: [AIRFLOW-4681] Make sensors module pylint compatible
URL: https://github.com/apache/airflow/pull/7309#issuecomment-581179227
@potiuk @mik-laj - I just rebased from master, cleaned up some merge conflicts, and clarified some naming in the `HDFSSensor` module. All is squashed and pushed up. Thanks for the feedback!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #7309:
[AIRFLOW-4681] Make sensors module pylint compatible
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7309: [AIRFLOW-4681] Make sensors module pylint compatible
URL: https://github.com/apache/airflow/pull/7309#discussion_r373676561
##########
File path: airflow/providers/jira/sensors/jira.py
##########
@@ -68,7 +68,7 @@ class JiraTicketSensor(JiraSensor):
:param jira_conn_id: reference to a pre-defined Jira Connection
:type jira_conn_id: str
- :param ticket_id: id of the ticket to be monitored
+ state:param ticket_id: id of the ticket to be monitored
Review comment:
```suggestion
:param ticket_id: id of the ticket to be monitored
```
Travis is sad without this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7309: [AIRFLOW-4681] Make
sensors module pylint compatible
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7309: [AIRFLOW-4681] Make sensors module pylint compatible
URL: https://github.com/apache/airflow/pull/7309#issuecomment-581136072
Please rebase to latest master @coopergillan - we had a failing master drama and there is much higher chance the build will succeed. We have still some intermittent errors, but there should be less often.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7309: [AIRFLOW-4681] Make
sensors module pylint compatible
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7309: [AIRFLOW-4681] Make sensors module pylint compatible
URL: https://github.com/apache/airflow/pull/7309
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] coopergillan commented on issue #7309: [AIRFLOW-4681]
Make sensors module pylint compatible
Posted by GitBox <gi...@apache.org>.
coopergillan commented on issue #7309: [AIRFLOW-4681] Make sensors module pylint compatible
URL: https://github.com/apache/airflow/pull/7309#issuecomment-580881834
I did see https://github.com/apache/airflow/pull/5406, but noticed that it had been dormant for some time. I wanted to give it a shot from a fresh pull of `master`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7309: [AIRFLOW-4681] Make
sensors module pylint compatible
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7309: [AIRFLOW-4681] Make sensors module pylint compatible
URL: https://github.com/apache/airflow/pull/7309#issuecomment-581180165
Some pylint problems still :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services