[GitHub] [flink] pnowojski commented on a change in pull request #12027: [FLINK-17564][checkpointing] Fix buffer disorder issue of RemoteInputChannel for unaligned checkpoint

[GitBox <gi...@apache.org>]

pnowojski commented on a change in pull request #12027:
URL: https://github.com/apache/flink/pull/12027#discussion_r422484279



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -216,7 +220,7 @@ void retriggerSubpartitionRequest(int subpartitionIndex) throws IOException {
 	}
 
 	@Override
-	public List<Buffer> requestInflightBuffers(long checkpointId) throws IOException {
+	public void requestInflightBuffers(long checkpointId, ChannelStateWriter channelStateWriter) throws IOException {

Review comment:
       rename all of the methods `requestInflightBuffers` -> `spillInflightBuffers`? As this method is no longer returning/requesting but spilling inflight buffers?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org