[GitHub] [superset] john-bodley commented on a change in pull request #17383: fix: Partial revert of 17236

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #17383:
URL: https://github.com/apache/superset/pull/17383#discussion_r747194278



##########
File path: superset/utils/core.py
##########
@@ -1326,6 +1326,11 @@ def get_metric_names(metrics: Sequence[Metric]) -> List[str]:
     return [metric for metric in map(get_metric_name, metrics) if metric]
 
 
+def get_first_metric_name(metrics: Sequence[Metric]) -> Optional[str]:

Review comment:
       Although @etr2460 the function call `get_metric_names` but assigns these to the `metric_labels` variable thus the variable as opposed to the function could be misnamed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org