[jira] [Commented] (JCRVLT-236) Package Maven Plugin: Improve packateType param documentation

["Konrad Windszus (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCRVLT-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266907#comment-16266907 ] 

Konrad Windszus commented on JCRVLT-236:
----------------------------------------

The javadoc should clearly state what is currently enforced and what is not. Even the patched version contains documentation about the to-be state. The current state is that only `application` enforces a limitation, namely that ancestor nodes must be part of the package or some dependency. All other remarks refer to a future state (i.e. right now it is totally valid to include a bundle in an application package).

> Package Maven Plugin: Improve packateType param documentation
> -------------------------------------------------------------
>
>                 Key: JCRVLT-236
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-236
>             Project: Jackrabbit FileVault
>          Issue Type: Improvement
>          Components: package maven plugin
>    Affects Versions: package-maven-plugin-1.0.0
>            Reporter: Stefan Seifert
>            Priority: Trivial
>             Fix For: package-maven-plugin-1.0.1
>
>         Attachments: JCRVLT-236.patch
>
>
> the current documentation of the packageType is quite unclear for users and does not contain the information from the sources 
> https://github.com/apache/jackrabbit-filevault-package-maven-plugin/blob/trunk/src/main/java/org/apache/jackrabbit/filevault/maven/packaging/impl/PackageType.java



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)