You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/31 09:09:54 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #36023: [SPARK-38711][PYTHON][SS] Refactor pyspark.sql.streaming module
HyukjinKwon opened a new pull request #36023:
URL: https://github.com/apache/spark/pull/36023
### What changes were proposed in this pull request?
This PR changes `pyspark/sql/streaming.py` module to a package with two files: `pyspark/sql/streaming/query.py` and `pyspark/sql/streaming/readwriter.py`. This is similar with `pyspark/sql/dataframe.py` and `pyspark/sql/readwriter.py`.
There should be no user facing change because I kept the existing import at `pyspark/sql/streaming/__init__.py`.
### Why are the changes needed?
To make the codes easier to read.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
Existing test cases should cover this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #36023: [SPARK-38711][PYTHON][SS] Refactor pyspark.sql.streaming module
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #36023:
URL: https://github.com/apache/spark/pull/36023#issuecomment-1085228559
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #36023: [SPARK-38711][PYTHON][SS] Refactor pyspark.sql.streaming module
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #36023:
URL: https://github.com/apache/spark/pull/36023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #36023: [SPARK-38711][PYTHON][SS] Refactor pyspark.sql.streaming module
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #36023:
URL: https://github.com/apache/spark/pull/36023#issuecomment-1084301774
cc @zsxwing and @HeartSaVioR FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #36023: [SPARK-38711][PYTHON][SS] Refactor pyspark.sql.streaming module
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #36023:
URL: https://github.com/apache/spark/pull/36023#issuecomment-1084302157
For a bit of more background, I plan to add a couple of more modules under `pyspark.sql.streaming`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #36023: [SPARK-38711][PYTHON][SS] Refactor pyspark.sql.streaming module
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #36023:
URL: https://github.com/apache/spark/pull/36023#issuecomment-1085228343
Thanks @xinrong-databricks. cc @viirya too FYI. I am merging this as I don't think there's any controversial change here, and it's all consistent with the existing codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org