You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Mandukhai-Alimaa (via GitHub)" <gi...@apache.org> on 2025/12/07 03:27:00 UTC
[PR] feat(go/adbc/driver/databricks): add databricks:// uri support, tests, and docs [arrow-adbc]
Mandukhai-Alimaa opened a new pull request, #3771:
URL: https://github.com/apache/arrow-adbc/pull/3771
Support databricks:// URI scheme
Extend the current driver test to run with URI
Document URI formats
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(go/adbc/driver/databricks): add databricks:// uri support, tests, and docs [arrow-adbc]
Posted by "Mandukhai-Alimaa (via GitHub)" <gi...@apache.org>.
Mandukhai-Alimaa commented on code in PR #3771:
URL: https://github.com/apache/arrow-adbc/pull/3771#discussion_r2612586626
##########
go/adbc/driver/databricks/docs/databricks.md:
##########
Review Comment:
I removed the docs. I will make the PR for the docs when we move the driver over to the Driver Foundry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(go/adbc/driver/databricks): add databricks:// uri support, tests, and docs [arrow-adbc]
Posted by "Mandukhai-Alimaa (via GitHub)" <gi...@apache.org>.
Mandukhai-Alimaa commented on PR #3771:
URL: https://github.com/apache/arrow-adbc/pull/3771#issuecomment-3621550440
@lidavidm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(go/adbc/driver/databricks): add databricks:// uri support, tests, and docs [arrow-adbc]
Posted by "Mandukhai-Alimaa (via GitHub)" <gi...@apache.org>.
Mandukhai-Alimaa closed pull request #3771: feat(go/adbc/driver/databricks): add databricks:// uri support, tests, and docs
URL: https://github.com/apache/arrow-adbc/pull/3771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(go/adbc/driver/databricks): add databricks:// uri support, tests, and docs [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #3771:
URL: https://github.com/apache/arrow-adbc/pull/3771#discussion_r2612209838
##########
go/adbc/driver/databricks/database.go:
##########
Review Comment:
Ideally we could prohibit overlap between URI and other options
##########
go/adbc/driver/databricks/docs/databricks.md:
##########
Review Comment:
This docs format (and license header) do not apply to the upstream project
##########
go/adbc/driver/databricks/driver_test.go:
##########
@@ -336,6 +355,12 @@ func TestDatabricks(t *testing.T) {
})
}
+func TestDatabricksWithURI(t *testing.T) {
+ withQuirksURI(t, func(q *DatabricksQuirks) {
+ suite.Run(t, &DatabricksTests{Quirks: q})
+ })
+}
+
Review Comment:
I don't think we really need to run all tests again...just check that we can connect and execute a trivial query
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(go/adbc/driver/databricks): add databricks:// uri support, tests, and docs [arrow-adbc]
Posted by "Mandukhai-Alimaa (via GitHub)" <gi...@apache.org>.
Mandukhai-Alimaa commented on PR #3771:
URL: https://github.com/apache/arrow-adbc/pull/3771#issuecomment-3695176799
This PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org