You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Chuck Rolke (Created) (JIRA)" <ji...@apache.org> on 2012/03/08 20:39:57 UTC
[jira] [Created] (QPID-3891) Log-function switch injects too much
noise into log file
Log-function switch injects too much noise into log file
--------------------------------------------------------
Key: QPID-3891
URL: https://issues.apache.org/jira/browse/QPID-3891
Project: Qpid
Issue Type: Improvement
Components: C++ Broker
Affects Versions: 0.16
Reporter: Chuck Rolke
Assignee: Chuck Rolke
Fix For: Future
When the C++ Broker is started with '--log-function yes' the function name that gets printed is barely usable. From a coding standpoint it's pretty efficient but from a user standpoint raw BOOST_CURRENT_FUNCTION output is too much. For example here is the same log entry printed from two systems:
Linux:
2012-03-08 14:09:47 debug std::map<std::basic_string<char>, std::map<qpid::management::ManagementAgent::SchemaClassKey, qpid::management::ManagementAgent::SchemaClass, qpid::management::ManagementAgent::SchemaClassKeyComp> >::iterator qpid::management::ManagementAgent::findOrAddPackageLH(std::string): SEND PackageInd package=org.apache.qpid.broker to=schema.package
Windows:
2012-03-06 14:20:05 debug class std::_Tree_iterator<class std::_Tree_val<class std::_Tmap_traits<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::map<struct qpid::management::ManagementAgent::SchemaClassKey,struct qpid::management::ManagementAgent::SchemaClass,struct qpid::management::ManagementAgent::SchemaClassKeyComp,class std::allocator<structstd::pair<struct qpid::management::ManagementAgent::SchemaClassKey const ,struct qpid::management::ManagementAgent::SchemaClass> > >,struct std::less<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > >,class std::allocator<struct std::pair<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const ,class std::map<struct qpid::management::ManagementAgent::SchemaClassKey,struct qpid::management::ManagementAgent::SchemaClass,struct qpid::management::ManagementAgent::SchemaClassKeyComp,class std::allocator<struct std::pair<struct qpid::management::ManagementAgent::SchemaClassKey const ,struct qpid::management::ManagementAgent::SchemaClass> > > > >,0> > > __thiscall qpid::management::ManagementAgent::findOrAddPackageLH(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >): SEND PackageInd package=org.apache.qpid.broker to=schema.package
This level of detail has no use. An easy improvement is to print only the class and function names and not to print the function return type and the function arguments.
Trimmed:
2012-03-06 16:55:38 debug qpid::management::ManagementAgent::findOrAddPackageLH: SEND PackageInd package=org.apache.qpid.broker to=schema.package
Coincidently, these function names in all their glory are what is used for log message filtering. If one specifies '--log-enable debug+:_Tree_iterator' then the Windows log will be emitted but the Linux log will not. By trimming the function name then Windows and Linux will get the same filter results.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-3891) C++ Broker --log-function switch
injects too much noise into log file
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225897#comment-13225897 ]
jiraposter@reviews.apache.org commented on QPID-3891:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4261/#review5767
-----------------------------------------------------------
Ship it!
- Gordon
On 2012-03-08 21:52:15, Chug Rolke wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4261/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-08 21:52:15)
bq.
bq.
bq. Review request for qpid, Andrew Stitcher, Alan Conway, and Gordon Sim.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. QPID-3891 C++ Broker --log-function log output is overwhelming. This patch trims the BOOST_CURRENT_FUNCTION text down to only the namespace-qualified-functionName.
bq.
bq.
bq. This addresses bug QPID-3891.
bq. https://issues.apache.org/jira/browse/QPID-3891
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/qpid/cpp/src/qpid/log/Statement.cpp 1297553
bq. trunk/qpid/cpp/src/tests/logging.cpp 1297553
bq.
bq. Diff: https://reviews.apache.org/r/4261/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Passes modified Unit test.
bq.
bq.
bq. Thanks,
bq.
bq. Chug
bq.
bq.
> C++ Broker --log-function switch injects too much noise into log file
> ---------------------------------------------------------------------
>
> Key: QPID-3891
> URL: https://issues.apache.org/jira/browse/QPID-3891
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.16
> Reporter: Chuck Rolke
> Assignee: Chuck Rolke
> Fix For: Future
>
>
> When the C++ Broker is started with '--log-function yes' the function name that gets printed is barely usable. From a coding standpoint it's pretty efficient but from a user standpoint raw BOOST_CURRENT_FUNCTION output is too much. For example here is the same log entry printed from two systems:
> Linux:
> 2012-03-08 14:09:47 debug std::map<std::basic_string<char>, std::map<qpid::management::ManagementAgent::SchemaClassKey, qpid::management::ManagementAgent::SchemaClass, qpid::management::ManagementAgent::SchemaClassKeyComp> >::iterator qpid::management::ManagementAgent::findOrAddPackageLH(std::string): SEND PackageInd package=org.apache.qpid.broker to=schema.package
> Windows:
> 2012-03-06 14:20:05 debug class std::_Tree_iterator<class std::_Tree_val<class std::_Tmap_traits<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::map<struct qpid::management::ManagementAgent::SchemaClassKey,struct qpid::management::ManagementAgent::SchemaClass,struct qpid::management::ManagementAgent::SchemaClassKeyComp,class std::allocator<structstd::pair<struct qpid::management::ManagementAgent::SchemaClassKey const ,struct qpid::management::ManagementAgent::SchemaClass> > >,struct std::less<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > >,class std::allocator<struct std::pair<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const ,class std::map<struct qpid::management::ManagementAgent::SchemaClassKey,struct qpid::management::ManagementAgent::SchemaClass,struct qpid::management::ManagementAgent::SchemaClassKeyComp,class std::allocator<struct std::pair<struct qpid::management::ManagementAgent::SchemaClassKey const ,struct qpid::management::ManagementAgent::SchemaClass> > > > >,0> > > __thiscall qpid::management::ManagementAgent::findOrAddPackageLH(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >): SEND PackageInd package=org.apache.qpid.broker to=schema.package
> This level of detail has no use. An easy improvement is to print only the class and function names and not to print the function return type and the function arguments.
> Trimmed:
> 2012-03-06 16:55:38 debug qpid::management::ManagementAgent::findOrAddPackageLH: SEND PackageInd package=org.apache.qpid.broker to=schema.package
> Coincidently, these function names in all their glory are what is used for log message filtering. If one specifies '--log-enable debug+:_Tree_iterator' then the Windows log will be emitted but the Linux log will not. By trimming the function name then Windows and Linux will get the same filter results.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-3891) C++ Broker --log-function switch
injects too much noise into log file
Posted by "Chuck Rolke (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chuck Rolke updated QPID-3891:
------------------------------
Summary: C++ Broker --log-function switch injects too much noise into log file (was: Log-function switch injects too much noise into log file)
> C++ Broker --log-function switch injects too much noise into log file
> ---------------------------------------------------------------------
>
> Key: QPID-3891
> URL: https://issues.apache.org/jira/browse/QPID-3891
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.16
> Reporter: Chuck Rolke
> Assignee: Chuck Rolke
> Fix For: Future
>
>
> When the C++ Broker is started with '--log-function yes' the function name that gets printed is barely usable. From a coding standpoint it's pretty efficient but from a user standpoint raw BOOST_CURRENT_FUNCTION output is too much. For example here is the same log entry printed from two systems:
> Linux:
> 2012-03-08 14:09:47 debug std::map<std::basic_string<char>, std::map<qpid::management::ManagementAgent::SchemaClassKey, qpid::management::ManagementAgent::SchemaClass, qpid::management::ManagementAgent::SchemaClassKeyComp> >::iterator qpid::management::ManagementAgent::findOrAddPackageLH(std::string): SEND PackageInd package=org.apache.qpid.broker to=schema.package
> Windows:
> 2012-03-06 14:20:05 debug class std::_Tree_iterator<class std::_Tree_val<class std::_Tmap_traits<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::map<struct qpid::management::ManagementAgent::SchemaClassKey,struct qpid::management::ManagementAgent::SchemaClass,struct qpid::management::ManagementAgent::SchemaClassKeyComp,class std::allocator<structstd::pair<struct qpid::management::ManagementAgent::SchemaClassKey const ,struct qpid::management::ManagementAgent::SchemaClass> > >,struct std::less<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > >,class std::allocator<struct std::pair<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const ,class std::map<struct qpid::management::ManagementAgent::SchemaClassKey,struct qpid::management::ManagementAgent::SchemaClass,struct qpid::management::ManagementAgent::SchemaClassKeyComp,class std::allocator<struct std::pair<struct qpid::management::ManagementAgent::SchemaClassKey const ,struct qpid::management::ManagementAgent::SchemaClass> > > > >,0> > > __thiscall qpid::management::ManagementAgent::findOrAddPackageLH(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >): SEND PackageInd package=org.apache.qpid.broker to=schema.package
> This level of detail has no use. An easy improvement is to print only the class and function names and not to print the function return type and the function arguments.
> Trimmed:
> 2012-03-06 16:55:38 debug qpid::management::ManagementAgent::findOrAddPackageLH: SEND PackageInd package=org.apache.qpid.broker to=schema.package
> Coincidently, these function names in all their glory are what is used for log message filtering. If one specifies '--log-enable debug+:_Tree_iterator' then the Windows log will be emitted but the Linux log will not. By trimming the function name then Windows and Linux will get the same filter results.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-3891) C++ Broker --log-function switch
injects too much noise into log file
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225547#comment-13225547 ]
jiraposter@reviews.apache.org commented on QPID-3891:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4261/
-----------------------------------------------------------
Review request for qpid, Andrew Stitcher, Alan Conway, and Gordon Sim.
Summary
-------
QPID-3891 C++ Broker --log-function log output is overwhelming. This patch trims the BOOST_CURRENT_FUNCTION text down to only the namespace-qualified-functionName.
This addresses bug QPID-3891.
https://issues.apache.org/jira/browse/QPID-3891
Diffs
-----
Diff: https://reviews.apache.org/r/4261/diff
Testing
-------
Passes modified Unit test.
Thanks,
Chug
> C++ Broker --log-function switch injects too much noise into log file
> ---------------------------------------------------------------------
>
> Key: QPID-3891
> URL: https://issues.apache.org/jira/browse/QPID-3891
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.16
> Reporter: Chuck Rolke
> Assignee: Chuck Rolke
> Fix For: Future
>
>
> When the C++ Broker is started with '--log-function yes' the function name that gets printed is barely usable. From a coding standpoint it's pretty efficient but from a user standpoint raw BOOST_CURRENT_FUNCTION output is too much. For example here is the same log entry printed from two systems:
> Linux:
> 2012-03-08 14:09:47 debug std::map<std::basic_string<char>, std::map<qpid::management::ManagementAgent::SchemaClassKey, qpid::management::ManagementAgent::SchemaClass, qpid::management::ManagementAgent::SchemaClassKeyComp> >::iterator qpid::management::ManagementAgent::findOrAddPackageLH(std::string): SEND PackageInd package=org.apache.qpid.broker to=schema.package
> Windows:
> 2012-03-06 14:20:05 debug class std::_Tree_iterator<class std::_Tree_val<class std::_Tmap_traits<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::map<struct qpid::management::ManagementAgent::SchemaClassKey,struct qpid::management::ManagementAgent::SchemaClass,struct qpid::management::ManagementAgent::SchemaClassKeyComp,class std::allocator<structstd::pair<struct qpid::management::ManagementAgent::SchemaClassKey const ,struct qpid::management::ManagementAgent::SchemaClass> > >,struct std::less<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > >,class std::allocator<struct std::pair<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const ,class std::map<struct qpid::management::ManagementAgent::SchemaClassKey,struct qpid::management::ManagementAgent::SchemaClass,struct qpid::management::ManagementAgent::SchemaClassKeyComp,class std::allocator<struct std::pair<struct qpid::management::ManagementAgent::SchemaClassKey const ,struct qpid::management::ManagementAgent::SchemaClass> > > > >,0> > > __thiscall qpid::management::ManagementAgent::findOrAddPackageLH(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >): SEND PackageInd package=org.apache.qpid.broker to=schema.package
> This level of detail has no use. An easy improvement is to print only the class and function names and not to print the function return type and the function arguments.
> Trimmed:
> 2012-03-06 16:55:38 debug qpid::management::ManagementAgent::findOrAddPackageLH: SEND PackageInd package=org.apache.qpid.broker to=schema.package
> Coincidently, these function names in all their glory are what is used for log message filtering. If one specifies '--log-enable debug+:_Tree_iterator' then the Windows log will be emitted but the Linux log will not. By trimming the function name then Windows and Linux will get the same filter results.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-3891) C++ Broker --log-function switch
injects too much noise into log file
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226092#comment-13226092 ]
jiraposter@reviews.apache.org commented on QPID-3891:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4261/#review5778
-----------------------------------------------------------
Have you run this under valgrind? I want to be sure your function names are not reported as leaks. They probably are not but I'm not 100% sure. If they're not reported then ship it!
- Alan
On 2012-03-08 21:52:15, Chug Rolke wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4261/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-08 21:52:15)
bq.
bq.
bq. Review request for qpid, Andrew Stitcher, Alan Conway, and Gordon Sim.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. QPID-3891 C++ Broker --log-function log output is overwhelming. This patch trims the BOOST_CURRENT_FUNCTION text down to only the namespace-qualified-functionName.
bq.
bq.
bq. This addresses bug QPID-3891.
bq. https://issues.apache.org/jira/browse/QPID-3891
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/qpid/cpp/src/qpid/log/Statement.cpp 1297553
bq. trunk/qpid/cpp/src/tests/logging.cpp 1297553
bq.
bq. Diff: https://reviews.apache.org/r/4261/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Passes modified Unit test.
bq.
bq.
bq. Thanks,
bq.
bq. Chug
bq.
bq.
> C++ Broker --log-function switch injects too much noise into log file
> ---------------------------------------------------------------------
>
> Key: QPID-3891
> URL: https://issues.apache.org/jira/browse/QPID-3891
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.16
> Reporter: Chuck Rolke
> Assignee: Chuck Rolke
> Fix For: Future
>
>
> When the C++ Broker is started with '--log-function yes' the function name that gets printed is barely usable. From a coding standpoint it's pretty efficient but from a user standpoint raw BOOST_CURRENT_FUNCTION output is too much. For example here is the same log entry printed from two systems:
> Linux:
> 2012-03-08 14:09:47 debug std::map<std::basic_string<char>, std::map<qpid::management::ManagementAgent::SchemaClassKey, qpid::management::ManagementAgent::SchemaClass, qpid::management::ManagementAgent::SchemaClassKeyComp> >::iterator qpid::management::ManagementAgent::findOrAddPackageLH(std::string): SEND PackageInd package=org.apache.qpid.broker to=schema.package
> Windows:
> 2012-03-06 14:20:05 debug class std::_Tree_iterator<class std::_Tree_val<class std::_Tmap_traits<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::map<struct qpid::management::ManagementAgent::SchemaClassKey,struct qpid::management::ManagementAgent::SchemaClass,struct qpid::management::ManagementAgent::SchemaClassKeyComp,class std::allocator<structstd::pair<struct qpid::management::ManagementAgent::SchemaClassKey const ,struct qpid::management::ManagementAgent::SchemaClass> > >,struct std::less<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > >,class std::allocator<struct std::pair<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const ,class std::map<struct qpid::management::ManagementAgent::SchemaClassKey,struct qpid::management::ManagementAgent::SchemaClass,struct qpid::management::ManagementAgent::SchemaClassKeyComp,class std::allocator<struct std::pair<struct qpid::management::ManagementAgent::SchemaClassKey const ,struct qpid::management::ManagementAgent::SchemaClass> > > > >,0> > > __thiscall qpid::management::ManagementAgent::findOrAddPackageLH(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >): SEND PackageInd package=org.apache.qpid.broker to=schema.package
> This level of detail has no use. An easy improvement is to print only the class and function names and not to print the function return type and the function arguments.
> Trimmed:
> 2012-03-06 16:55:38 debug qpid::management::ManagementAgent::findOrAddPackageLH: SEND PackageInd package=org.apache.qpid.broker to=schema.package
> Coincidently, these function names in all their glory are what is used for log message filtering. If one specifies '--log-enable debug+:_Tree_iterator' then the Windows log will be emitted but the Linux log will not. By trimming the function name then Windows and Linux will get the same filter results.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-3891) C++ Broker --log-function switch
injects too much noise into log file
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229278#comment-13229278 ]
jiraposter@reviews.apache.org commented on QPID-3891:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4261/#review5941
-----------------------------------------------------------
trunk/qpid/cpp/src/qpid/log/Statement.cpp
<https://reviews.apache.org/r/4261/#comment12903>
I recommend splitting this out into its own (suitably named) function and using that in the constructor here.
Incidentally the comment is incorrect in that there is no "return" per se.
You can make the function static and inline if efficiency is a specific concern.
- Andrew
On 2012-03-08 21:52:15, Chug Rolke wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4261/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-08 21:52:15)
bq.
bq.
bq. Review request for qpid, Andrew Stitcher, Alan Conway, and Gordon Sim.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. QPID-3891 C++ Broker --log-function log output is overwhelming. This patch trims the BOOST_CURRENT_FUNCTION text down to only the namespace-qualified-functionName.
bq.
bq.
bq. This addresses bug QPID-3891.
bq. https://issues.apache.org/jira/browse/QPID-3891
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/qpid/cpp/src/qpid/log/Statement.cpp 1297553
bq. trunk/qpid/cpp/src/tests/logging.cpp 1297553
bq.
bq. Diff: https://reviews.apache.org/r/4261/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Passes modified Unit test.
bq.
bq.
bq. Thanks,
bq.
bq. Chug
bq.
bq.
> C++ Broker --log-function switch injects too much noise into log file
> ---------------------------------------------------------------------
>
> Key: QPID-3891
> URL: https://issues.apache.org/jira/browse/QPID-3891
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.16
> Reporter: Chuck Rolke
> Assignee: Chuck Rolke
> Fix For: Future
>
>
> When the C++ Broker is started with '--log-function yes' the function name that gets printed is barely usable. From a coding standpoint it's pretty efficient but from a user standpoint raw BOOST_CURRENT_FUNCTION output is too much. For example here is the same log entry printed from two systems:
> Linux:
> 2012-03-08 14:09:47 debug std::map<std::basic_string<char>, std::map<qpid::management::ManagementAgent::SchemaClassKey, qpid::management::ManagementAgent::SchemaClass, qpid::management::ManagementAgent::SchemaClassKeyComp> >::iterator qpid::management::ManagementAgent::findOrAddPackageLH(std::string): SEND PackageInd package=org.apache.qpid.broker to=schema.package
> Windows:
> 2012-03-06 14:20:05 debug class std::_Tree_iterator<class std::_Tree_val<class std::_Tmap_traits<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::map<struct qpid::management::ManagementAgent::SchemaClassKey,struct qpid::management::ManagementAgent::SchemaClass,struct qpid::management::ManagementAgent::SchemaClassKeyComp,class std::allocator<structstd::pair<struct qpid::management::ManagementAgent::SchemaClassKey const ,struct qpid::management::ManagementAgent::SchemaClass> > >,struct std::less<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > >,class std::allocator<struct std::pair<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const ,class std::map<struct qpid::management::ManagementAgent::SchemaClassKey,struct qpid::management::ManagementAgent::SchemaClass,struct qpid::management::ManagementAgent::SchemaClassKeyComp,class std::allocator<struct std::pair<struct qpid::management::ManagementAgent::SchemaClassKey const ,struct qpid::management::ManagementAgent::SchemaClass> > > > >,0> > > __thiscall qpid::management::ManagementAgent::findOrAddPackageLH(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >): SEND PackageInd package=org.apache.qpid.broker to=schema.package
> This level of detail has no use. An easy improvement is to print only the class and function names and not to print the function return type and the function arguments.
> Trimmed:
> 2012-03-06 16:55:38 debug qpid::management::ManagementAgent::findOrAddPackageLH: SEND PackageInd package=org.apache.qpid.broker to=schema.package
> Coincidently, these function names in all their glory are what is used for log message filtering. If one specifies '--log-enable debug+:_Tree_iterator' then the Windows log will be emitted but the Linux log will not. By trimming the function name then Windows and Linux will get the same filter results.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-3891) C++ Broker --log-function switch
injects too much noise into log file
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229270#comment-13229270 ]
jiraposter@reviews.apache.org commented on QPID-3891:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4261/#review5940
-----------------------------------------------------------
trunk/qpid/cpp/src/qpid/log/Statement.cpp
<https://reviews.apache.org/r/4261/#comment12902>
Don't put bug information in comments! It becomes out of date and is impossible to maintain (and it's just duplicating what source control does in any event)
- Andrew
On 2012-03-08 21:52:15, Chug Rolke wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4261/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-08 21:52:15)
bq.
bq.
bq. Review request for qpid, Andrew Stitcher, Alan Conway, and Gordon Sim.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. QPID-3891 C++ Broker --log-function log output is overwhelming. This patch trims the BOOST_CURRENT_FUNCTION text down to only the namespace-qualified-functionName.
bq.
bq.
bq. This addresses bug QPID-3891.
bq. https://issues.apache.org/jira/browse/QPID-3891
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/qpid/cpp/src/qpid/log/Statement.cpp 1297553
bq. trunk/qpid/cpp/src/tests/logging.cpp 1297553
bq.
bq. Diff: https://reviews.apache.org/r/4261/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Passes modified Unit test.
bq.
bq.
bq. Thanks,
bq.
bq. Chug
bq.
bq.
> C++ Broker --log-function switch injects too much noise into log file
> ---------------------------------------------------------------------
>
> Key: QPID-3891
> URL: https://issues.apache.org/jira/browse/QPID-3891
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.16
> Reporter: Chuck Rolke
> Assignee: Chuck Rolke
> Fix For: Future
>
>
> When the C++ Broker is started with '--log-function yes' the function name that gets printed is barely usable. From a coding standpoint it's pretty efficient but from a user standpoint raw BOOST_CURRENT_FUNCTION output is too much. For example here is the same log entry printed from two systems:
> Linux:
> 2012-03-08 14:09:47 debug std::map<std::basic_string<char>, std::map<qpid::management::ManagementAgent::SchemaClassKey, qpid::management::ManagementAgent::SchemaClass, qpid::management::ManagementAgent::SchemaClassKeyComp> >::iterator qpid::management::ManagementAgent::findOrAddPackageLH(std::string): SEND PackageInd package=org.apache.qpid.broker to=schema.package
> Windows:
> 2012-03-06 14:20:05 debug class std::_Tree_iterator<class std::_Tree_val<class std::_Tmap_traits<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::map<struct qpid::management::ManagementAgent::SchemaClassKey,struct qpid::management::ManagementAgent::SchemaClass,struct qpid::management::ManagementAgent::SchemaClassKeyComp,class std::allocator<structstd::pair<struct qpid::management::ManagementAgent::SchemaClassKey const ,struct qpid::management::ManagementAgent::SchemaClass> > >,struct std::less<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > >,class std::allocator<struct std::pair<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const ,class std::map<struct qpid::management::ManagementAgent::SchemaClassKey,struct qpid::management::ManagementAgent::SchemaClass,struct qpid::management::ManagementAgent::SchemaClassKeyComp,class std::allocator<struct std::pair<struct qpid::management::ManagementAgent::SchemaClassKey const ,struct qpid::management::ManagementAgent::SchemaClass> > > > >,0> > > __thiscall qpid::management::ManagementAgent::findOrAddPackageLH(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >): SEND PackageInd package=org.apache.qpid.broker to=schema.package
> This level of detail has no use. An easy improvement is to print only the class and function names and not to print the function return type and the function arguments.
> Trimmed:
> 2012-03-06 16:55:38 debug qpid::management::ManagementAgent::findOrAddPackageLH: SEND PackageInd package=org.apache.qpid.broker to=schema.package
> Coincidently, these function names in all their glory are what is used for log message filtering. If one specifies '--log-enable debug+:_Tree_iterator' then the Windows log will be emitted but the Linux log will not. By trimming the function name then Windows and Linux will get the same filter results.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Resolved] (QPID-3891) C++ Broker --log-function switch
injects too much noise into log file
Posted by "Chuck Rolke (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chuck Rolke resolved QPID-3891.
-------------------------------
Resolution: Fixed
Fixed in 0.17
> C++ Broker --log-function switch injects too much noise into log file
> ---------------------------------------------------------------------
>
> Key: QPID-3891
> URL: https://issues.apache.org/jira/browse/QPID-3891
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.16
> Reporter: Chuck Rolke
> Assignee: Chuck Rolke
> Fix For: Future
>
>
> When the C++ Broker is started with '--log-function yes' the function name that gets printed is barely usable. From a coding standpoint it's pretty efficient but from a user standpoint raw BOOST_CURRENT_FUNCTION output is too much. For example here is the same log entry printed from two systems:
> Linux:
> 2012-03-08 14:09:47 debug std::map<std::basic_string<char>, std::map<qpid::management::ManagementAgent::SchemaClassKey, qpid::management::ManagementAgent::SchemaClass, qpid::management::ManagementAgent::SchemaClassKeyComp> >::iterator qpid::management::ManagementAgent::findOrAddPackageLH(std::string): SEND PackageInd package=org.apache.qpid.broker to=schema.package
> Windows:
> 2012-03-06 14:20:05 debug class std::_Tree_iterator<class std::_Tree_val<class std::_Tmap_traits<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::map<struct qpid::management::ManagementAgent::SchemaClassKey,struct qpid::management::ManagementAgent::SchemaClass,struct qpid::management::ManagementAgent::SchemaClassKeyComp,class std::allocator<structstd::pair<struct qpid::management::ManagementAgent::SchemaClassKey const ,struct qpid::management::ManagementAgent::SchemaClass> > >,struct std::less<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > >,class std::allocator<struct std::pair<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const ,class std::map<struct qpid::management::ManagementAgent::SchemaClassKey,struct qpid::management::ManagementAgent::SchemaClass,struct qpid::management::ManagementAgent::SchemaClassKeyComp,class std::allocator<struct std::pair<struct qpid::management::ManagementAgent::SchemaClassKey const ,struct qpid::management::ManagementAgent::SchemaClass> > > > >,0> > > __thiscall qpid::management::ManagementAgent::findOrAddPackageLH(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >): SEND PackageInd package=org.apache.qpid.broker to=schema.package
> This level of detail has no use. An easy improvement is to print only the class and function names and not to print the function return type and the function arguments.
> Trimmed:
> 2012-03-06 16:55:38 debug qpid::management::ManagementAgent::findOrAddPackageLH: SEND PackageInd package=org.apache.qpid.broker to=schema.package
> Coincidently, these function names in all their glory are what is used for log message filtering. If one specifies '--log-enable debug+:_Tree_iterator' then the Windows log will be emitted but the Linux log will not. By trimming the function name then Windows and Linux will get the same filter results.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-3891) C++ Broker --log-function switch
injects too much noise into log file
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225568#comment-13225568 ]
jiraposter@reviews.apache.org commented on QPID-3891:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4261/
-----------------------------------------------------------
(Updated 2012-03-08 21:52:15.960402)
Review request for qpid, Andrew Stitcher, Alan Conway, and Gordon Sim.
Changes
-------
Upload diffs.
Summary
-------
QPID-3891 C++ Broker --log-function log output is overwhelming. This patch trims the BOOST_CURRENT_FUNCTION text down to only the namespace-qualified-functionName.
This addresses bug QPID-3891.
https://issues.apache.org/jira/browse/QPID-3891
Diffs (updated)
-----
trunk/qpid/cpp/src/qpid/log/Statement.cpp 1297553
trunk/qpid/cpp/src/tests/logging.cpp 1297553
Diff: https://reviews.apache.org/r/4261/diff
Testing
-------
Passes modified Unit test.
Thanks,
Chug
> C++ Broker --log-function switch injects too much noise into log file
> ---------------------------------------------------------------------
>
> Key: QPID-3891
> URL: https://issues.apache.org/jira/browse/QPID-3891
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.16
> Reporter: Chuck Rolke
> Assignee: Chuck Rolke
> Fix For: Future
>
>
> When the C++ Broker is started with '--log-function yes' the function name that gets printed is barely usable. From a coding standpoint it's pretty efficient but from a user standpoint raw BOOST_CURRENT_FUNCTION output is too much. For example here is the same log entry printed from two systems:
> Linux:
> 2012-03-08 14:09:47 debug std::map<std::basic_string<char>, std::map<qpid::management::ManagementAgent::SchemaClassKey, qpid::management::ManagementAgent::SchemaClass, qpid::management::ManagementAgent::SchemaClassKeyComp> >::iterator qpid::management::ManagementAgent::findOrAddPackageLH(std::string): SEND PackageInd package=org.apache.qpid.broker to=schema.package
> Windows:
> 2012-03-06 14:20:05 debug class std::_Tree_iterator<class std::_Tree_val<class std::_Tmap_traits<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::map<struct qpid::management::ManagementAgent::SchemaClassKey,struct qpid::management::ManagementAgent::SchemaClass,struct qpid::management::ManagementAgent::SchemaClassKeyComp,class std::allocator<structstd::pair<struct qpid::management::ManagementAgent::SchemaClassKey const ,struct qpid::management::ManagementAgent::SchemaClass> > >,struct std::less<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > >,class std::allocator<struct std::pair<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const ,class std::map<struct qpid::management::ManagementAgent::SchemaClassKey,struct qpid::management::ManagementAgent::SchemaClass,struct qpid::management::ManagementAgent::SchemaClassKeyComp,class std::allocator<struct std::pair<struct qpid::management::ManagementAgent::SchemaClassKey const ,struct qpid::management::ManagementAgent::SchemaClass> > > > >,0> > > __thiscall qpid::management::ManagementAgent::findOrAddPackageLH(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >): SEND PackageInd package=org.apache.qpid.broker to=schema.package
> This level of detail has no use. An easy improvement is to print only the class and function names and not to print the function return type and the function arguments.
> Trimmed:
> 2012-03-06 16:55:38 debug qpid::management::ManagementAgent::findOrAddPackageLH: SEND PackageInd package=org.apache.qpid.broker to=schema.package
> Coincidently, these function names in all their glory are what is used for log message filtering. If one specifies '--log-enable debug+:_Tree_iterator' then the Windows log will be emitted but the Linux log will not. By trimming the function name then Windows and Linux will get the same filter results.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-3891) C++ Broker --log-function switch
injects too much noise into log file
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225565#comment-13225565 ]
jiraposter@reviews.apache.org commented on QPID-3891:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4261/#review5752
-----------------------------------------------------------
Ship it!
That's the least intrusive change I've ever seen. :P
- Kenneth
On 2012-03-08 21:31:11, Chug Rolke wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4261/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-08 21:31:11)
bq.
bq.
bq. Review request for qpid, Andrew Stitcher, Alan Conway, and Gordon Sim.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. QPID-3891 C++ Broker --log-function log output is overwhelming. This patch trims the BOOST_CURRENT_FUNCTION text down to only the namespace-qualified-functionName.
bq.
bq.
bq. This addresses bug QPID-3891.
bq. https://issues.apache.org/jira/browse/QPID-3891
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
bq. Diff: https://reviews.apache.org/r/4261/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Passes modified Unit test.
bq.
bq.
bq. Thanks,
bq.
bq. Chug
bq.
bq.
> C++ Broker --log-function switch injects too much noise into log file
> ---------------------------------------------------------------------
>
> Key: QPID-3891
> URL: https://issues.apache.org/jira/browse/QPID-3891
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.16
> Reporter: Chuck Rolke
> Assignee: Chuck Rolke
> Fix For: Future
>
>
> When the C++ Broker is started with '--log-function yes' the function name that gets printed is barely usable. From a coding standpoint it's pretty efficient but from a user standpoint raw BOOST_CURRENT_FUNCTION output is too much. For example here is the same log entry printed from two systems:
> Linux:
> 2012-03-08 14:09:47 debug std::map<std::basic_string<char>, std::map<qpid::management::ManagementAgent::SchemaClassKey, qpid::management::ManagementAgent::SchemaClass, qpid::management::ManagementAgent::SchemaClassKeyComp> >::iterator qpid::management::ManagementAgent::findOrAddPackageLH(std::string): SEND PackageInd package=org.apache.qpid.broker to=schema.package
> Windows:
> 2012-03-06 14:20:05 debug class std::_Tree_iterator<class std::_Tree_val<class std::_Tmap_traits<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::map<struct qpid::management::ManagementAgent::SchemaClassKey,struct qpid::management::ManagementAgent::SchemaClass,struct qpid::management::ManagementAgent::SchemaClassKeyComp,class std::allocator<structstd::pair<struct qpid::management::ManagementAgent::SchemaClassKey const ,struct qpid::management::ManagementAgent::SchemaClass> > >,struct std::less<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > >,class std::allocator<struct std::pair<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const ,class std::map<struct qpid::management::ManagementAgent::SchemaClassKey,struct qpid::management::ManagementAgent::SchemaClass,struct qpid::management::ManagementAgent::SchemaClassKeyComp,class std::allocator<struct std::pair<struct qpid::management::ManagementAgent::SchemaClassKey const ,struct qpid::management::ManagementAgent::SchemaClass> > > > >,0> > > __thiscall qpid::management::ManagementAgent::findOrAddPackageLH(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >): SEND PackageInd package=org.apache.qpid.broker to=schema.package
> This level of detail has no use. An easy improvement is to print only the class and function names and not to print the function return type and the function arguments.
> Trimmed:
> 2012-03-06 16:55:38 debug qpid::management::ManagementAgent::findOrAddPackageLH: SEND PackageInd package=org.apache.qpid.broker to=schema.package
> Coincidently, these function names in all their glory are what is used for log message filtering. If one specifies '--log-enable debug+:_Tree_iterator' then the Windows log will be emitted but the Linux log will not. By trimming the function name then Windows and Linux will get the same filter results.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org