You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/13 20:48:28 UTC
[GitHub] [skywalking] qiuhuanhen opened a new issue #7456: the design of storage log in dataBase
qiuhuanhen opened a new issue #7456:
URL: https://github.com/apache/skywalking/issues/7456
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [√ ] Requirement
- [ ] Feature or performance improvement
___
### Question
- What do you want to know?
- (First of all, I'm sorry for I submit the issue again because it's seems I don't make myself clear before ,and now I try to make it more clear) . The method of org.apache.skywalking.oap.server.storage.plugin.jdbc.h2.dao.H2TableInstaller#createTable occur error in mysql version 5.5 or lower (I notice MysqlTableInstaller extends H2TableInstaller) ,and detalis pls look at contents What happened
___
### Bug
- Which version of SkyWalking, OS, and JRE?
8.5 version
- Which company or project?
module: storage-jdbc-hikaricp-plugin
- What happened?
Index colum too large . I notice the method of createTableIndexes in MysqlTableInstaller class, it make a distinction between Column.getLength() < 256 and extraQueryIndex. However , the id colum is also index colum default. Such as the inner talbe of skywalking creating: alarm_record , the length of id colum is 512 more than 255, so it occur error : Index colum too large because 512*3 >>767 bytes . And In mysql 5.7 or higher ,it's right because in those version , creating table sql will append ROW_FORMAT=DYNAMIC default but 5.5 or lower is COMPACT. ROW_FORMAT can only act on table but not database , but the creating table sql is writed by skywalking method in H2TableInstaller#createTable , it seems our user can not change.Our use can only set GLOBAL innodb_large_prefix = ON in mysql ,but it doesn't act on COMPACT (DYNAMIC is active)
___
### Requirement or improvement
- Please describe your requirements or improvement suggestions.
- maybe append a row code : tableCreateSQL.appendLine("ROW_FORMAT=DYNAMIC") in H2TableInstaller#createTable method , ( COMPACT default and it will change if declare DYNAMIC ) it seems not agreat impact on other code ,and there are still many users in mysql5.5 version, could you please consider it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7456: the design of storage log in dataBase
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7456:
URL: https://github.com/apache/skywalking/issues/7456#issuecomment-898799644
We don't want to make the codes too complex, as basically MySQL single node has a very limited performance to support large scale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #7456: the design of storage log in dataBase
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #7456:
URL: https://github.com/apache/skywalking/issues/7456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7456: the design of storage log in dataBase
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7456:
URL: https://github.com/apache/skywalking/issues/7456#issuecomment-898800154
We make length of id to 512 because of it could be that long in the core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org