You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "gkirchou (via GitHub)" <gi...@apache.org> on 2025/09/28 05:36:56 UTC
[PR] Add asset_helpers.py with tests and support it in asset definitions. [airflow]
gkirchou opened a new pull request, #56175:
URL: https://github.com/apache/airflow/pull/56175
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
Target to fix #53474 - https://github.com/apache/airflow/issues/53474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add asset_helpers.py with tests and support it in asset definitions. [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #56175: Add asset_helpers.py with tests and support it in asset definitions.
URL: https://github.com/apache/airflow/pull/56175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add asset_helpers.py with tests and support it in asset definitions. [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #56175:
URL: https://github.com/apache/airflow/pull/56175#discussion_r2407258572
##########
task-sdk/src/airflow/sdk/execution_time/asset_helpers.py:
##########
Review Comment:
+1, strong NO for helpers / utils
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add asset_helpers.py with tests and support it in asset definitions. [airflow]
Posted by "gkirchou (via GitHub)" <gi...@apache.org>.
gkirchou commented on code in PR #56175:
URL: https://github.com/apache/airflow/pull/56175#discussion_r2409056945
##########
task-sdk/src/airflow/sdk/execution_time/asset_helpers.py:
##########
Review Comment:
Done. (I removed task-sdk/tests/task_sdk/execution_time/test_asset_helper.py given it's tested under task-sdk/tests/task_sdk/definitions/test_asset.py.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add asset_helpers.py with tests and support it in asset definitions. [airflow]
Posted by "gkirchou (via GitHub)" <gi...@apache.org>.
gkirchou commented on PR #56175:
URL: https://github.com/apache/airflow/pull/56175#issuecomment-3342399303
During the PyCon JP 2025 sprint I examined the issue and vibe coded a quick prototype that works for NumPy’s case specifically. The fix handles this one scenario but it won’t generalize to other similar problems, so any future edge‑cases would need to be addressed manually. A cleaner, long‑term solution would be to encapsulate the problematic patterns (e.g., as a raw string or a dedicated “capsule”) rather than treating each instance explicitly. We may need to involve the core team to decide on the recommended fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add asset_helpers.py with tests and support it in asset definitions. [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #56175:
URL: https://github.com/apache/airflow/pull/56175#discussion_r2464290322
##########
task-sdk/src/airflow/sdk/definitions/asset/normalizer.py:
##########
@@ -0,0 +1,53 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+from typing import Any
+
+
+def normalize_asset_metadata(metadata_dict: dict[str, Any]) -> dict[str, Any]:
+ """
+ Normalize Asset metadata to ensure JSON serializability.
+
+ This function should be called before creating AssetMetadata objects.
+
+ Location to integrate: airflow/assets.py or wherever AssetMetadata is created
+ """
+ try:
+ import numpy as np
+ except ImportError:
+ np = None
+
+ def _normalize_value(value: Any) -> Any:
+ if isinstance(value, dict):
+ return {k: _normalize_value(v) for k, v in value.items()}
+ if isinstance(value, (list, tuple)):
+ return [_normalize_value(item) for item in value]
+ if np and isinstance(value, np.integer):
+ return int(value)
+ if np and isinstance(value, np.floating):
+ return float(value)
+ if np and isinstance(value, np.bool_):
+ return bool(value)
+ if np and isinstance(value, np.ndarray):
+ return value.tolist()
+ if np and isinstance(value, np.complexfloating):
+ return {"real": float(value.real), "imag": float(value.imag)}
Review Comment:
```suggestion
if np:
if isinstance(value, np.integer):
return int(value)
if isinstance(value, np.floating):
return float(value)
if isinstance(value, np.bool_):
return bool(value)
if isinstance(value, np.ndarray):
return value.tolist()
if isinstance(value, np.complexfloating):
return {"real": float(value.real), "imag": float(value.imag)}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add asset_helpers.py with tests and support it in asset definitions. [airflow]
Posted by "gkirchou (via GitHub)" <gi...@apache.org>.
gkirchou commented on code in PR #56175:
URL: https://github.com/apache/airflow/pull/56175#discussion_r2630735399
##########
task-sdk/src/airflow/sdk/definitions/asset/normalizer.py:
##########
@@ -0,0 +1,53 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+from typing import Any
+
+
+def normalize_asset_metadata(metadata_dict: dict[str, Any]) -> dict[str, Any]:
+ """
+ Normalize Asset metadata to ensure JSON serializability.
+
+ This function should be called before creating AssetMetadata objects.
+
+ Location to integrate: airflow/assets.py or wherever AssetMetadata is created
+ """
+ try:
+ import numpy as np
+ except ImportError:
+ np = None
+
+ def _normalize_value(value: Any) -> Any:
+ if isinstance(value, dict):
+ return {k: _normalize_value(v) for k, v in value.items()}
+ if isinstance(value, (list, tuple)):
+ return [_normalize_value(item) for item in value]
+ if np and isinstance(value, np.integer):
+ return int(value)
+ if np and isinstance(value, np.floating):
+ return float(value)
+ if np and isinstance(value, np.bool_):
+ return bool(value)
+ if np and isinstance(value, np.ndarray):
+ return value.tolist()
+ if np and isinstance(value, np.complexfloating):
+ return {"real": float(value.real), "imag": float(value.imag)}
Review Comment:
Do you mean this part?
```
try:
import numpy as np
except ImportError:
np = None
```
This was added because CI env may not have numpy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add asset_helpers.py with tests and support it in asset definitions. [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on code in PR #56175:
URL: https://github.com/apache/airflow/pull/56175#discussion_r2406710046
##########
task-sdk/src/airflow/sdk/execution_time/asset_helpers.py:
##########
Review Comment:
This is the wrong place, and wrong name for this file.
1. "helper" or "utils" ends up as a dumping ground, so I wan't to avoid that
2. While it is used at execution time, this is better co-located somewhere in `definitions/assets/` I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add asset_helpers.py with tests and support it in asset definitions. [airflow]
Posted by "gkirchou (via GitHub)" <gi...@apache.org>.
gkirchou commented on PR #56175:
URL: https://github.com/apache/airflow/pull/56175#issuecomment-3368187495
Marked this read to review to proceed the discussion - https://github.com/apache/airflow/issues/53474#issuecomment-3342414047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add asset_helpers.py with tests and support it in asset definitions. [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #56175:
URL: https://github.com/apache/airflow/pull/56175#issuecomment-3667673712
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add asset_helpers.py with tests and support it in asset definitions. [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #56175:
URL: https://github.com/apache/airflow/pull/56175#issuecomment-3832364053
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add asset_helpers.py with tests and support it in asset definitions. [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #56175:
URL: https://github.com/apache/airflow/pull/56175#discussion_r2630209793
##########
task-sdk/src/airflow/sdk/definitions/asset/normalizer.py:
##########
@@ -0,0 +1,53 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+from typing import Any
+
+
+def normalize_asset_metadata(metadata_dict: dict[str, Any]) -> dict[str, Any]:
+ """
+ Normalize Asset metadata to ensure JSON serializability.
+
+ This function should be called before creating AssetMetadata objects.
+
+ Location to integrate: airflow/assets.py or wherever AssetMetadata is created
+ """
+ try:
+ import numpy as np
+ except ImportError:
+ np = None
+
+ def _normalize_value(value: Any) -> Any:
+ if isinstance(value, dict):
+ return {k: _normalize_value(v) for k, v in value.items()}
+ if isinstance(value, (list, tuple)):
+ return [_normalize_value(item) for item in value]
+ if np and isinstance(value, np.integer):
+ return int(value)
+ if np and isinstance(value, np.floating):
+ return float(value)
+ if np and isinstance(value, np.bool_):
+ return bool(value)
+ if np and isinstance(value, np.ndarray):
+ return value.tolist()
+ if np and isinstance(value, np.complexfloating):
+ return {"real": float(value.real), "imag": float(value.imag)}
Review Comment:
Would this not miss falsy values such as False, empty array, 0, etc? Why is the `if np` check even needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add asset_helpers.py with tests and support it in asset definitions. [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #56175:
URL: https://github.com/apache/airflow/pull/56175#issuecomment-3342327478
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org