You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Gert Vanthienen (JIRA)" <ji...@apache.org> on 2009/11/24 13:57:52 UTC

[jira] Created: (CAMEL-2221) Inconsistent out message when using recipient list

Inconsistent out message when using recipient list
--------------------------------------------------

                 Key: CAMEL-2221
                 URL: https://issues.apache.org/activemq/browse/CAMEL-2221
             Project: Apache Camel
          Issue Type: Bug
          Components: camel-core
    Affects Versions: 2.0.0
            Reporter: Gert Vanthienen
            Assignee: Gert Vanthienen
             Fix For: 2.1.0


When using the Dynamic Recipient List pattern, there's an inconsistency between two ways of of defining that pattern:
- when using a @RecipientList-annotated method with a beanRef, you get the list of endpoints as the out message body
- when using the same method with a recipientList(bean(...)) call, you get the aggregated result of the invoked endpoints

I think it would be better if both options returned the same response message and I would suggested the aggregated result of the invoked endpoints is the more appropriate one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CAMEL-2221) Inconsistent out message when using recipient list

Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gert Vanthienen resolved CAMEL-2221.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.6.3

Fix has been applied to trunk in http://svn.apache.org/viewvc?view=revision&revision=883713
and backported to the 1.x branch in http://svn.apache.org/viewvc?view=revision&revision=883781

> Inconsistent out message when using recipient list
> --------------------------------------------------
>
>                 Key: CAMEL-2221
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2221
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.0.0
>            Reporter: Gert Vanthienen
>            Assignee: Gert Vanthienen
>             Fix For: 1.6.3, 2.1.0
>
>         Attachments: CAMEL-2221.diff
>
>
> When using the Dynamic Recipient List pattern, there's an inconsistency between two ways of of defining that pattern:
> - when using a @RecipientList-annotated method with a beanRef, you get the list of endpoints as the out message body
> - when using the same method with a recipientList(bean(...)) call, you get the aggregated result of the invoked endpoints
> I think it would be better if both options returned the same response message and I would suggested the aggregated result of the invoked endpoints is the more appropriate one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-2221) Inconsistent out message when using recipient list

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56061#action_56061 ] 

Claus Ibsen commented on CAMEL-2221:
------------------------------------

Gertv good catch.

Patch looks good.

I know running tests takes a long time. Have you also run camel-spring as well?

> Inconsistent out message when using recipient list
> --------------------------------------------------
>
>                 Key: CAMEL-2221
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2221
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.0.0
>            Reporter: Gert Vanthienen
>            Assignee: Gert Vanthienen
>             Fix For: 2.1.0
>
>         Attachments: CAMEL-2221.diff
>
>
> When using the Dynamic Recipient List pattern, there's an inconsistency between two ways of of defining that pattern:
> - when using a @RecipientList-annotated method with a beanRef, you get the list of endpoints as the out message body
> - when using the same method with a recipientList(bean(...)) call, you get the aggregated result of the invoked endpoints
> I think it would be better if both options returned the same response message and I would suggested the aggregated result of the invoked endpoints is the more appropriate one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-2221) Inconsistent out message when using recipient list

Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gert Vanthienen updated CAMEL-2221:
-----------------------------------

    Attachment: CAMEL-2221.diff

This patch solves the issue by always returning the aggregated result.  Can someone take a quick look before I apply it?

There's only one problem with this fix -- up to now, if a user mistakenly configured an @RecipientList-annotated method with the recipientList(bean(...)) call, the end result would still be ok because the bean(...) call would result in the list of endpoints being sent back.       This fix would break that behavior.

> Inconsistent out message when using recipient list
> --------------------------------------------------
>
>                 Key: CAMEL-2221
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2221
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.0.0
>            Reporter: Gert Vanthienen
>            Assignee: Gert Vanthienen
>             Fix For: 2.1.0
>
>         Attachments: CAMEL-2221.diff
>
>
> When using the Dynamic Recipient List pattern, there's an inconsistency between two ways of of defining that pattern:
> - when using a @RecipientList-annotated method with a beanRef, you get the list of endpoints as the out message body
> - when using the same method with a recipientList(bean(...)) call, you get the aggregated result of the invoked endpoints
> I think it would be better if both options returned the same response message and I would suggested the aggregated result of the invoked endpoints is the more appropriate one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.