You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "EnricoMi (via GitHub)" <gi...@apache.org> on 2024/02/27 07:19:37 UTC
[PR] [#134][FOLLOWUP] improvement(spark2): Use taskId and attemptNo as taskAttemptId [incubator-uniffle]
EnricoMi opened a new pull request, #1544:
URL: https://github.com/apache/incubator-uniffle/pull/1544
### What changes were proposed in this pull request?
Use map index and task attempt number as the task attempt id in Spark2.
### Why are the changes needed?
This aligns Spark2 taskAttemptId of the blockId with Spark3.
See #1529
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing integration tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#134][FOLLOWUP] improvement(spark2): Use taskId and attemptNo as taskAttemptId [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1544:
URL: https://github.com/apache/incubator-uniffle/pull/1544#issuecomment-1965939467
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1544?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 54.56%. Comparing base [(`ff555c5`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/ff555c5535f950ae5a15ffc781c948af884e67eb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`e41146c`)](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1544?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 8 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1544 +/- ##
============================================
+ Coverage 54.15% 54.56% +0.40%
- Complexity 2805 2822 +17
============================================
Files 431 416 -15
Lines 24421 22185 -2236
Branches 2081 2080 -1
============================================
- Hits 13226 12105 -1121
+ Misses 10363 9331 -1032
+ Partials 832 749 -83
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1544?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#134][FOLLOWUP] improvement(spark2): Use taskId and attemptNo as taskAttemptId [incubator-uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1544:
URL: https://github.com/apache/incubator-uniffle/pull/1544#issuecomment-1965956590
## Test Results
2 073 files - 239 2 073 suites - 239 3h 29m 25s :stopwatch: - 1h 6m 56s
822 tests ± 0 821 :white_check_mark: ± 0 1 :zzz: ±0 0 :x: ±0
9 118 runs - 561 9 104 :white_check_mark: - 561 14 :zzz: ±0 0 :x: ±0
Results for commit e41146c7. ± Comparison against base commit a73dcb96.
<details>
<summary>This pull request <b>removes</b> 2 and <b>adds</b> 2 tests. <i>Note that renamed tests count towards both.</i></summary>
```
org.apache.spark.shuffle.RssShuffleManagerTest ‑ testGetTaskAttemptIdWithSpeculation
org.apache.spark.shuffle.RssShuffleManagerTest ‑ testGetTaskAttemptIdWithoutSpeculation
```
```
org.apache.uniffle.shuffle.manager.RssShuffleManagerBaseTest ‑ testGetTaskAttemptIdWithSpeculation
org.apache.uniffle.shuffle.manager.RssShuffleManagerBaseTest ‑ testGetTaskAttemptIdWithoutSpeculation
```
</details>
[test-results]:data:application/gzip;base64,H4sIAFaS3WUC/03MTQ6DIBCG4asY1l0w4wDSyzSKkJD60yCsTO9eNEpZfg/DuzPnJ7uxZ4NctY+GbcnHeo8p9NGvSxZAIUWm/B6Piw7xXq8tGXMS/OntP8evAq73UwZewIawhktCWo6mBuiudTc1cCp0NQtUzXPXSbPOs495MEsAJI1CGlFpTsOgpVa6lY5bYXsa0EjlqGXfH4IS/DcQAQAA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#134][FOLLOWUP] improvement(spark2): Use taskId and attemptNo as taskAttemptId [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #1544:
URL: https://github.com/apache/incubator-uniffle/pull/1544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org