You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tooling.apache.org by "alitheg (via GitHub)" <gi...@apache.org> on 2026/07/17 11:00:42 UTC

[PR] #1417 - Support for subkeys (tooling-trusted-releases)

alitheg opened a new pull request, #1422:
URL: https://github.com/apache/tooling-trusted-releases/pull/1422

   @sbp I think this handles subkeys reasonably - but there's a gap we should talk about: the keys page shows expiry from the database which is only expiry of the main key. It feels like a lot to log all the subkeys in the database, so I'm not sure the best way to make sure we can show signing key expiry to people


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] #1417 - Support for subkeys (tooling-trusted-releases)

Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp commented on PR #1422:
URL: https://github.com/apache/tooling-trusted-releases/pull/1422#issuecomment-5003754227

   @alitheg Oh, and yeah, I think parsing out all the subkeys will be #1419. I know that'll create quite a few extra rows, but I expect that'll be the best solution when we do the research. It would be nice to show the composition of keys in ATR too, but that should probably be extra and during beta I'd have thought.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] #1417 - Support for subkeys (tooling-trusted-releases)

Posted by "alitheg (via GitHub)" <gi...@apache.org>.
alitheg commented on PR #1422:
URL: https://github.com/apache/tooling-trusted-releases/pull/1422#issuecomment-5002512758

   Although I guess maybe that's #1419?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] #1417 - Support for subkeys (tooling-trusted-releases)

Posted by "alitheg (via GitHub)" <gi...@apache.org>.
alitheg merged PR #1422:
URL: https://github.com/apache/tooling-trusted-releases/pull/1422


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] #1417 - Support for subkeys (tooling-trusted-releases)

Posted by "alitheg (via GitHub)" <gi...@apache.org>.
alitheg commented on PR #1422:
URL: https://github.com/apache/tooling-trusted-releases/pull/1422#issuecomment-5005297481

   @sbp I've just pushed revocation handling to the `arm` branch if you'd like a look? I also had to change the cache key for the signature check as it was only keyed on fingerprint which was stable across the revocation, and needed to change the way we handled uploading a key that already existed  - because it was a soft delete, the key was just silently restored as before when I tried to upload a revoked one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org