You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/15 13:27:52 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4220: sniffer processing profile task and report status and snapshot

wu-sheng commented on a change in pull request #4220: sniffer processing profile task and report status and snapshot
URL: https://github.com/apache/skywalking/pull/4220#discussion_r366854422
 
 

 ##########
 File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/TracingContext.java
 ##########
 @@ -497,6 +510,11 @@ private void finish() {
                 TracingContext.ListenerManager.notifyFinish(finishedSegment);
 
                 running = false;
+
+                /**
+                 * Notify current tracing context main thread has already execute finished.
 
 Review comment:
   `Notify current tracing context main thread has already execute finished.` -> `Notify after tracing finished in the main thread`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services