You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/03/17 16:23:30 UTC
[GitHub] [accumulo] dlmarion opened a new pull request #2573: Mark BulkImport v1 server side code as deprecated
dlmarion opened a new pull request #2573:
URL: https://github.com/apache/accumulo/pull/2573
Marked BulkImport v1 server side components as deprecated for easy identification and removal in 3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #2573: Mark BulkImport v1 server side code as deprecated
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #2573:
URL: https://github.com/apache/accumulo/pull/2573#discussion_r829251768
##########
File path: core/src/main/thrift-gen-java/org/apache/accumulo/core/manager/thrift/FateOperation.java
##########
@@ -34,6 +34,7 @@
TABLE_OFFLINE(5),
TABLE_MERGE(6),
TABLE_DELETE_RANGE(7),
+ @Deprecated
Review comment:
This is thrift generated file and will be clobbered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on a change in pull request #2573: Mark BulkImport v1 server side code as deprecated
Posted by GitBox <gi...@apache.org>.
dlmarion commented on a change in pull request #2573:
URL: https://github.com/apache/accumulo/pull/2573#discussion_r829387206
##########
File path: core/src/main/thrift-gen-java/org/apache/accumulo/core/manager/thrift/FateOperation.java
##########
@@ -34,6 +34,7 @@
TABLE_OFFLINE(5),
TABLE_MERGE(6),
TABLE_DELETE_RANGE(7),
+ @Deprecated
Review comment:
Fixed in 96bd003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on pull request #2573: Mark BulkImport v1 server side code as deprecated
Posted by GitBox <gi...@apache.org>.
dlmarion commented on pull request #2573:
URL: https://github.com/apache/accumulo/pull/2573#issuecomment-1071053854
Not sure, but when we do, it's easily identifiable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on a change in pull request #2573: Mark BulkImport v1 server side code as deprecated
Posted by GitBox <gi...@apache.org>.
dlmarion commented on a change in pull request #2573:
URL: https://github.com/apache/accumulo/pull/2573#discussion_r829257771
##########
File path: core/src/main/thrift-gen-java/org/apache/accumulo/core/manager/thrift/FateOperation.java
##########
@@ -34,6 +34,7 @@
TABLE_OFFLINE(5),
TABLE_MERGE(6),
TABLE_DELETE_RANGE(7),
+ @Deprecated
Review comment:
Yep, I missed that. Thanks.
##########
File path: core/src/main/thrift-gen-java/org/apache/accumulo/core/manager/thrift/FateOperation.java
##########
@@ -34,6 +34,7 @@
TABLE_OFFLINE(5),
TABLE_MERGE(6),
TABLE_DELETE_RANGE(7),
+ @Deprecated
Review comment:
Fixed in 96bd003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #2573: Mark BulkImport v1 server side code as deprecated
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #2573:
URL: https://github.com/apache/accumulo/pull/2573#discussion_r829251768
##########
File path: core/src/main/thrift-gen-java/org/apache/accumulo/core/manager/thrift/FateOperation.java
##########
@@ -34,6 +34,7 @@
TABLE_OFFLINE(5),
TABLE_MERGE(6),
TABLE_DELETE_RANGE(7),
+ @Deprecated
Review comment:
This is thrift generated file and will be clobbered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2573: Mark BulkImport v1 server side code as deprecated
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2573:
URL: https://github.com/apache/accumulo/pull/2573#issuecomment-1071048567
Do we want to remove it in 3.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on pull request #2573: Mark BulkImport v1 server side code as deprecated
Posted by GitBox <gi...@apache.org>.
dlmarion commented on pull request #2573:
URL: https://github.com/apache/accumulo/pull/2573#issuecomment-1071053854
Not sure, but when we do, it's easily identifiable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2573: Mark BulkImport v1 server side code as deprecated
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2573:
URL: https://github.com/apache/accumulo/pull/2573#issuecomment-1071048567
Do we want to remove it in 3.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on a change in pull request #2573: Mark BulkImport v1 server side code as deprecated
Posted by GitBox <gi...@apache.org>.
dlmarion commented on a change in pull request #2573:
URL: https://github.com/apache/accumulo/pull/2573#discussion_r829257771
##########
File path: core/src/main/thrift-gen-java/org/apache/accumulo/core/manager/thrift/FateOperation.java
##########
@@ -34,6 +34,7 @@
TABLE_OFFLINE(5),
TABLE_MERGE(6),
TABLE_DELETE_RANGE(7),
+ @Deprecated
Review comment:
Yep, I missed that. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org