You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/22 21:32:14 UTC
[GitHub] [incubator-superset] pkdotson opened a new pull request #10399: refresh control panel buttons
pkdotson opened a new pull request #10399:
URL: https://github.com/apache/incubator-superset/pull/10399
### SUMMARY
update react select forms to look more like cartel design within viz control panel.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
after
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] closed pull request #10399: feat: refresh control panel select forms to look more like SIP-34
Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #10399:
URL: https://github.com/apache/incubator-superset/pull/10399
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10399: feat: refresh control panel select forms to look more like SIP-34
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #10399:
URL: https://github.com/apache/incubator-superset/pull/10399#discussion_r460641631
##########
File path: superset-frontend/src/explore/main.less
##########
@@ -61,6 +61,11 @@
background-color: transparent !important;
}
+.fa-caret-up,
+.fa-caret-down {
+ color: #666666;
Review comment:
can you find this color in the variables less file and use the variable here?
##########
File path: superset-frontend/src/components/Select/styles.tsx
##########
@@ -142,6 +142,8 @@ export const DEFAULT_STYLES: PartialStylesConfig = {
return [
provider,
css`
+ border-width: ${isMulti ? '1px' : '0px'};
+ background-color: ${isMulti ? 'white' : '#F0F0F0'};
Review comment:
these colors should probably be found within `supersetColors`, otherwise they should be added there
##########
File path: superset-frontend/src/explore/main.less
##########
@@ -80,9 +85,14 @@
margin-left: 15px;
padding-bottom: 0px;
}
-
+ .panel-title {
+ color: #b2b2b2;
+ }
.control-label {
margin-bottom: 0px;
+ font-size: 14px;
+ font-weight: 500;
+ color: #b2b2b2;
Review comment:
can you find this color in the variables less file and use the variable here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on pull request #10399: feat: refresh control panel select forms to look more like SIP-34
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #10399:
URL: https://github.com/apache/incubator-superset/pull/10399#issuecomment-703188915
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org