[jira] [Commented] (LUCENE-7071) Can we reeduce excessive byte[] copying in OfflineSorter?

["Robert Muir (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-7071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15182317#comment-15182317 ] 

Robert Muir commented on LUCENE-7071:
-------------------------------------

I think its ok since its package-private. We should avoid doing this kind of copying in a comparison function! 

> Can we reeduce excessive byte[] copying in OfflineSorter?
> ---------------------------------------------------------
>
>                 Key: LUCENE-7071
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7071
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: master, 6.1
>
>         Attachments: LUCENE-7071.patch
>
>
> OfflineSorter, which dimensional points uses heavily in the > 1D case,
> works by reading one partition, a set of N unsorted values, from disk
> and sorting it in memory and writing it out again.
> The sort invokes a provided {{Comparator}} on two {{BytesRef}} values,
> each of which is fully copied from the {{ByteBlockPool}}, when it could
> often reference a slice from the pool instead.
> Another byte[] copy happens when iterating through the sorted values.
> This is an optimization ... I'm targeting 6.1.0 not 6.0.0!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org