[GitHub] [cordova-android] dkotrada commented on issue #928: Update check_reqs.js

[GitBox <gi...@apache.org>]

dkotrada commented on issue #928: Update check_reqs.js
URL: https://github.com/apache/cordova-android/pull/928#issuecomment-598790369
 
 
   > > Java JDK 1.8 or greater
   > 
   > Is actually wrong. Android requires 1.8, not anything lower, not anything greater. So if the readme states this, it probably should be changed. But I would favour the README change in a separate PR.
   
   I am not native speaker so you may not understood me what I mean with this PR. 
   
   Witch my code you can use any java version. Who has today lover than 1.8? Next LTS version is 11. So my code works well with both `1.8 and greather` current code is wrong because it checks only for 1.8. But cordova works with greather versions. 
   
   But you can do what ever you want. Have a nice day.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org