You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Adam B <ad...@mesosphere.io> on 2015/07/03 01:40:35 UTC
Review Request 36152: Updated CHANGELOG for 0.23.0.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36152/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ben Mahler, Jie Yu, Joris Van Remoortere, Marco Massenzio, Michael Park, Timothy Chen, and Vinod Kone.
Repository: mesos-incubating
Description
-------
Copied in contents of JIRA Release Notes, categorized.
Diffs
-----
CHANGELOG 252f068
Diff: https://reviews.apache.org/r/36152/diff/
Testing
-------
Thanks,
Adam B
Re: Review Request 36152: Updated CHANGELOG for 0.23.0.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36152/#review90325
-----------------------------------------------------------
Ship it!
Thanks Adam!
- Jie Yu
On July 2, 2015, 11:47 p.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36152/
> -----------------------------------------------------------
>
> (Updated July 2, 2015, 11:47 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ben Mahler, Jie Yu, Joris Van Remoortere, Marco Massenzio, Michael Park, Timothy Chen, and Vinod Kone.
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> Copied in contents of JIRA Release Notes, categorized.
>
>
> Diffs
> -----
>
> CHANGELOG 252f068
>
> Diff: https://reviews.apache.org/r/36152/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Adam B
>
>
Re: Review Request 36152: Updated CHANGELOG for 0.23.0.
Posted by Adam B <ad...@mesosphere.io>.
> On July 3, 2015, 12:18 p.m., Vinod Kone wrote:
> >
Thanks for the review. I've addressed your comments in the following commit:
commit 7f1d97c93a4492d4b9469301237ce96083f5408d
Author: Adam B <ad...@mesosphere.io>
Date: Mon Jul 6 16:11:13 2015 -0700
Updated 0.23.0 CHANGELOG per Vinod's feedback.
Review: https://reviews.apache.org/r/36152
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36152/#review90368
-----------------------------------------------------------
On July 2, 2015, 4:47 p.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36152/
> -----------------------------------------------------------
>
> (Updated July 2, 2015, 4:47 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ben Mahler, Jie Yu, Joris Van Remoortere, Marco Massenzio, Michael Park, Timothy Chen, and Vinod Kone.
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> Copied in contents of JIRA Release Notes, categorized.
>
>
> Diffs
> -----
>
> CHANGELOG 252f068
>
> Diff: https://reviews.apache.org/r/36152/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Adam B
>
>
Re: Review Request 36152: Updated CHANGELOG for 0.23.0.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36152/#review90368
-----------------------------------------------------------
Ship it!
CHANGELOG (line 9)
<https://reviews.apache.org/r/36152/#comment143400>
I don't think this is a feature?
CHANGELOG (line 38)
<https://reviews.apache.org/r/36152/#comment143401>
I would not call this out.
CHANGELOG (line 39)
<https://reviews.apache.org/r/36152/#comment143402>
ditto.
CHANGELOG (lines 41 - 42)
<https://reviews.apache.org/r/36152/#comment143404>
I don't think we need these either because you are already calling out MESOS-2955
CHANGELOG (line 44)
<https://reviews.apache.org/r/36152/#comment143403>
ditto.
- Vinod Kone
On July 2, 2015, 11:47 p.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36152/
> -----------------------------------------------------------
>
> (Updated July 2, 2015, 11:47 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ben Mahler, Jie Yu, Joris Van Remoortere, Marco Massenzio, Michael Park, Timothy Chen, and Vinod Kone.
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> Copied in contents of JIRA Release Notes, categorized.
>
>
> Diffs
> -----
>
> CHANGELOG 252f068
>
> Diff: https://reviews.apache.org/r/36152/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Adam B
>
>
Re: Review Request 36152: Updated CHANGELOG for 0.23.0.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36152/#review90319
-----------------------------------------------------------
Ship it!
Ship It!
- Bernd Mathiske
On July 2, 2015, 4:47 p.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36152/
> -----------------------------------------------------------
>
> (Updated July 2, 2015, 4:47 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ben Mahler, Jie Yu, Joris Van Remoortere, Marco Massenzio, Michael Park, Timothy Chen, and Vinod Kone.
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> Copied in contents of JIRA Release Notes, categorized.
>
>
> Diffs
> -----
>
> CHANGELOG 252f068
>
> Diff: https://reviews.apache.org/r/36152/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Adam B
>
>
Re: Review Request 36152: Updated CHANGELOG for 0.23.0.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36152/#review90329
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On July 2, 2015, 11:47 p.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36152/
> -----------------------------------------------------------
>
> (Updated July 2, 2015, 11:47 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ben Mahler, Jie Yu, Joris Van Remoortere, Marco Massenzio, Michael Park, Timothy Chen, and Vinod Kone.
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> Copied in contents of JIRA Release Notes, categorized.
>
>
> Diffs
> -----
>
> CHANGELOG 252f068
>
> Diff: https://reviews.apache.org/r/36152/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Adam B
>
>
Re: Review Request 36152: Updated CHANGELOG for 0.23.0.
Posted by Adam B <ad...@mesosphere.io>.
> On July 2, 2015, 5:04 p.m., Marco Massenzio wrote:
> > CHANGELOG, line 11
> > <https://reviews.apache.org/r/36152/diff/2/?file=998642#file998642line11>
> >
> > how about `beta` instead of `experimental`?
> > or should we functionally distinguish between `alpha` (which is what "experimental" sounds to me) v. `beta` features?
> >
> > I personally would prefer the use of "alpha" / "beta" as more standard in industry parlance than "experimental" (which makes it sound more like a science project :) )
Back in 0.14.0, we called "Resource Reservations" and the Jenkins plugin "experimental", and then in 0.19.0 we referred to the external containerizer as "alpha", so we're already mixing terminology. I went with "experimental" because that's what we've used in conversation, and that's what the revocable resources line already said. If we're going to distinguish between alpha vs. beta, it'd be good to have a clear distinction. I usually think of alpha as "for internal testing" and beta "for public testing", but that doesn't apply to open-source.
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36152/#review90298
-----------------------------------------------------------
On July 2, 2015, 4:47 p.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36152/
> -----------------------------------------------------------
>
> (Updated July 2, 2015, 4:47 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ben Mahler, Jie Yu, Joris Van Remoortere, Marco Massenzio, Michael Park, Timothy Chen, and Vinod Kone.
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> Copied in contents of JIRA Release Notes, categorized.
>
>
> Diffs
> -----
>
> CHANGELOG 252f068
>
> Diff: https://reviews.apache.org/r/36152/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Adam B
>
>
Re: Review Request 36152: Updated CHANGELOG for 0.23.0.
Posted by Marco Massenzio <ma...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36152/#review90298
-----------------------------------------------------------
Ship it!
Adam, super-thanks for pulling this together - this was far more legwork than you let on (Jira can only do so much :)
CHANGELOG (line 11)
<https://reviews.apache.org/r/36152/#comment143309>
how about `beta` instead of `experimental`?
or should we functionally distinguish between `alpha` (which is what "experimental" sounds to me) v. `beta` features?
I personally would prefer the use of "alpha" / "beta" as more standard in industry parlance than "experimental" (which makes it sound more like a science project :) )
- Marco Massenzio
On July 2, 2015, 11:47 p.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36152/
> -----------------------------------------------------------
>
> (Updated July 2, 2015, 11:47 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ben Mahler, Jie Yu, Joris Van Remoortere, Marco Massenzio, Michael Park, Timothy Chen, and Vinod Kone.
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> Copied in contents of JIRA Release Notes, categorized.
>
>
> Diffs
> -----
>
> CHANGELOG 252f068
>
> Diff: https://reviews.apache.org/r/36152/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Adam B
>
>
Re: Review Request 36152: Updated CHANGELOG for 0.23.0.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36152/
-----------------------------------------------------------
(Updated July 2, 2015, 4:47 p.m.)
Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ben Mahler, Jie Yu, Joris Van Remoortere, Marco Massenzio, Michael Park, Timothy Chen, and Vinod Kone.
Changes
-------
Added better description for per-container network isolation.
Repository: mesos-incubating
Description
-------
Copied in contents of JIRA Release Notes, categorized.
Diffs (updated)
-----
CHANGELOG 252f068
Diff: https://reviews.apache.org/r/36152/diff/
Testing
-------
Thanks,
Adam B