You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (Commented) (JIRA)" <ji...@apache.org> on 2011/11/01 15:15:32 UTC
[jira] [Commented] (LUCENE-3277) CharsRef has confusing
methods/needs tests/bugs
[ https://issues.apache.org/jira/browse/LUCENE-3277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141190#comment-13141190 ]
Robert Muir commented on LUCENE-3277:
-------------------------------------
LUCENE-3548 addresses the confusing append() issue.
> CharsRef has confusing methods/needs tests/bugs
> -----------------------------------------------
>
> Key: LUCENE-3277
> URL: https://issues.apache.org/jira/browse/LUCENE-3277
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Robert Muir
>
> While looking at LUCENE-3233, i noticed a few things:
> * lots of internal methods (e.g. copy) use grow(). I don't think they should do this. CharsRef should work like BytesRef, i don't think it needs to be a stringbuffer. i think its ok to expose a public grow() method like we did for bytesref though.
> * the append() method is totally confusing, and doesnt make sense compared to BytesRef, copy() might also have issues.
> * a lot of these methods are unused, we should at least add tests for them, or remove ones we don't need.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org