You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "thisiswanghy (GitHub)" <gi...@apache.org> on 2019/12/04 12:10:12 UTC
[GitHub] [dubbo] thisiswanghy opened issue #5429: TagRouter的stream操作导致ConsistentHashLoadBalance每次都需要重新进行hash环的映射。
### Environment
* Dubbo version: 2.7.4.1
ConsistentHashLoadBalance 用到了 System.identityHashCode(invokers); 来判断 hash 值，从而判断是否有服务端的上下线操作。
而TagRouter的org.apache.dubbo.rpc.cluster.router.tag.TagRouter#filterUsingStaticTag方法中的 stream 操作会修改 invokers 的值，所以 ConsistentHashLoadBalance 受到了影响。
导致即使在服务端没有上下线操作的时候，一致性hash负载均衡算法每次都需要重新进行hash环的映射。
[ Full content available at: https://github.com/apache/dubbo/issues/5429 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] chickenlj closed issue #5429: TagRouter的stream操作导致ConsistentHashLoadBalance每次都需要重新进行hash环的映射。
Posted by "chickenlj (GitHub)" <gi...@apache.org>.
[ issue closed by chickenlj ]
[ Full content available at: https://github.com/apache/dubbo/issues/5429 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] CodingSinger commented on issue #5429: TagRouter的stream操作导致ConsistentHashLoadBalance每次都需要重新进行hash环的映射。
Posted by "CodingSinger (GitHub)" <gi...@apache.org>.
i think should replace `java.lang.System#identityHashCode` with `hashCode` .
@chickenlj
what's your opinion？
[ Full content available at: https://github.com/apache/dubbo/issues/5429 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] thisiswanghy commented on issue #5429: TagRouter的stream操作导致ConsistentHashLoadBalance每次都需要重新进行hash环的映射。
Posted by "thisiswanghy (GitHub)" <gi...@apache.org>.
https://github.com/apache/dubbo/issues/5424
[ Full content available at: https://github.com/apache/dubbo/issues/5429 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] thisiswanghy commented on issue #5429: TagRouter的stream操作导致ConsistentHashLoadBalance每次都需要重新进行hash环的映射。
Posted by "thisiswanghy (GitHub)" <gi...@apache.org>.
https://mp.weixin.qq.com/s/ctBM0WO-uWNlTWHI-TPniw
bug的详细描述
[ Full content available at: https://github.com/apache/dubbo/issues/5429 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] kimmking commented on issue #5429: TagRouter的stream操作导致ConsistentHashLoadBalance每次都需要重新进行hash环的映射。
Posted by "kimmking (GitHub)" <gi...@apache.org>.
@CodingSinger I commit some comments for your bugfix.
[ Full content available at: https://github.com/apache/dubbo/issues/5429 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org