You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Paolo Patierno <pp...@live.com> on 2017/07/17 13:30:35 UTC
[DISCUSS] KIP-176: Remove deprecated new-consumer option in
ConsoleConsumer tool
Hi dev,
I'd like to discuss the possibility to remove the new-consumer option in the ConsoleConsumer tool.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-176%3A+Remove+deprecated+new-consumer+option+in+ConsoleConsumer+tool
I have already opened a JIRA with related PR for marking it as deprecated in the next release (https://issues.apache.org/jira/browse/KAFKA-5599) as suggested by Ismael Juma.
The next step should be to vote/accept the KIP and removing the option from the tool in the subsequent release cycle.
Thanks,
Paolo Patierno
Senior Software Engineer (IoT) @ Red Hat
Microsoft MVP on Microsoft Azure IoT
Microsoft Azure Advisor
Twitter : @ppatierno<http://twitter.com/ppatierno>
Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno>
Blog : DevExperience<http://paolopatierno.wordpress.com/>
Re: [DISCUSS] KIP-176: Remove deprecated new-consumer option from
tools
Posted by Paolo Patierno <pp...@live.com>.
Hi devs,
I didn't see any new comments around this KIP. Maybe we could start the vote for that ?
Before that, could it be worth to check (and eventually merge) the following PRs about deprecation for having that in the 1.0.0 release ? (then removing in the next release cycle).
https://github.com/apache/kafka/pull/3537
https://github.com/apache/kafka/pull/3555
Thanks
Paolo Patierno
Senior Software Engineer (IoT) @ Red Hat
Microsoft MVP on Windows Embedded & IoT
Microsoft Azure Advisor
Twitter : @ppatierno<http://twitter.com/ppatierno>
Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno>
Blog : DevExperience<http://paolopatierno.wordpress.com/>
________________________________
From: Paolo Patierno <pp...@live.com>
Sent: Thursday, July 20, 2017 12:47 PM
To: dev@kafka.apache.org
Subject: Re: [DISCUSS] KIP-176: Remove deprecated new-consumer option from tools
Hi all,
I have updated the KIP-176 <https://cwiki.apache.org/confluence/display/KAFKA/KIP-176%3A+Remove+deprecated+new-consumer+option+for+tools> in order to consider to remove the --new-consumer option not only for ConsoleConsumer but even for other tools which use it : ConsumerPerformance and ConsumerGroupCommand.
I'm also working on a PR for a new-consumer option deprecation as first step for ConsumerPerformance and ConsumerGroupCommand (as already done, pushing a PR<https://github.com/apache/kafka/pull/3537>, for ConsoleConsumer).
Thanks,
Paolo
Paolo Patierno
Senior Software Engineer (IoT) @ Red Hat
Microsoft MVP on Windows Embedded & IoT
Microsoft Azure Advisor
Twitter : @ppatierno<http://twitter.com/ppatierno>
Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno>
Blog : DevExperience<http://paolopatierno.wordpress.com/>
________________________________
From: ismaelj@gmail.com <is...@gmail.com> on behalf of Ismael Juma <is...@juma.me.uk>
Sent: Tuesday, July 18, 2017 1:09 PM
To: dev@kafka.apache.org
Subject: Re: [DISCUSS] KIP-176: Remove deprecated new-consumer option in ConsoleConsumer tool
On Mon, Jul 17, 2017 at 10:11 AM, Matthias J. Sax <ma...@confluent.io>
wrote:
> I thinks, for backward compatibility, this check should be there. The
> only change should be, that if `--bootstrap-servers` is used, one can
> omit `--new-consumer` (and if used, as warning is printed).
>
You can omit "--new-consumer" since 0.10.2. Paolo's PR will add the warning
so that we can eventually remove the switch altogether. To be honest, we
could just remove it at the same time as we remove the old consumer.
Ismael
Re: [DISCUSS] KIP-176: Remove deprecated new-consumer option from
tools
Posted by Paolo Patierno <pp...@live.com>.
Hi all,
I have updated the KIP-176 <https://cwiki.apache.org/confluence/display/KAFKA/KIP-176%3A+Remove+deprecated+new-consumer+option+for+tools> in order to consider to remove the --new-consumer option not only for ConsoleConsumer but even for other tools which use it : ConsumerPerformance and ConsumerGroupCommand.
I'm also working on a PR for a new-consumer option deprecation as first step for ConsumerPerformance and ConsumerGroupCommand (as already done, pushing a PR<https://github.com/apache/kafka/pull/3537>, for ConsoleConsumer).
Thanks,
Paolo
Paolo Patierno
Senior Software Engineer (IoT) @ Red Hat
Microsoft MVP on Windows Embedded & IoT
Microsoft Azure Advisor
Twitter : @ppatierno<http://twitter.com/ppatierno>
Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno>
Blog : DevExperience<http://paolopatierno.wordpress.com/>
________________________________
From: ismaelj@gmail.com <is...@gmail.com> on behalf of Ismael Juma <is...@juma.me.uk>
Sent: Tuesday, July 18, 2017 1:09 PM
To: dev@kafka.apache.org
Subject: Re: [DISCUSS] KIP-176: Remove deprecated new-consumer option in ConsoleConsumer tool
On Mon, Jul 17, 2017 at 10:11 AM, Matthias J. Sax <ma...@confluent.io>
wrote:
> I thinks, for backward compatibility, this check should be there. The
> only change should be, that if `--bootstrap-servers` is used, one can
> omit `--new-consumer` (and if used, as warning is printed).
>
You can omit "--new-consumer" since 0.10.2. Paolo's PR will add the warning
so that we can eventually remove the switch altogether. To be honest, we
could just remove it at the same time as we remove the old consumer.
Ismael
Re: [DISCUSS] KIP-176: Remove deprecated new-consumer option in
ConsoleConsumer tool
Posted by Ismael Juma <is...@juma.me.uk>.
On Mon, Jul 17, 2017 at 10:11 AM, Matthias J. Sax <ma...@confluent.io>
wrote:
> I thinks, for backward compatibility, this check should be there. The
> only change should be, that if `--bootstrap-servers` is used, one can
> omit `--new-consumer` (and if used, as warning is printed).
>
You can omit "--new-consumer" since 0.10.2. Paolo's PR will add the warning
so that we can eventually remove the switch altogether. To be honest, we
could just remove it at the same time as we remove the old consumer.
Ismael
Re: [DISCUSS] KIP-176: Remove deprecated new-consumer option in
ConsoleConsumer tool
Posted by Paolo Patierno <pp...@live.com>.
Hi Matthias,
the KIP-176 is for removing so not having --new-consumer anymore.
What you are speaking about, I guess, is the deprecated step that isn't addressed by the KIP.
I already have a PR for deprecation https://github.com/apache/kafka/pull/3537 which is addressed in the way you are talking about :-)
I hope to have a review on that PR soon for the merge ;)
Thanks.
Paolo Patierno
Senior Software Engineer (IoT) @ Red Hat
Microsoft MVP on Windows Embedded & IoT
Microsoft Azure Advisor
Twitter : @ppatierno<http://twitter.com/ppatierno>
Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno>
Blog : DevExperience<http://paolopatierno.wordpress.com/>
________________________________
From: Matthias J. Sax <ma...@confluent.io>
Sent: Monday, July 17, 2017 5:11 PM
To: dev@kafka.apache.org
Subject: Re: [DISCUSS] KIP-176: Remove deprecated new-consumer option in ConsoleConsumer tool
Hi,
I agree that the option can be removed/deprecated.
However, I don't understand this:
> there will be no check that the new-consumer option is an invalid argument with the old consumer.
I thinks, for backward compatibility, this check should be there. The
only change should be, that if `--bootstrap-servers` is used, one can
omit `--new-consumer` (and if used, as warning is printed).
-Matthias
On 7/17/17 6:30 AM, Paolo Patierno wrote:
> Hi dev,
>
> I'd like to discuss the possibility to remove the new-consumer option in the ConsoleConsumer tool.
>
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-176%3A+Remove+deprecated+new-consumer+option+in+ConsoleConsumer+tool
>
>
> I have already opened a JIRA with related PR for marking it as deprecated in the next release (https://issues.apache.org/jira/browse/KAFKA-5599) as suggested by Ismael Juma.
>
> The next step should be to vote/accept the KIP and removing the option from the tool in the subsequent release cycle.
>
>
> Thanks,
>
>
> Paolo Patierno
> Senior Software Engineer (IoT) @ Red Hat
> Microsoft MVP on Microsoft Azure IoT
> Microsoft Azure Advisor
>
> Twitter : @ppatierno<http://twitter.com/ppatierno>
> Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno>
> Blog : DevExperience<http://paolopatierno.wordpress.com/>
>
Re: [DISCUSS] KIP-176: Remove deprecated new-consumer option in
ConsoleConsumer tool
Posted by "Matthias J. Sax" <ma...@confluent.io>.
Hi,
I agree that the option can be removed/deprecated.
However, I don't understand this:
> there will be no check that the new-consumer option is an invalid argument with the old consumer.
I thinks, for backward compatibility, this check should be there. The
only change should be, that if `--bootstrap-servers` is used, one can
omit `--new-consumer` (and if used, as warning is printed).
-Matthias
On 7/17/17 6:30 AM, Paolo Patierno wrote:
> Hi dev,
>
> I'd like to discuss the possibility to remove the new-consumer option in the ConsoleConsumer tool.
>
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-176%3A+Remove+deprecated+new-consumer+option+in+ConsoleConsumer+tool
>
>
> I have already opened a JIRA with related PR for marking it as deprecated in the next release (https://issues.apache.org/jira/browse/KAFKA-5599) as suggested by Ismael Juma.
>
> The next step should be to vote/accept the KIP and removing the option from the tool in the subsequent release cycle.
>
>
> Thanks,
>
>
> Paolo Patierno
> Senior Software Engineer (IoT) @ Red Hat
> Microsoft MVP on Microsoft Azure IoT
> Microsoft Azure Advisor
>
> Twitter : @ppatierno<http://twitter.com/ppatierno>
> Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno>
> Blog : DevExperience<http://paolopatierno.wordpress.com/>
>