You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org> on 2011/08/11 16:16:42 UTC
[jira] Created: (ARCHETYPE-378) Remove the parameter goalPrefix
(and corresponding code) from the archetype:add-archetype-metadata mojo
Remove the parameter goalPrefix (and corresponding code) from the archetype:add-archetype-metadata mojo
-------------------------------------------------------------------------------------------------------
Key: ARCHETYPE-378
URL: https://jira.codehaus.org/browse/ARCHETYPE-378
Project: Maven Archetype
Issue Type: Task
Components: Plugin
Affects Versions: 2.0
Reporter: Benjamin Bentmann
Priority: Trivial
As questioned in [Archtypes and plugin prefix|http://www.mail-archive.com/dev@maven.apache.org/msg89617.html], it appears the parameter {{goalName}} of the {{add-archetype-metadata}} mojo exists merely due to copy&paste but has no real use in the context of archetypes. As such the parameter and its backing code should be removed to reduce confusion for end users and to keep the group-level metadata free from bogus plugin prefix mappings for archetypes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (ARCHETYPE-378) Remove the parameter goalPrefix (and
corresponding code) from the archetype:add-archetype-metadata mojo
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/ARCHETYPE-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy closed ARCHETYPE-378.
-----------------------------------
Resolution: Fixed
Assignee: Herve Boutemy (was: Olivier Lamy)
done in [r1158911|http://svn.apache.org/viewvc?rev=1158911&view=rev]
> Remove the parameter goalPrefix (and corresponding code) from the archetype:add-archetype-metadata mojo
> -------------------------------------------------------------------------------------------------------
>
> Key: ARCHETYPE-378
> URL: https://jira.codehaus.org/browse/ARCHETYPE-378
> Project: Maven Archetype
> Issue Type: Task
> Components: Plugin
> Affects Versions: 2.0
> Reporter: Benjamin Bentmann
> Assignee: Herve Boutemy
> Priority: Trivial
> Fix For: 2.1
>
>
> As questioned in [Archtypes and plugin prefix|http://www.mail-archive.com/dev@maven.apache.org/msg89617.html], it appears the parameter {{goalName}} of the {{add-archetype-metadata}} mojo exists merely due to copy&paste but has no real use in the context of archetypes. As such the parameter and its backing code should be removed to reduce confusion for end users and to keep the group-level metadata free from bogus plugin prefix mappings for archetypes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ARCHETYPE-378) Remove the parameter goalPrefix
(and corresponding code) from the archetype:add-archetype-metadata mojo
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/ARCHETYPE-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=276270#comment-276270 ]
Herve Boutemy commented on ARCHETYPE-378:
-----------------------------------------
after some discussion and research, here are my results:
- plugin mapping does not have any meaning for an archetype
- LATEST update isn't used since for a long time, archetypes were packages as jar packaging, which does not update LATEST without any problem: maven-arhetype packaging is here only for integration-tests and update-local-catalog
definitely, removing this mojo won't remove any functionality, only unneeded copy/paste
I'm going to remove the mojo
> Remove the parameter goalPrefix (and corresponding code) from the archetype:add-archetype-metadata mojo
> -------------------------------------------------------------------------------------------------------
>
> Key: ARCHETYPE-378
> URL: https://jira.codehaus.org/browse/ARCHETYPE-378
> Project: Maven Archetype
> Issue Type: Task
> Components: Plugin
> Affects Versions: 2.0
> Reporter: Benjamin Bentmann
> Assignee: Olivier Lamy
> Priority: Trivial
> Fix For: 2.1
>
>
> As questioned in [Archtypes and plugin prefix|http://www.mail-archive.com/dev@maven.apache.org/msg89617.html], it appears the parameter {{goalName}} of the {{add-archetype-metadata}} mojo exists merely due to copy&paste but has no real use in the context of archetypes. As such the parameter and its backing code should be removed to reduce confusion for end users and to keep the group-level metadata free from bogus plugin prefix mappings for archetypes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ARCHETYPE-378) Remove the parameter goalPrefix
(and corresponding code) from the archetype:add-archetype-metadata mojo
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/ARCHETYPE-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy updated ARCHETYPE-378:
-----------------------------------
Fix Version/s: 2.1
Assignee: Olivier Lamy
> Remove the parameter goalPrefix (and corresponding code) from the archetype:add-archetype-metadata mojo
> -------------------------------------------------------------------------------------------------------
>
> Key: ARCHETYPE-378
> URL: https://jira.codehaus.org/browse/ARCHETYPE-378
> Project: Maven Archetype
> Issue Type: Task
> Components: Plugin
> Affects Versions: 2.0
> Reporter: Benjamin Bentmann
> Assignee: Olivier Lamy
> Priority: Trivial
> Fix For: 2.1
>
>
> As questioned in [Archtypes and plugin prefix|http://www.mail-archive.com/dev@maven.apache.org/msg89617.html], it appears the parameter {{goalName}} of the {{add-archetype-metadata}} mojo exists merely due to copy&paste but has no real use in the context of archetypes. As such the parameter and its backing code should be removed to reduce confusion for end users and to keep the group-level metadata free from bogus plugin prefix mappings for archetypes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ARCHETYPE-378) Remove the parameter goalPrefix
(and corresponding code) from the archetype:add-archetype-metadata mojo
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/ARCHETYPE-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=275993#comment-275993 ]
Herve Boutemy commented on ARCHETYPE-378:
-----------------------------------------
the more I read the code, the more I ask myself: why does this add-archetype-metadata mojo ever exist?
the whole thing, not only goalName, seems a copy, but this does not have any meaning for an archetype: an archetype is simply not a plugin, plugin mapping does not have any meaning, and LATEST isn't used
IIUC, the whole class should be removed, and its lifecycle binding in maven-archetype packaging
WDYT?
> Remove the parameter goalPrefix (and corresponding code) from the archetype:add-archetype-metadata mojo
> -------------------------------------------------------------------------------------------------------
>
> Key: ARCHETYPE-378
> URL: https://jira.codehaus.org/browse/ARCHETYPE-378
> Project: Maven Archetype
> Issue Type: Task
> Components: Plugin
> Affects Versions: 2.0
> Reporter: Benjamin Bentmann
> Assignee: Olivier Lamy
> Priority: Trivial
> Fix For: 2.1
>
>
> As questioned in [Archtypes and plugin prefix|http://www.mail-archive.com/dev@maven.apache.org/msg89617.html], it appears the parameter {{goalName}} of the {{add-archetype-metadata}} mojo exists merely due to copy&paste but has no real use in the context of archetypes. As such the parameter and its backing code should be removed to reduce confusion for end users and to keep the group-level metadata free from bogus plugin prefix mappings for archetypes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira