You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/10 14:31:17 UTC

[GitHub] [cloudstack] DaanHoogland opened a new pull request #4457: Add quick test attribute

DaanHoogland opened a new pull request #4457:
URL: https://github.com/apache/cloudstack/pull/4457


   ## Description
   <!--- Describe your changes in detail -->
   
   Adding 'quick-test' attribute to list of smoketests and adding 'vpc', 'templates', 'deploy-vm', 'roles', 'service-offerings', 'storage', 'routers', 'networks', 'usage', 'accounts' tags
   
   quick-test label aims to provide quick feedback of recent changes to the developer, instead of waiting for the whole smoketest to execute(24h+). This execution lasts about 1.5h at Trillian environments.
   
   The categories aim to offer more efficient way to slice through tests in both smoke and component tests. Let's say as a developer you've made a change in the accounts. You can simply trigger marvin tests with tag=accounts pointing all the tests for example:
   
   ```
   nosetests --with-marvin --marvin-config=[config] --hypervisor=xenserver -a tags=accounts /tests/integration/*/*.*
   ```
   
   cwiki.apache.org/confluence/display/CLOUDSTACK/Test+Categories+and+Quick-test+in+Marvin
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4457: Add quick test attribute

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4457:
URL: https://github.com/apache/cloudstack/pull/4457#issuecomment-863956702


   @rhtyd this will need rework, changing to draft. we might want to run this for low risk changes, but a am also thinking about a more flexible test set system.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4457: Add quick test attribute

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4457:
URL: https://github.com/apache/cloudstack/pull/4457#issuecomment-724795147


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland closed pull request #4457: Add quick test attribute

Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #4457:
URL: https://github.com/apache/cloudstack/pull/4457


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland closed pull request #4457: Add quick test attribute

Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #4457:
URL: https://github.com/apache/cloudstack/pull/4457


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4457: Add quick test attribute

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4457:
URL: https://github.com/apache/cloudstack/pull/4457#issuecomment-724794481


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #4457: Add quick test attribute

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4457:
URL: https://github.com/apache/cloudstack/pull/4457#issuecomment-1040600606


   Hi @DaanHoogland are you considering this PR for 4.17? In that case, can you please solve the conflicts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4457: Add quick test attribute

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4457:
URL: https://github.com/apache/cloudstack/pull/4457#issuecomment-1041200593


   one in 5 lines in here is a conflict. maybe revisit the idea later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4457: Add quick test attribute

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4457:
URL: https://github.com/apache/cloudstack/pull/4457#issuecomment-724756549


   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4457: Add quick test attribute

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4457:
URL: https://github.com/apache/cloudstack/pull/4457#issuecomment-724755947


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4457: Add quick test attribute

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4457:
URL: https://github.com/apache/cloudstack/pull/4457#issuecomment-726060691


   @PaulAngus @borisstoyanov do you want this in? cc @rhtyd 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4457: Add quick test attribute

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4457:
URL: https://github.com/apache/cloudstack/pull/4457#issuecomment-724778326


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2351


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #4457: Add quick test attribute

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4457:
URL: https://github.com/apache/cloudstack/pull/4457#issuecomment-1040600606


   Hi @DaanHoogland are you considering this PR for 4.17? In that case, can you please solve the conflicts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4457: Add quick test attribute

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4457:
URL: https://github.com/apache/cloudstack/pull/4457#issuecomment-725090674


   <b>Trillian test result (tid-3140)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 36202 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4457-t3140-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
   Smoke tests completed. 83 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 3621.32 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.11 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.09 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 103.70 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesSupportedVersion>:setup | `Error` | 0.00 | test_kubernetes_supported_versions.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org