You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "anishshri-db (via GitHub)" <gi...@apache.org> on 2024/07/03 22:08:40 UTC
[PR] [SPARK-48799] Refactor versioning for operator metadata read/write and callers [spark]
anishshri-db opened a new pull request, #47203:
URL: https://github.com/apache/spark/pull/47203
### What changes were proposed in this pull request?
Refactor versioning for operator metadata read/write and callers
### Why are the changes needed?
Provides clear separation around version management for operator metadata related updates. Also needed for subsequent changes in this area
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing unit tests
```
===== POSSIBLE THREAD LEAK IN SUITE o.a.s.sql.execution.streaming.state.OperatorStateMetadataSuite, threads: block-manager-ask-thread-pool-92 (daemon=true), Idle Worker Monitor for python3 (daemon=true), rpc-boss-3-1 (daemon=true), block-manager-ask-thread-pool-8 (daemon=true), block-manager-ask-thread-pool-59 (daemon=true), ForkJoinPool.commonPool-worker-3 (daemon=true), block-manager-ask-thread-pool-29 (daemon=true), block-manager-ask-thread-pool-90 (daemon=true), block-manager-ask-thread-pool-48 (daemo...
[info] Run completed in 30 seconds, 35 milliseconds.
[info] Total number of tests run: 10
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 10, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 44 s, completed Jul 3, 2024, 3:00:58 PM
```
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48799][SS] Refactor versioning for operator metadata read/write and callers [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on PR #47203:
URL: https://github.com/apache/spark/pull/47203#issuecomment-2208067418
Thanks! Merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48799][SS] Refactor versioning for operator metadata read/write and callers [spark]
Posted by "ericm-db (via GitHub)" <gi...@apache.org>.
ericm-db commented on PR #47203:
URL: https://github.com/apache/spark/pull/47203#issuecomment-2207394741
LGTM, just adding versioning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48799][SS] Refactor versioning for operator metadata read/write and callers [spark]
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on PR #47203:
URL: https://github.com/apache/spark/pull/47203#issuecomment-2207392043
cc - @HeartSaVioR - PTAL, thx !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48799][SS] Refactor versioning for operator metadata read/write and callers [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR closed pull request #47203: [SPARK-48799][SS] Refactor versioning for operator metadata read/write and callers
URL: https://github.com/apache/spark/pull/47203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org