You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2019/03/10 17:36:13 UTC

[GitHub] [incubator-plc4x] chrisdutz commented on issue #47: Extend field with type information

chrisdutz commented on issue #47: Extend field with type information
URL: https://github.com/apache/incubator-plc4x/pull/47#issuecomment-471326798
 
 
   If it works, … merge it 😉 (my opinion)
   
   Chris
   
   Von: timbo2k <no...@github.com>
   Antworten an: apache/incubator-plc4x <re...@reply.github.com>
   Datum: Sonntag, 10. März 2019 um 16:29
   An: apache/incubator-plc4x <in...@noreply.github.com>
   Cc: Christofer Dutz <ch...@c-ware.de>, Review requested <re...@noreply.github.com>
   Betreff: Re: [apache/incubator-plc4x] Extend field with type information (#47)
   
   
   Hey ... i made a few changes so that Scraper isn't dependent on S7 and added a scraper yml and test for Modbus that has been working fine ... so i think that could be mergt ... what do the others think?!
   
   —
   You are receiving this because your review was requested.
   Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-plc4x/pull/47#issuecomment-471316217>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAnvYU4REKkNb4vDrbRGaCJOQmiYCcEYks5vVSTogaJpZM4bixxc>.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services