You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/10 01:20:48 UTC

[GitHub] [flink] faaronzheng opened a new pull request #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism

faaronzheng opened a new pull request #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism
URL: https://github.com/apache/flink/pull/11356
 
 
   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   This pull request  add search function and fix slow loading for high parallelism scenarios in metrics
   
   
   ## Brief change log
   
   job-overview-drawer-chart.component.html
   job-overview-drawer-chart.component.ts
   
   add showList and optionList to search and load metric by pagination.
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] faaronzheng commented on a change in pull request #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism

Posted by GitBox <gi...@apache.org>.
faaronzheng commented on a change in pull request #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism
URL: https://github.com/apache/flink/pull/11356#discussion_r396422659
 
 

 ##########
 File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/chart/job-overview-drawer-chart.component.ts
 ##########
 @@ -64,15 +71,35 @@ export class JobOverviewDrawerChartComponent implements OnInit, OnDestroy {
   closeMetric(metric: string) {
     this.listOfSelectedMetric = this.listOfSelectedMetric.filter(item => item !== metric);
     this.jobService.metricsCacheMap.set(this.cacheMetricKey, this.listOfSelectedMetric);
+    this.showList = [metric,...this.showList];
     this.updateUnselectedMetricList();
   }
 
   updateUnselectedMetricList() {
     this.listOfUnselectedMetric = this.listOfMetricName.filter(item => this.listOfSelectedMetric.indexOf(item) === -1);
+    this.showList = this.showList.filter(item => this.listOfSelectedMetric.indexOf(item) === -1);
+    this.optionList = this.listOfUnselectedMetric;
   }
 
   constructor(private metricsService: MetricsService, private jobService: JobService, private cdr: ChangeDetectorRef) {}
 
+  nzOnSearch(val: string){
+    this.showListPageNum=0;
 
 Review comment:
   Hi @vthinkxie 
   Thanks for your review, I am not sure what kind of format should be used. Is reformate code in IDEA ok? I haven't install node_modules when create this PR, it will be nice if you can say it more clearly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] vthinkxie commented on a change in pull request #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism

Posted by GitBox <gi...@apache.org>.
vthinkxie commented on a change in pull request #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism
URL: https://github.com/apache/flink/pull/11356#discussion_r393526775
 
 

 ##########
 File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/chart/job-overview-drawer-chart.component.ts
 ##########
 @@ -64,15 +71,35 @@ export class JobOverviewDrawerChartComponent implements OnInit, OnDestroy {
   closeMetric(metric: string) {
     this.listOfSelectedMetric = this.listOfSelectedMetric.filter(item => item !== metric);
     this.jobService.metricsCacheMap.set(this.cacheMetricKey, this.listOfSelectedMetric);
+    this.showList = [metric,...this.showList];
     this.updateUnselectedMetricList();
   }
 
   updateUnselectedMetricList() {
     this.listOfUnselectedMetric = this.listOfMetricName.filter(item => this.listOfSelectedMetric.indexOf(item) === -1);
+    this.showList = this.showList.filter(item => this.listOfSelectedMetric.indexOf(item) === -1);
+    this.optionList = this.listOfUnselectedMetric;
   }
 
   constructor(private metricsService: MetricsService, private jobService: JobService, private cdr: ChangeDetectorRef) {}
 
+  nzOnSearch(val: string){
+    this.showListPageNum=0;
 
 Review comment:
   ```suggestion
       this.showListPageNum = 0;
   ```
   Hi @faaronzheng 
   thanks a lot for your PR.
   it seems that the code is not formatted, there is a pre-commit hooks in the package.json it seems that it does not work in your PR, have you install the node_modules when create the pull request?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism
URL: https://github.com/apache/flink/pull/11356#issuecomment-596854707
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1 (Tue Mar 10 01:23:57 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15000).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism
URL: https://github.com/apache/flink/pull/11356#issuecomment-596856858
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/152561426",
       "triggerID" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6097",
       "triggerID" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/152561426) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6097) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] faaronzheng commented on a change in pull request #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism

Posted by GitBox <gi...@apache.org>.
faaronzheng commented on a change in pull request #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism
URL: https://github.com/apache/flink/pull/11356#discussion_r399729007
 
 

 ##########
 File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/chart/job-overview-drawer-chart.component.ts
 ##########
 @@ -64,15 +71,35 @@ export class JobOverviewDrawerChartComponent implements OnInit, OnDestroy {
   closeMetric(metric: string) {
     this.listOfSelectedMetric = this.listOfSelectedMetric.filter(item => item !== metric);
     this.jobService.metricsCacheMap.set(this.cacheMetricKey, this.listOfSelectedMetric);
+    this.showList = [metric,...this.showList];
     this.updateUnselectedMetricList();
   }
 
   updateUnselectedMetricList() {
     this.listOfUnselectedMetric = this.listOfMetricName.filter(item => this.listOfSelectedMetric.indexOf(item) === -1);
+    this.showList = this.showList.filter(item => this.listOfSelectedMetric.indexOf(item) === -1);
+    this.optionList = this.listOfUnselectedMetric;
   }
 
   constructor(private metricsService: MetricsService, private jobService: JobService, private cdr: ChangeDetectorRef) {}
 
+  nzOnSearch(val: string){
+    this.showListPageNum=0;
 
 Review comment:
   Hi @vthinkxie  
   thanks, the code is already formatted by pre-commit hooks. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] vthinkxie commented on a change in pull request #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism

Posted by GitBox <gi...@apache.org>.
vthinkxie commented on a change in pull request #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism
URL: https://github.com/apache/flink/pull/11356#discussion_r396577250
 
 

 ##########
 File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/chart/job-overview-drawer-chart.component.ts
 ##########
 @@ -64,15 +71,35 @@ export class JobOverviewDrawerChartComponent implements OnInit, OnDestroy {
   closeMetric(metric: string) {
     this.listOfSelectedMetric = this.listOfSelectedMetric.filter(item => item !== metric);
     this.jobService.metricsCacheMap.set(this.cacheMetricKey, this.listOfSelectedMetric);
+    this.showList = [metric,...this.showList];
     this.updateUnselectedMetricList();
   }
 
   updateUnselectedMetricList() {
     this.listOfUnselectedMetric = this.listOfMetricName.filter(item => this.listOfSelectedMetric.indexOf(item) === -1);
+    this.showList = this.showList.filter(item => this.listOfSelectedMetric.indexOf(item) === -1);
+    this.optionList = this.listOfUnselectedMetric;
   }
 
   constructor(private metricsService: MetricsService, private jobService: JobService, private cdr: ChangeDetectorRef) {}
 
+  nzOnSearch(val: string){
+    this.showListPageNum=0;
 
 Review comment:
   there will be a pre commit hook after you install the node_modules, it will format the code automaticlly

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism
URL: https://github.com/apache/flink/pull/11356#issuecomment-596856858
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/152561426",
       "triggerID" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6097",
       "triggerID" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/152561426) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6097) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism
URL: https://github.com/apache/flink/pull/11356#issuecomment-596856858
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/152561426",
       "triggerID" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6097",
       "triggerID" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "545fd6194256f5daefac1e0a6fc2d7fb349c7aa6",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156250357",
       "triggerID" : "545fd6194256f5daefac1e0a6fc2d7fb349c7aa6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "545fd6194256f5daefac1e0a6fc2d7fb349c7aa6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6787",
       "triggerID" : "545fd6194256f5daefac1e0a6fc2d7fb349c7aa6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/152561426) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6097) 
   * 545fd6194256f5daefac1e0a6fc2d7fb349c7aa6 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/156250357) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6787) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism
URL: https://github.com/apache/flink/pull/11356#issuecomment-596856858
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/152561426",
       "triggerID" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6097",
       "triggerID" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "545fd6194256f5daefac1e0a6fc2d7fb349c7aa6",
       "status" : "CANCELED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156250357",
       "triggerID" : "545fd6194256f5daefac1e0a6fc2d7fb349c7aa6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "545fd6194256f5daefac1e0a6fc2d7fb349c7aa6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6787",
       "triggerID" : "545fd6194256f5daefac1e0a6fc2d7fb349c7aa6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce87022bb654cbee5e5ac8f31c6e72dc03b89c9f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6789",
       "triggerID" : "ce87022bb654cbee5e5ac8f31c6e72dc03b89c9f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce87022bb654cbee5e5ac8f31c6e72dc03b89c9f",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156278518",
       "triggerID" : "ce87022bb654cbee5e5ac8f31c6e72dc03b89c9f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 545fd6194256f5daefac1e0a6fc2d7fb349c7aa6 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/156250357) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6787) 
   * ce87022bb654cbee5e5ac8f31c6e72dc03b89c9f Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/156278518) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6789) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] faaronzheng commented on a change in pull request #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism

Posted by GitBox <gi...@apache.org>.
faaronzheng commented on a change in pull request #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism
URL: https://github.com/apache/flink/pull/11356#discussion_r399729007
 
 

 ##########
 File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/chart/job-overview-drawer-chart.component.ts
 ##########
 @@ -64,15 +71,35 @@ export class JobOverviewDrawerChartComponent implements OnInit, OnDestroy {
   closeMetric(metric: string) {
     this.listOfSelectedMetric = this.listOfSelectedMetric.filter(item => item !== metric);
     this.jobService.metricsCacheMap.set(this.cacheMetricKey, this.listOfSelectedMetric);
+    this.showList = [metric,...this.showList];
     this.updateUnselectedMetricList();
   }
 
   updateUnselectedMetricList() {
     this.listOfUnselectedMetric = this.listOfMetricName.filter(item => this.listOfSelectedMetric.indexOf(item) === -1);
+    this.showList = this.showList.filter(item => this.listOfSelectedMetric.indexOf(item) === -1);
+    this.optionList = this.listOfUnselectedMetric;
   }
 
   constructor(private metricsService: MetricsService, private jobService: JobService, private cdr: ChangeDetectorRef) {}
 
+  nzOnSearch(val: string){
+    this.showListPageNum=0;
 
 Review comment:
   thanks, the code is already formatted by pre-commit hooks. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism
URL: https://github.com/apache/flink/pull/11356#issuecomment-596856858
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/152561426",
       "triggerID" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6097",
       "triggerID" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "545fd6194256f5daefac1e0a6fc2d7fb349c7aa6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "545fd6194256f5daefac1e0a6fc2d7fb349c7aa6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/152561426) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6097) 
   * 545fd6194256f5daefac1e0a6fc2d7fb349c7aa6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism
URL: https://github.com/apache/flink/pull/11356#issuecomment-596856858
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/152561426",
       "triggerID" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6097",
       "triggerID" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/152561426) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6097) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism
URL: https://github.com/apache/flink/pull/11356#issuecomment-596856858
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/152561426",
       "triggerID" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6097",
       "triggerID" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "545fd6194256f5daefac1e0a6fc2d7fb349c7aa6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156250357",
       "triggerID" : "545fd6194256f5daefac1e0a6fc2d7fb349c7aa6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "545fd6194256f5daefac1e0a6fc2d7fb349c7aa6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6787",
       "triggerID" : "545fd6194256f5daefac1e0a6fc2d7fb349c7aa6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce87022bb654cbee5e5ac8f31c6e72dc03b89c9f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6789",
       "triggerID" : "ce87022bb654cbee5e5ac8f31c6e72dc03b89c9f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce87022bb654cbee5e5ac8f31c6e72dc03b89c9f",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156278518",
       "triggerID" : "ce87022bb654cbee5e5ac8f31c6e72dc03b89c9f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ce87022bb654cbee5e5ac8f31c6e72dc03b89c9f Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/156278518) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6789) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism
URL: https://github.com/apache/flink/pull/11356#issuecomment-596856858
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/152561426",
       "triggerID" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6097",
       "triggerID" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "545fd6194256f5daefac1e0a6fc2d7fb349c7aa6",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156250357",
       "triggerID" : "545fd6194256f5daefac1e0a6fc2d7fb349c7aa6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "545fd6194256f5daefac1e0a6fc2d7fb349c7aa6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6787",
       "triggerID" : "545fd6194256f5daefac1e0a6fc2d7fb349c7aa6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce87022bb654cbee5e5ac8f31c6e72dc03b89c9f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ce87022bb654cbee5e5ac8f31c6e72dc03b89c9f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 545fd6194256f5daefac1e0a6fc2d7fb349c7aa6 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/156250357) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6787) 
   * ce87022bb654cbee5e5ac8f31c6e72dc03b89c9f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism
URL: https://github.com/apache/flink/pull/11356#issuecomment-596856858
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11356: [FLINK-15000] [web] WebUI metrics is very slow in large parallelism
URL: https://github.com/apache/flink/pull/11356#issuecomment-596856858
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/152561426",
       "triggerID" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6097",
       "triggerID" : "8917c0690a4d84ac1ca15a4ca4f68af921f8bdc1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "545fd6194256f5daefac1e0a6fc2d7fb349c7aa6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156250357",
       "triggerID" : "545fd6194256f5daefac1e0a6fc2d7fb349c7aa6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "545fd6194256f5daefac1e0a6fc2d7fb349c7aa6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6787",
       "triggerID" : "545fd6194256f5daefac1e0a6fc2d7fb349c7aa6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce87022bb654cbee5e5ac8f31c6e72dc03b89c9f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6789",
       "triggerID" : "ce87022bb654cbee5e5ac8f31c6e72dc03b89c9f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce87022bb654cbee5e5ac8f31c6e72dc03b89c9f",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/156278518",
       "triggerID" : "ce87022bb654cbee5e5ac8f31c6e72dc03b89c9f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ce87022bb654cbee5e5ac8f31c6e72dc03b89c9f Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/156278518) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6789) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services