You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by ah...@apache.org on 2013/11/25 07:59:23 UTC
[13/18] git commit: [flex-asjs] [refs/heads/develop] - cleanup
gjslint errors
cleanup gjslint errors
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/949b24d9
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/949b24d9
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/949b24d9
Branch: refs/heads/develop
Commit: 949b24d917f996d4c5fcaa5e54de16a900c84e03
Parents: d3cec26
Author: Alex Harui <ah...@apache.org>
Authored: Fri Nov 22 13:56:32 2013 -0800
Committer: Alex Harui <ah...@apache.org>
Committed: Fri Nov 22 13:56:32 2013 -0800
----------------------------------------------------------------------
frameworks/js/FlexJS/src/createjs_externals.js | 3 ++-
frameworks/js/FlexJS/src/jquery_externals.js | 3 ++-
.../FlexJS/src/org/apache/flex/html/staticControls/Image.js | 2 +-
.../FlexJS/src/org/apache/flex/html/staticControls/List.js | 3 ++-
.../beads/DataItemRendererFactoryForArrayData.js | 8 ++++----
5 files changed, 11 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/949b24d9/frameworks/js/FlexJS/src/createjs_externals.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/createjs_externals.js b/frameworks/js/FlexJS/src/createjs_externals.js
index 0c6b72b..7daaff1 100644
--- a/frameworks/js/FlexJS/src/createjs_externals.js
+++ b/frameworks/js/FlexJS/src/createjs_externals.js
@@ -12,8 +12,9 @@
* limitations under the License.
*/
+
/**
* This file is used to establish external APIs so the closure-compiler
* can resolve references and won't minify names
*/
-function createjs() {};
+function createjs() {}
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/949b24d9/frameworks/js/FlexJS/src/jquery_externals.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/jquery_externals.js b/frameworks/js/FlexJS/src/jquery_externals.js
index 2c7d0ce..a14392f 100644
--- a/frameworks/js/FlexJS/src/jquery_externals.js
+++ b/frameworks/js/FlexJS/src/jquery_externals.js
@@ -12,8 +12,9 @@
* limitations under the License.
*/
+
/**
* This file is used to establish external APIs so the closure-compiler
* can resolve references and won't minify names
*/
-function $() {};
+function $() {}
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/949b24d9/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Image.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Image.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Image.js
index 5fde007..4446917 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Image.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Image.js
@@ -61,7 +61,7 @@ org.apache.flex.html.staticControls.Image.prototype.createElement =
this.addBead(new
org.apache.flex.html.staticControls.beads.ImageView());
-
+
return this.element;
};
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/949b24d9/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/List.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/List.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/List.js
index bfc60d3..7858482 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/List.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/List.js
@@ -69,7 +69,8 @@ org.apache.flex.html.staticControls.List.prototype.addedToParent =
var c = this.getBeadByType(org.apache.flex.core.IDataProviderItemRendererMapper);
if (org.apache.flex.core.ValuesManager.valuesImpl.getValue && !c) {
- c = org.apache.flex.core.ValuesManager.valuesImpl.getValue(this,'iDataProviderItemRendererMapper');
+ c = org.apache.flex.core.ValuesManager.valuesImpl.getValue(this,
+ 'iDataProviderItemRendererMapper');
if (c) {
var bead = new c;
this.addBead(bead);
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/949b24d9/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/DataItemRendererFactoryForArrayData.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/DataItemRendererFactoryForArrayData.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/DataItemRendererFactoryForArrayData.js
index b5c1531..6b28db6 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/DataItemRendererFactoryForArrayData.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/DataItemRendererFactoryForArrayData.js
@@ -16,8 +16,8 @@ goog.provide('org.apache.flex.html.staticControls.beads.DataItemRendererFactoryF
goog.require('org.apache.flex.core.IDataProviderItemRendererMapper');
goog.require('org.apache.flex.events.EventDispatcher');
-goog.require('org.apache.flex.html.staticControls.beads.models.ArraySelectionModel');
goog.require('org.apache.flex.html.staticControls.beads.ListView');
+goog.require('org.apache.flex.html.staticControls.beads.models.ArraySelectionModel');
goog.require('org.apache.flex.html.staticControls.supportClasses.ButtonBarButtonItemRenderer');
@@ -44,7 +44,7 @@ org.apache.flex.html.staticControls.beads.DataItemRendererFactoryForArrayData.
/**
- * @expose
+ * @private
* @type {Object}
*/
org.apache.flex.html.staticControls.beads.DataItemRendererFactoryForArrayData.
@@ -70,7 +70,7 @@ org.apache.flex.html.staticControls.beads.DataItemRendererFactoryForArrayData.
goog.bind(this.dataProviderChangedHandler, this));
if (org.apache.flex.core.ValuesManager.valuesImpl.getValue && !this.itemRendererFactory_) {
- var c = org.apache.flex.core.ValuesManager.valuesImpl.getValue(this.strand_,'iItemRendererClassFactory');
+ var c = org.apache.flex.core.ValuesManager.valuesImpl.getValue(this.strand_, 'iItemRendererClassFactory');
this.itemRendererFactory_ = new c;
this.strand_.addBead(this.itemRendererFactory_);
}
@@ -86,7 +86,7 @@ org.apache.flex.html.staticControls.beads.DataItemRendererFactoryForArrayData.
org.apache.flex.html.staticControls.beads.DataItemRendererFactoryForArrayData.
prototype.get_itemRendererClass = function() {
if (org.apache.flex.core.ValuesManager.valuesImpl.getValue && !this.itemRendererClass_) {
- var c = org.apache.flex.core.ValuesManager.valuesImpl.getValue(this.strand_,'iItemRenderer');
+ var c = org.apache.flex.core.ValuesManager.valuesImpl.getValue(this.strand_, 'iItemRenderer');
if (c) {
this.itemRendererClass_ = c;
}