You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "lexburner (GitHub)" <gi...@apache.org> on 2018/12/26 10:36:43 UTC

[GitHub] [incubator-dubbo] lexburner opened pull request #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

## What is the purpose of the change

Import old TagRouter into 2.6.x

This feature is merged at 2.7.x

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=h1) Report
> Merging [#3065](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/ac49a7d34ac6cfe5ff089d9823bdad1171409c00?src=pr&el=desc) will **decrease** coverage by `0.09%`.
> The diff coverage is `94%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##              2.6.x    #3065     +/-   ##
===========================================
- Coverage     47.36%   47.26%   -0.1%     
- Complexity     4289     4300     +11     
===========================================
  Files           552      554      +2     
  Lines         24381    24405     +24     
  Branches       4314     4320      +6     
===========================================
- Hits          11547    11536     -11     
- Misses        11047    11077     +30     
- Partials       1787     1792      +5
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/com/alibaba/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL0NvbnN0YW50cy5qYXZh) | `88.88% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [.../dubbo/registry/integration/RegistryDirectory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVnaXN0cnkvaW50ZWdyYXRpb24vUmVnaXN0cnlEaXJlY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/rpc/cluster/router/script/ScriptRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9zY3JpcHQvU2NyaXB0Um91dGVyLmphdmE=) | `61.53% <100%> (+4.72%)` | `4 <0> (-1)` | :arrow_down: |
| [.../rpc/cluster/router/condition/ConditionRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9jb25kaXRpb24vQ29uZGl0aW9uUm91dGVyLmphdmE=) | `71.64% <100%> (ø)` | `33 <0> (ø)` | :arrow_down: |
| [...dubbo/rpc/cluster/directory/AbstractDirectory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL2RpcmVjdG9yeS9BYnN0cmFjdERpcmVjdG9yeS5qYXZh) | `56.81% <100%> (+1%)` | `10 <0> (ø)` | :arrow_down: |
| [...dubbo/rpc/cluster/router/MockInvokersSelector.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9Nb2NrSW52b2tlcnNTZWxlY3Rvci5qYXZh) | `94.11% <100%> (ø)` | `15 <1> (-2)` | :arrow_down: |
| [...ibaba/dubbo/rpc/cluster/router/AbstractRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9BYnN0cmFjdFJvdXRlci5qYXZh) | `75% <75%> (ø)` | `5 <5> (?)` | |
| [...libaba/dubbo/rpc/cluster/router/tag/TagRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci90YWcvVGFnUm91dGVyLmphdmE=) | `95.23% <95.23%> (ø)` | `10 <10> (?)` | |
| [...om/alibaba/dubbo/config/AbstractServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RTZXJ2aWNlQ29uZmlnLmphdmE=) | `95.58% <95.58%> (-2.88%)` | `42 <42> (+1)` | |
| [...aba/dubbo/common/compiler/support/JdkCompiler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2NvbXBpbGVyL3N1cHBvcnQvSmRrQ29tcGlsZXIuamF2YQ==) | `0% <0%> (-61.82%)` | `0% <0%> (-2%)` | |
| ... and [19 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=footer). Last update [ac49a7d...e59711d](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on issue #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

Posted by "cvictory (GitHub)" <gi...@apache.org>.
I have tested the invocation between dubbo 2.6 and dubbo 2.7.  It worked well.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

Posted by "cvictory (GitHub)" <gi...@apache.org>.
Can we remove this constructor?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

Posted by "cvictory (GitHub)" <gi...@apache.org>.
这两个名称，和2.7 master分支的保持一致。

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=h1) Report
> Merging [#3065](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/ac49a7d34ac6cfe5ff089d9823bdad1171409c00?src=pr&el=desc) will **decrease** coverage by `0.1%`.
> The diff coverage is `71.42%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##              2.6.x    #3065      +/-   ##
============================================
- Coverage     47.36%   47.25%   -0.11%     
- Complexity     4289     4301      +12     
============================================
  Files           552      555       +3     
  Lines         24381    24412      +31     
  Branches       4314     4319       +5     
============================================
- Hits          11547    11537      -10     
- Misses        11047    11085      +38     
- Partials       1787     1790       +3
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/com/alibaba/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL0NvbnN0YW50cy5qYXZh) | `88.88% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [.../dubbo/registry/integration/RegistryDirectory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVnaXN0cnkvaW50ZWdyYXRpb24vUmVnaXN0cnlEaXJlY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/rpc/cluster/router/script/ScriptRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9zY3JpcHQvU2NyaXB0Um91dGVyLmphdmE=) | `61.53% <100%> (+4.72%)` | `4 <0> (-1)` | :arrow_down: |
| [.../rpc/cluster/router/condition/ConditionRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9jb25kaXRpb24vQ29uZGl0aW9uUm91dGVyLmphdmE=) | `71.64% <100%> (ø)` | `33 <0> (ø)` | :arrow_down: |
| [...dubbo/rpc/cluster/router/tag/TagRouterFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci90YWcvVGFnUm91dGVyRmFjdG9yeS5qYXZh) | `100% <100%> (ø)` | `2 <2> (?)` | |
| [...dubbo/rpc/cluster/router/MockInvokersSelector.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9Nb2NrSW52b2tlcnNTZWxlY3Rvci5qYXZh) | `94.11% <100%> (ø)` | `15 <1> (-2)` | :arrow_down: |
| [...om/alibaba/dubbo/config/AbstractServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RTZXJ2aWNlQ29uZmlnLmphdmE=) | `95.58% <33.33%> (-2.88%)` | `42 <1> (+1)` | |
| [...libaba/dubbo/rpc/cluster/router/tag/TagRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci90YWcvVGFnUm91dGVyLmphdmE=) | `70.37% <70.37%> (ø)` | `9 <9> (?)` | |
| [...ibaba/dubbo/rpc/cluster/router/AbstractRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9BYnN0cmFjdFJvdXRlci5qYXZh) | `75% <75%> (ø)` | `4 <4> (?)` | |
| [...aba/dubbo/common/compiler/support/JdkCompiler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2NvbXBpbGVyL3N1cHBvcnQvSmRrQ29tcGlsZXIuamF2YQ==) | `0% <0%> (-61.82%)` | `0% <0%> (-2%)` | |
| ... and [18 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=footer). Last update [ac49a7d...96d1999](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

Posted by "cvictory (GitHub)" <gi...@apache.org>.
catch是否需要？

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] chickenlj commented on issue #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

Posted by "chickenlj (GitHub)" <gi...@apache.org>.
I think we should support the `dubbo.force.tag` semantic in 2.7.0.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

Posted by "cvictory (GitHub)" <gi...@apache.org>.
增加个日志看下，为什么不通过。

Add some logs to confirm the problem

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=h1) Report
> Merging [#3065](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/ac49a7d34ac6cfe5ff089d9823bdad1171409c00?src=pr&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##              2.6.x   #3065      +/-   ##
===========================================
- Coverage     47.36%   47.2%   -0.16%     
+ Complexity     4289    4285       -4     
===========================================
  Files           552     552              
  Lines         24381   24381              
  Branches       4314    4314              
===========================================
- Hits          11547   11509      -38     
- Misses        11047   11082      +35     
- Partials       1787    1790       +3
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...aba/dubbo/common/compiler/support/JdkCompiler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2NvbXBpbGVyL3N1cHBvcnQvSmRrQ29tcGlsZXIuamF2YQ==) | `0% <0%> (-61.82%)` | `0% <0%> (-2%)` | |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2V4dGVuc2lvbi9TcHJpbmdFeHRlbnNpb25GYWN0b3J5LmphdmE=) | `78.37% <0%> (-5.41%)` | `9% <0%> (ø)` | |
| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `54.21% <0%> (-3.62%)` | `13% <0%> (-2%)` | |
| [...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvUnBjQ29udGV4dC5qYXZh) | `29.86% <0%> (-3.48%)` | `24% <0%> (-5%)` | |
| [...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==) | `57.81% <0%> (-1.57%)` | `8% <0%> (-1%)` | |
| [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `53.12% <0%> (-1.57%)` | `3% <0%> (ø)` | |
| [...java/com/alibaba/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvUmVmZXJlbmNlQ29uZmlnLmphdmE=) | `51.28% <0%> (-1.1%)` | `39% <0%> (-2%)` | |
| [...baba/dubbo/common/compiler/support/ClassUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2NvbXBpbGVyL3N1cHBvcnQvQ2xhc3NVdGlscy5qYXZh) | `0% <0%> (-0.52%)` | `0% <0%> (-1%)` | |
| [...libaba/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9EdWJib1Byb3RvY29sLmphdmE=) | `60.52% <0%> (-0.44%)` | `32% <0%> (-1%)` | |
| [...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DYWxsYmFja1NlcnZpY2VDb2RlYy5qYXZh) | `79.41% <0%> (+0.73%)` | `29% <0%> (ø)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=footer). Last update [ac49a7d...3c0126d](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] lexburner commented on pull request #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

Posted by "lexburner (GitHub)" <gi...@apache.org>.
ok

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=h1) Report
> Merging [#3065](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/ac49a7d34ac6cfe5ff089d9823bdad1171409c00?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `89.74%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##              2.6.x    #3065      +/-   ##
============================================
- Coverage     47.36%   47.22%   -0.15%     
- Complexity     4289     4300      +11     
============================================
  Files           552      555       +3     
  Lines         24381    24409      +28     
  Branches       4314     4319       +5     
============================================
- Hits          11547    11526      -21     
- Misses        11047    11090      +43     
- Partials       1787     1793       +6
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/com/alibaba/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL0NvbnN0YW50cy5qYXZh) | `88.88% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [.../dubbo/registry/integration/RegistryDirectory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVnaXN0cnkvaW50ZWdyYXRpb24vUmVnaXN0cnlEaXJlY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/rpc/cluster/router/script/ScriptRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9zY3JpcHQvU2NyaXB0Um91dGVyLmphdmE=) | `61.53% <100%> (+4.72%)` | `4 <0> (-1)` | :arrow_down: |
| [.../rpc/cluster/router/condition/ConditionRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9jb25kaXRpb24vQ29uZGl0aW9uUm91dGVyLmphdmE=) | `71.64% <100%> (ø)` | `33 <0> (ø)` | :arrow_down: |
| [...dubbo/rpc/cluster/directory/AbstractDirectory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL2RpcmVjdG9yeS9BYnN0cmFjdERpcmVjdG9yeS5qYXZh) | `56.81% <100%> (+1%)` | `10 <0> (ø)` | :arrow_down: |
| [...libaba/dubbo/rpc/cluster/router/tag/TagRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci90YWcvVGFnUm91dGVyLmphdmE=) | `100% <100%> (ø)` | `11 <11> (?)` | |
| [...dubbo/rpc/cluster/router/tag/TagRouterFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci90YWcvVGFnUm91dGVyRmFjdG9yeS5qYXZh) | `100% <100%> (ø)` | `2 <2> (?)` | |
| [...dubbo/rpc/cluster/router/MockInvokersSelector.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9Nb2NrSW52b2tlcnNTZWxlY3Rvci5qYXZh) | `94.11% <100%> (ø)` | `15 <1> (-2)` | :arrow_down: |
| [...om/alibaba/dubbo/config/AbstractServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RTZXJ2aWNlQ29uZmlnLmphdmE=) | `95.58% <33.33%> (-2.88%)` | `42 <1> (+1)` | |
| [...ibaba/dubbo/rpc/cluster/router/AbstractRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9BYnN0cmFjdFJvdXRlci5qYXZh) | `75% <75%> (ø)` | `5 <5> (?)` | |
| ... and [19 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=footer). Last update [ac49a7d...60ad33b](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] lexburner commented on pull request #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

Posted by "lexburner (GitHub)" <gi...@apache.org>.
ok

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=h1) Report
> Merging [#3065](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/ac49a7d34ac6cfe5ff089d9823bdad1171409c00?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `89.74%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##              2.6.x    #3065      +/-   ##
============================================
- Coverage     47.36%   47.22%   -0.15%     
- Complexity     4289     4300      +11     
============================================
  Files           552      555       +3     
  Lines         24381    24409      +28     
  Branches       4314     4319       +5     
============================================
- Hits          11547    11526      -21     
- Misses        11047    11090      +43     
- Partials       1787     1793       +6
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/com/alibaba/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL0NvbnN0YW50cy5qYXZh) | `88.88% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [.../dubbo/registry/integration/RegistryDirectory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVnaXN0cnkvaW50ZWdyYXRpb24vUmVnaXN0cnlEaXJlY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/rpc/cluster/router/script/ScriptRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9zY3JpcHQvU2NyaXB0Um91dGVyLmphdmE=) | `61.53% <100%> (+4.72%)` | `4 <0> (-1)` | :arrow_down: |
| [.../rpc/cluster/router/condition/ConditionRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9jb25kaXRpb24vQ29uZGl0aW9uUm91dGVyLmphdmE=) | `71.64% <100%> (ø)` | `33 <0> (ø)` | :arrow_down: |
| [...dubbo/rpc/cluster/directory/AbstractDirectory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL2RpcmVjdG9yeS9BYnN0cmFjdERpcmVjdG9yeS5qYXZh) | `56.81% <100%> (+1%)` | `10 <0> (ø)` | :arrow_down: |
| [...libaba/dubbo/rpc/cluster/router/tag/TagRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci90YWcvVGFnUm91dGVyLmphdmE=) | `100% <100%> (ø)` | `11 <11> (?)` | |
| [...dubbo/rpc/cluster/router/tag/TagRouterFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci90YWcvVGFnUm91dGVyRmFjdG9yeS5qYXZh) | `100% <100%> (ø)` | `2 <2> (?)` | |
| [...dubbo/rpc/cluster/router/MockInvokersSelector.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9Nb2NrSW52b2tlcnNTZWxlY3Rvci5qYXZh) | `94.11% <100%> (ø)` | `15 <1> (-2)` | :arrow_down: |
| [...om/alibaba/dubbo/config/AbstractServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RTZXJ2aWNlQ29uZmlnLmphdmE=) | `95.58% <33.33%> (-2.88%)` | `42 <1> (+1)` | |
| [...ibaba/dubbo/rpc/cluster/router/AbstractRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9BYnN0cmFjdFJvdXRlci5qYXZh) | `75% <75%> (ø)` | `5 <5> (?)` | |
| ... and [19 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=footer). Last update [ac49a7d...60ad33b](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=h1) Report
> Merging [#3065](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/ac49a7d34ac6cfe5ff089d9823bdad1171409c00?src=pr&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `88.09%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##              2.6.x    #3065      +/-   ##
============================================
- Coverage     47.36%   47.28%   -0.09%     
- Complexity     4289     4303      +14     
============================================
  Files           552      555       +3     
  Lines         24381    24412      +31     
  Branches       4314     4320       +6     
============================================
- Hits          11547    11542       -5     
- Misses        11047    11079      +32     
- Partials       1787     1791       +4
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/com/alibaba/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL0NvbnN0YW50cy5qYXZh) | `88.88% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [.../dubbo/registry/integration/RegistryDirectory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVnaXN0cnkvaW50ZWdyYXRpb24vUmVnaXN0cnlEaXJlY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/rpc/cluster/router/script/ScriptRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9zY3JpcHQvU2NyaXB0Um91dGVyLmphdmE=) | `61.53% <100%> (+4.72%)` | `4 <0> (-1)` | :arrow_down: |
| [.../rpc/cluster/router/condition/ConditionRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9jb25kaXRpb24vQ29uZGl0aW9uUm91dGVyLmphdmE=) | `71.64% <100%> (ø)` | `33 <0> (ø)` | :arrow_down: |
| [...dubbo/rpc/cluster/directory/AbstractDirectory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL2RpcmVjdG9yeS9BYnN0cmFjdERpcmVjdG9yeS5qYXZh) | `56.81% <100%> (+1%)` | `10 <0> (ø)` | :arrow_down: |
| [...dubbo/rpc/cluster/router/tag/TagRouterFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci90YWcvVGFnUm91dGVyRmFjdG9yeS5qYXZh) | `100% <100%> (ø)` | `2 <2> (?)` | |
| [...dubbo/rpc/cluster/router/MockInvokersSelector.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9Nb2NrSW52b2tlcnNTZWxlY3Rvci5qYXZh) | `94.11% <100%> (ø)` | `15 <1> (-2)` | :arrow_down: |
| [...om/alibaba/dubbo/config/AbstractServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RTZXJ2aWNlQ29uZmlnLmphdmE=) | `95.58% <33.33%> (-2.88%)` | `42 <1> (+1)` | |
| [...ibaba/dubbo/rpc/cluster/router/AbstractRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9BYnN0cmFjdFJvdXRlci5qYXZh) | `75% <75%> (ø)` | `5 <5> (?)` | |
| [...libaba/dubbo/rpc/cluster/router/tag/TagRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci90YWcvVGFnUm91dGVyLmphdmE=) | `96.15% <96.15%> (ø)` | `11 <11> (?)` | |
| ... and [19 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=footer). Last update [ac49a7d...ebc9cfa](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=h1) Report
> Merging [#3065](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/ac49a7d34ac6cfe5ff089d9823bdad1171409c00?src=pr&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##              2.6.x   #3065      +/-   ##
===========================================
- Coverage     47.36%   47.2%   -0.16%     
+ Complexity     4289    4285       -4     
===========================================
  Files           552     552              
  Lines         24381   24381              
  Branches       4314    4314              
===========================================
- Hits          11547   11509      -38     
- Misses        11047   11082      +35     
- Partials       1787    1790       +3
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...aba/dubbo/common/compiler/support/JdkCompiler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2NvbXBpbGVyL3N1cHBvcnQvSmRrQ29tcGlsZXIuamF2YQ==) | `0% <0%> (-61.82%)` | `0% <0%> (-2%)` | |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2V4dGVuc2lvbi9TcHJpbmdFeHRlbnNpb25GYWN0b3J5LmphdmE=) | `78.37% <0%> (-5.41%)` | `9% <0%> (ø)` | |
| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `54.21% <0%> (-3.62%)` | `13% <0%> (-2%)` | |
| [...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvUnBjQ29udGV4dC5qYXZh) | `29.86% <0%> (-3.48%)` | `24% <0%> (-5%)` | |
| [...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==) | `57.81% <0%> (-1.57%)` | `8% <0%> (-1%)` | |
| [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `53.12% <0%> (-1.57%)` | `3% <0%> (ø)` | |
| [...java/com/alibaba/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvUmVmZXJlbmNlQ29uZmlnLmphdmE=) | `51.28% <0%> (-1.1%)` | `39% <0%> (-2%)` | |
| [...baba/dubbo/common/compiler/support/ClassUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2NvbXBpbGVyL3N1cHBvcnQvQ2xhc3NVdGlscy5qYXZh) | `0% <0%> (-0.52%)` | `0% <0%> (-1%)` | |
| [...libaba/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9EdWJib1Byb3RvY29sLmphdmE=) | `60.52% <0%> (-0.44%)` | `32% <0%> (-1%)` | |
| [...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DYWxsYmFja1NlcnZpY2VDb2RlYy5qYXZh) | `79.41% <0%> (+0.73%)` | `29% <0%> (ø)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=footer). Last update [ac49a7d...3c0126d](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

Posted by "cvictory (GitHub)" <gi...@apache.org>.
增加个日志看下，为什么不通过。

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory closed pull request #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

Posted by "cvictory (GitHub)" <gi...@apache.org>.
[ pull request closed by cvictory ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=h1) Report
> Merging [#3065](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/ac49a7d34ac6cfe5ff089d9823bdad1171409c00?src=pr&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `76.92%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##              2.6.x   #3065      +/-   ##
===========================================
- Coverage     47.36%   47.2%   -0.16%     
- Complexity     4289    4298       +9     
===========================================
  Files           552     555       +3     
  Lines         24381   24409      +28     
  Branches       4314    4319       +5     
===========================================
- Hits          11547   11522      -25     
- Misses        11047   11096      +49     
- Partials       1787    1791       +4
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/com/alibaba/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL0NvbnN0YW50cy5qYXZh) | `88.88% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [.../dubbo/registry/integration/RegistryDirectory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVnaXN0cnkvaW50ZWdyYXRpb24vUmVnaXN0cnlEaXJlY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/rpc/cluster/router/script/ScriptRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9zY3JpcHQvU2NyaXB0Um91dGVyLmphdmE=) | `61.53% <100%> (+4.72%)` | `4 <0> (-1)` | :arrow_down: |
| [.../rpc/cluster/router/condition/ConditionRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9jb25kaXRpb24vQ29uZGl0aW9uUm91dGVyLmphdmE=) | `71.64% <100%> (ø)` | `33 <0> (ø)` | :arrow_down: |
| [...dubbo/rpc/cluster/router/tag/TagRouterFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci90YWcvVGFnUm91dGVyRmFjdG9yeS5qYXZh) | `100% <100%> (ø)` | `2 <2> (?)` | |
| [...dubbo/rpc/cluster/router/MockInvokersSelector.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9Nb2NrSW52b2tlcnNTZWxlY3Rvci5qYXZh) | `94.11% <100%> (ø)` | `15 <1> (-2)` | :arrow_down: |
| [...om/alibaba/dubbo/config/AbstractServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RTZXJ2aWNlQ29uZmlnLmphdmE=) | `95.58% <33.33%> (-2.88%)` | `42 <1> (+1)` | |
| [...ibaba/dubbo/rpc/cluster/router/AbstractRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9BYnN0cmFjdFJvdXRlci5qYXZh) | `75% <75%> (ø)` | `4 <4> (?)` | |
| [...libaba/dubbo/rpc/cluster/router/tag/TagRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci90YWcvVGFnUm91dGVyLmphdmE=) | `79.16% <79.16%> (ø)` | `9 <9> (?)` | |
| [...aba/dubbo/common/compiler/support/JdkCompiler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2NvbXBpbGVyL3N1cHBvcnQvSmRrQ29tcGlsZXIuamF2YQ==) | `0% <0%> (-61.82%)` | `0% <0%> (-2%)` | |
| ... and [20 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=footer). Last update [ac49a7d...340139b](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=h1) Report
> Merging [#3065](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/ac49a7d34ac6cfe5ff089d9823bdad1171409c00?src=pr&el=desc) will **decrease** coverage by `0.09%`.
> The diff coverage is `94%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##              2.6.x    #3065     +/-   ##
===========================================
- Coverage     47.36%   47.26%   -0.1%     
- Complexity     4289     4300     +11     
===========================================
  Files           552      554      +2     
  Lines         24381    24405     +24     
  Branches       4314     4320      +6     
===========================================
- Hits          11547    11536     -11     
- Misses        11047    11077     +30     
- Partials       1787     1792      +5
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/com/alibaba/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL0NvbnN0YW50cy5qYXZh) | `88.88% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [.../dubbo/registry/integration/RegistryDirectory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVnaXN0cnkvaW50ZWdyYXRpb24vUmVnaXN0cnlEaXJlY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/rpc/cluster/router/script/ScriptRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9zY3JpcHQvU2NyaXB0Um91dGVyLmphdmE=) | `61.53% <100%> (+4.72%)` | `4 <0> (-1)` | :arrow_down: |
| [.../rpc/cluster/router/condition/ConditionRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9jb25kaXRpb24vQ29uZGl0aW9uUm91dGVyLmphdmE=) | `71.64% <100%> (ø)` | `33 <0> (ø)` | :arrow_down: |
| [...dubbo/rpc/cluster/directory/AbstractDirectory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL2RpcmVjdG9yeS9BYnN0cmFjdERpcmVjdG9yeS5qYXZh) | `56.81% <100%> (+1%)` | `10 <0> (ø)` | :arrow_down: |
| [...dubbo/rpc/cluster/router/MockInvokersSelector.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9Nb2NrSW52b2tlcnNTZWxlY3Rvci5qYXZh) | `94.11% <100%> (ø)` | `15 <1> (-2)` | :arrow_down: |
| [...ibaba/dubbo/rpc/cluster/router/AbstractRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9BYnN0cmFjdFJvdXRlci5qYXZh) | `75% <75%> (ø)` | `5 <5> (?)` | |
| [...libaba/dubbo/rpc/cluster/router/tag/TagRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci90YWcvVGFnUm91dGVyLmphdmE=) | `95.23% <95.23%> (ø)` | `10 <10> (?)` | |
| [...om/alibaba/dubbo/config/AbstractServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RTZXJ2aWNlQ29uZmlnLmphdmE=) | `95.58% <95.58%> (-2.88%)` | `42 <42> (+1)` | |
| [...aba/dubbo/common/compiler/support/JdkCompiler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2NvbXBpbGVyL3N1cHBvcnQvSmRrQ29tcGlsZXIuamF2YQ==) | `0% <0%> (-61.82%)` | `0% <0%> (-2%)` | |
| ... and [19 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3065/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=footer). Last update [ac49a7d...0c766da](https://codecov.io/gh/apache/incubator-dubbo/pull/3065?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] lexburner commented on pull request #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

Posted by "lexburner (GitHub)" <gi...@apache.org>.
compareTo is centralized management by the `AbstractRouter`，make the behavior the same as 2.7.x. Only override `getPriority` to control the priority. 

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

Posted by "cvictory (GitHub)" <gi...@apache.org>.
why do you remove compareTo method ? It is different from super class

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

Posted by "cvictory (GitHub)" <gi...@apache.org>.
tag 名字和2.7版本保持一致。

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3065: [Dubbo - 2.6.x TagRouter Feature] Import old TagRouter into 2.6.x

Posted by "cvictory (GitHub)" <gi...@apache.org>.
We have added TagRouter into RouteList defaultly.  Can we remove this class and SPI description.?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org