You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/15 20:46:00 UTC
[GitHub] [beam] y1chi opened a new pull request #12013: Fix error creating unnecessary data channel for user timer in py sdk
y1chi opened a new pull request #12013:
URL: https://github.com/apache/beam/pull/12013
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Samza | Spark
--- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #12013: Fix error creating unnecessary data channel for user timer in py sdk
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #12013:
URL: https://github.com/apache/beam/pull/12013#issuecomment-645102393
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on pull request #12013: Fix error creating unnecessary data channel for user timer in py sdk
Posted by GitBox <gi...@apache.org>.
y1chi commented on pull request #12013:
URL: https://github.com/apache/beam/pull/12013#issuecomment-645495199
not sure why the cython tests are failing on jenkins, I tried locally it seems fine. Could we rerun the precommit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #12013: Fix error creating unnecessary data channel for user timer in py sdk
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #12013:
URL: https://github.com/apache/beam/pull/12013#issuecomment-645758226
All tests seem to be passing, can we merge this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on pull request #12013: Fix error creating unnecessary data channel for user timer in py sdk
Posted by GitBox <gi...@apache.org>.
y1chi commented on pull request #12013:
URL: https://github.com/apache/beam/pull/12013#issuecomment-645649942
Run Python2_PVR_Flink PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on a change in pull request #12013: Fix error creating unnecessary data channel for user timer in py sdk
Posted by GitBox <gi...@apache.org>.
y1chi commented on a change in pull request #12013:
URL: https://github.com/apache/beam/pull/12013#discussion_r440466258
##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -819,7 +819,7 @@ def __init__(self,
# There is no guarantee that the runner only set
# timer_api_service_descriptor when having timers. So this field cannot be
# used as an indicator of timers.
- if self.process_bundle_descriptor.timer_api_service_descriptor:
+ if self.process_bundle_descriptor.timer_api_service_descriptor.url:
Review comment:
I believe for proto3 all fields are optional and have a default instance thus can't be None.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on a change in pull request #12013: Fix error creating unnecessary data channel for user timer in py sdk
Posted by GitBox <gi...@apache.org>.
aaltay commented on a change in pull request #12013:
URL: https://github.com/apache/beam/pull/12013#discussion_r440458545
##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -819,7 +819,7 @@ def __init__(self,
# There is no guarantee that the runner only set
# timer_api_service_descriptor when having timers. So this field cannot be
# used as an indicator of timers.
- if self.process_bundle_descriptor.timer_api_service_descriptor:
+ if self.process_bundle_descriptor.timer_api_service_descriptor.url:
Review comment:
Is it possible for `timer_api_service_descriptor` to be `None` as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #12013: Fix error creating unnecessary data channel for user timer in py sdk
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #12013:
URL: https://github.com/apache/beam/pull/12013#issuecomment-645500286
I do not see the failing test. Do you have a link?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on pull request #12013: Fix error creating unnecessary data channel for user timer in py sdk
Posted by GitBox <gi...@apache.org>.
y1chi commented on pull request #12013:
URL: https://github.com/apache/beam/pull/12013#issuecomment-645761653
> All tests seem to be passing, can we merge this?
Yeah, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on pull request #12013: Fix error creating unnecessary data channel for user timer in py sdk
Posted by GitBox <gi...@apache.org>.
y1chi commented on pull request #12013:
URL: https://github.com/apache/beam/pull/12013#issuecomment-644380011
R: @angoenka
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on pull request #12013: Fix error creating unnecessary data channel for user timer in py sdk
Posted by GitBox <gi...@apache.org>.
y1chi commented on pull request #12013:
URL: https://github.com/apache/beam/pull/12013#issuecomment-644873289
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #12013: Fix error creating unnecessary data channel for user timer in py sdk
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #12013:
URL: https://github.com/apache/beam/pull/12013#issuecomment-645102697
Tests are finally running. Will re-check this after tests pass. Feel free to ping me after tests pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay merged pull request #12013: Fix error creating unnecessary data channel for user timer in py sdk
Posted by GitBox <gi...@apache.org>.
aaltay merged pull request #12013:
URL: https://github.com/apache/beam/pull/12013
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #12013: Fix error creating unnecessary data channel for user timer in py sdk
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #12013:
URL: https://github.com/apache/beam/pull/12013#issuecomment-645102299
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #12013: Fix error creating unnecessary data channel for user timer in py sdk
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #12013:
URL: https://github.com/apache/beam/pull/12013#issuecomment-644456119
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on pull request #12013: Fix error creating unnecessary data channel for user timer in py sdk
Posted by GitBox <gi...@apache.org>.
y1chi commented on pull request #12013:
URL: https://github.com/apache/beam/pull/12013#issuecomment-645501377
> I do not see the failing test. Do you have a link?
https://scans.gradle.com/s/xljyk3gyp7r34
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #12013: Fix error creating unnecessary data channel for user timer in py sdk
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #12013:
URL: https://github.com/apache/beam/pull/12013#issuecomment-645102566
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org