[GitHub] [ozone] DaveTeng0 commented on a diff in pull request #3818: HDDS-7306. DeleteBlock retry count increased at incorrect place

["DaveTeng0 (via GitHub)" <gi...@apache.org>]

DaveTeng0 commented on code in PR #3818:
URL: https://github.com/apache/ozone/pull/3818#discussion_r1090232892


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/TestBlockDeletion.java:
##########
@@ -287,6 +289,12 @@ public void testBlockDeletion(ReplicationConfig repConfig) throws Exception {
         metrics.getNumBlockDeletionTransactionFailure() +
             metrics.getNumBlockDeletionTransactionSuccess());
     LOG.info(metrics.toString());
+
+    // Datanode should receive retried requests with continuous retry counts.
+    Assertions.assertTrue(logCapturer.getOutput().contains("1(0)"));
+    Assertions.assertTrue(logCapturer.getOutput().contains("1(1)"));
+    Assertions.assertTrue(logCapturer.getOutput().contains("1(2)"));
+    Assertions.assertTrue(logCapturer.getOutput().contains("1(3)"));

Review Comment:
   hey @symious ~ I didn't understand the result from these logCapturer.getOutput().contains(). would you mind explain for me a bit~~?  Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org