[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #895: MINIFICPP-1352 - Comment out unused parameters (for enabling -Wall)

[GitBox <gi...@apache.org>]

hunyadi-dev commented on a change in pull request #895:
URL: https://github.com/apache/nifi-minifi-cpp/pull/895#discussion_r488416568



##########
File path: libminifi/include/utils/file/FileUtils.h
##########
@@ -115,14 +115,15 @@ class FileUtils {
    * @param force_posix returns the posix path separator ('/'), even when not on posix. Useful when dealing with remote posix paths.
    * @return the path separator character
    */
-  static char get_separator(bool force_posix = false) {
 #ifdef WIN32
+  static char get_separator(bool force_posix = false) {

Review comment:
       Fixed by having the closing brace appear in both versions inside the macro.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org