You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/14 19:21:59 UTC
[GitHub] [beam] byronellis opened a new pull request, #22280: Increase streaming server timeout
byronellis opened a new pull request, #22280:
URL: https://github.com/apache/beam/pull/22280
Increases the timeout for the streaming server to 60s which appears to allow sufficient time for the PVR Spark 2 tests to complete. In local testing this addresses #21473
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #22280: Increase streaming server timeout
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #22280:
URL: https://github.com/apache/beam/pull/22280#issuecomment-1185885396
Run Java Spark v2 PortableValidatesRunner Streaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #22280: Increase streaming server timeout
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #22280:
URL: https://github.com/apache/beam/pull/22280#issuecomment-1187501531
<img width="912" alt="image" src="https://user-images.githubusercontent.com/42773683/179527526-fad507b7-af35-419c-b4a9-d3711b0dd58f.png">
This is nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] byronellis commented on pull request #22280: Increase streaming server timeout
Posted by GitBox <gi...@apache.org>.
byronellis commented on PR #22280:
URL: https://github.com/apache/beam/pull/22280#issuecomment-1184944527
Well that's a bummer. I think I may actually have to go in and figure out how to actually have the streaming tests wait for the test to complete before shutdown. That's going to be a bit larger change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #22280: Increase streaming server timeout
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #22280:
URL: https://github.com/apache/beam/pull/22280#issuecomment-1184891906
@byronellis looks like that didn't quite do it unfortunately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #22280: Increase streaming server timeout
Posted by GitBox <gi...@apache.org>.
damccorm merged PR #22280:
URL: https://github.com/apache/beam/pull/22280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] byronellis commented on pull request #22280: Increase streaming server timeout
Posted by GitBox <gi...@apache.org>.
byronellis commented on PR #22280:
URL: https://github.com/apache/beam/pull/22280#issuecomment-1186721441
I'm no longer sure it's a race. I think the tests may just take awhile to run and get killed by the timeout if they overrun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #22280: Increase streaming server timeout
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #22280:
URL: https://github.com/apache/beam/pull/22280#issuecomment-1184852884
Run Java Spark v2 PortableValidatesRunner Streaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] byronellis commented on pull request #22280: Increase streaming server timeout
Posted by GitBox <gi...@apache.org>.
byronellis commented on PR #22280:
URL: https://github.com/apache/beam/pull/22280#issuecomment-1185989884
It worked! Okay, so it's really just that setting up and tearing down Spark can take awhile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org