[GitHub] [lucene-solr] Pr0methean opened a new pull request #978: SOLR-13207: Handle misuse of < operator

[GitBox <gi...@apache.org>]

Pr0methean opened a new pull request #978: SOLR-13207: Handle misuse of < operator
URL: https://github.com/apache/lucene-solr/pull/978
 
 
   Traps error that arises when the < operator is used at the end of a query field.
   Also handles NumberFormatException when the operand isn't a number.
   
   <!--
   Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
   
   * https://issues.apache.org/jira/projects/LUCENE
   * https://issues.apache.org/jira/projects/SOLR
   
   You will need to create an account in Jira in order to create an issue.
   
   The title of the PR should reference the Jira issue number in the form:
   
   * LUCENE-####: <short description of problem or changes>
   * SOLR-####: <short description of problem or changes>
   
   LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
   
   Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
   
   
   # Description
   
   When < operator is used with no operand after it (i.e. at the end of the query field) or with a non-numeric operand, an HTTP 500 error arises caused by an ArrayIndexOutOfBoundsException or NumberFormatException respectively.
   
   # Solution
   
   Throws a SolrException with BAD_REQUEST as the error code when either situation arises, since the query is malformed.
   
   # Tests
   
   Added 2 cases in SolrPluginUtilsTest.testMinShouldMatchCalculator, for queries "1<" and "1<x". Both use the try-fail-catch pattern
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [X] I have created a Jira issue and added the issue ID to my pull request title. **Using an existing Jira issue instead.**
   - [X] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute. **This PR consists entirely of my own code.**
   - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [X] I have developed this patch against the `master` branch.
   - [X] I have run `ant precommit` and the appropriate test suite.
   - [X] I have added tests for my changes.
   - [X] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only). **No changes apply.**
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org