[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5162: Add QueryConfig to TableConfig with the query timeout setting

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #5162: Add QueryConfig to TableConfig with the query timeout setting
URL: https://github.com/apache/incubator-pinot/pull/5162#discussion_r395329357
 
 

 ##########
 File path: pinot-common/src/main/java/org/apache/pinot/common/config/TableConfig.java
 ##########
 @@ -72,8 +70,9 @@
 
   private TableTaskConfig _taskConfig;
   private RoutingConfig _routingConfig;
-  private Map<InstancePartitionsType, InstanceAssignmentConfig> _instanceAssignmentConfigMap;
+  private QueryConfig _queryConfig;
 
 Review comment:
   No, it won't. Check line 225, we only put it when it is not null.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org