[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8523: Add tracing for operator planning

[GitBox <gi...@apache.org>]

siddharthteotia commented on code in PR #8523:
URL: https://github.com/apache/pinot/pull/8523#discussion_r851505449


##########
pinot-core/src/main/java/org/apache/pinot/core/operator/BaseOperator.java:
##########
@@ -35,7 +35,7 @@ public final T nextBlock() {
     if (Thread.interrupted()) {
       throw new EarlyTerminationException();
     }
-    try (InvocationScope execution = Tracing.getTracer().createScope(getClass())) {
+    try (InvocationScope ignored = Tracing.getTracer().createScope(getClass())) {

Review Comment:
   2nd option seems better but upto you



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org