You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2019/11/08 03:12:09 UTC
[james-project] 22/36: PROTOCOLS-37 [Refactoring] ReIndent
AbstractProtocolTransport
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 5062a28a203788e2e3429554af4724f87dd556ae
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Thu Nov 7 09:17:31 2019 +0700
PROTOCOLS-37 [Refactoring] ReIndent AbstractProtocolTransport
---
.../james/protocols/api/AbstractProtocolTransport.java | 18 ++++--------------
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/protocols/api/src/main/java/org/apache/james/protocols/api/AbstractProtocolTransport.java b/protocols/api/src/main/java/org/apache/james/protocols/api/AbstractProtocolTransport.java
index df4f478..65825ca 100644
--- a/protocols/api/src/main/java/org/apache/james/protocols/api/AbstractProtocolTransport.java
+++ b/protocols/api/src/main/java/org/apache/james/protocols/api/AbstractProtocolTransport.java
@@ -28,16 +28,11 @@ import java.util.concurrent.LinkedBlockingQueue;
/**
* Abstract base class for {@link ProtocolTransport} implementation which already takes care of all the complex
- * stuff when handling {@link Response}'s.
- *
- *
- *
+ * stuff when handling {@link Response}'s.
*/
public abstract class AbstractProtocolTransport implements ProtocolTransport {
-
private static final String CRLF = "\r\n";
-
// TODO: Should we limit the size ?
private final Queue<Response> responses = new LinkedBlockingQueue<>();
private volatile boolean isAsync = false;
@@ -73,13 +68,11 @@ public abstract class AbstractProtocolTransport implements ProtocolTransport {
if (isStartTLSSupported()) {
startTLS = true;
} else {
-
// StartTls is not supported by this transport, so throw a exception
throw new UnsupportedOperationException("StartTls is not supported by this ProtocolTransport implementation");
}
}
-
-
+
if (response instanceof StreamResponse) {
writeToClient(toBytes(response), session, false);
writeToClient(((StreamResponse) response).getStream(), session, startTLS);
@@ -94,10 +87,9 @@ public abstract class AbstractProtocolTransport implements ProtocolTransport {
if (response.isEndSession()) {
// close the channel if needed after the message was written out
close();
- }
- }
+ }
+ }
}
-
/**
* Take the {@link Response} and encode it to a <code>byte</code> array
@@ -120,7 +112,6 @@ public abstract class AbstractProtocolTransport implements ProtocolTransport {
throw new RuntimeException("No US-ASCII ?");
}
}
-
/**
* Write the given <code>byte's</code> to the remote peer
@@ -139,7 +130,6 @@ public abstract class AbstractProtocolTransport implements ProtocolTransport {
* @param startTLS true if startTLS should be started after the {@link InputStream} was written to the client
*/
protected abstract void writeToClient(InputStream in, ProtocolSession session, boolean startTLS);
-
/**
* Close the Transport
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org