You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/03/16 17:58:23 UTC
[GitHub] [ozone] xiaoyuyao commented on a change in pull request #2043: HDDS-4978. [SCM HA Security] Ozone services should be disabled in SCM HA enabled and security enabled cluster
xiaoyuyao commented on a change in pull request #2043:
URL: https://github.com/apache/ozone/pull/2043#discussion_r595414625
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java
##########
@@ -490,6 +490,14 @@
public static final boolean HDDS_DATANODE_UPGRADE_LAYOUT_INLINE_DEFAULT =
true;
+
+ // Temporary config which will be used only for test only purposes until
+ // SCM HA Security work is completed. This config should not be modified by
+ // users.
+ public static final String OZONE_SCM_HA_SECURITY_ENABLE =
Review comment:
NIT: can we rename this to OZONE_SCM_HA_SECURITY_SUPPORTED as this is compared against other keys has defined for security enabled and HA enabled? Otherwise, LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org