[GitHub] [airflow] jedcunningham commented on a diff in pull request #27848: git-sync 3.6.1

[GitBox <gi...@apache.org>]

jedcunningham commented on code in PR #27848:
URL: https://github.com/apache/airflow/pull/27848#discussion_r1038648326


##########
chart/templates/_helpers.yaml:
##########
@@ -214,8 +214,10 @@ If release name contains chart name it will be used as a full name.
       value: "repo"
     - name: GIT_SYNC_ADD_USER
       value: "true"
-    - name: GIT_SYNC_WAIT
+    - name: GIT_SYNC_WAIT # Deprecated: use GIT_SYNC_PERIOD
       value: {{ .Values.dags.gitSync.wait | quote }}
+    - name: GIT_SYNC_PERIOD
+      value: {{ .Values.dags.gitSync.period | quote }}

Review Comment:
   Yeah, that's basically where I was going.
   
   We have to set both env vars so it works regardless of gitsync version. And it'll prefer `WAIT`, so `PERIOD` is never used anyways. We could do some more complicated logic to support both, but I agree sticking with just `wait` in our values seems easiest.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org