You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Jesse Glick <je...@oracle.com> on 2011/01/04 17:47:11 UTC
Re: [VOTE] release of ant 1.8.2
On 12/20/2010 12:32 AM, Antoine Levy-Lambert wrote:
> However I was not able to reproduce the problem that you mentioned.
> Is it possible that you did not put junit-4 on the classpath when running the junit 4 style test suite ?
No, the property was defined to point to a copy of JUnit 4.8.1. Anyway I can confirm that my test case works in the 1.8.2 final release (and not with the initial candidate).
> Or else the antunit testscase which I added does not reproduce the failure case.
Well, editing the control method to be clearly bogus
public void ok() {throw new RuntimeException("XXX just testing");}
does not cause a failure either, so the testcase is obviously broken. Even making the test class uncompilable does not cause a failure! I am working on fixing the test
case; the test was being skipped.
Also note that running 'ant test -Dtestcase=...' tests the version of Ant in $PATH, not that from the source tree! I fixed this for JUnit tests but I guess it is still
broken for AntUnit tests.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: [VOTE] release of ant 1.8.2
Posted by Jesse Glick <je...@oracle.com>.
On 01/04/2011 12:32 PM, Antoine Levy-Lambert wrote:
> Can you point me to the changes you did to make ant test the version of the source tree?
http://svn.apache.org/viewvc?diff_format=h&view=revision&revision=944377
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: [VOTE] release of ant 1.8.2
Posted by Antoine Levy-Lambert <an...@gmx.de>.
On 1/4/2011 11:47 AM, Jesse Glick wrote:
> On 12/20/2010 12:32 AM, Antoine Levy-Lambert wrote:
>> However I was not able to reproduce the problem that you mentioned.
>> Is it possible that you did not put junit-4 on the classpath when
>> running the junit 4 style test suite ?
>
> No, the property was defined to point to a copy of JUnit 4.8.1. Anyway
> I can confirm that my test case works in the 1.8.2 final release (and
> not with the initial candidate).
>
>> Or else the antunit testscase which I added does not reproduce the
>> failure case.
>
> Well, editing the control method to be clearly bogus
>
> public void ok() {throw new RuntimeException("XXX just testing");}
>
> does not cause a failure either, so the testcase is obviously broken.
> Even making the test class uncompilable does not cause a failure! I am
> working on fixing the test case; the test was being skipped.
Thanks. I see your diffs here [1]
I am not good at writing unit tests. Plus I am concerned about how they
fare when they run in gump ...
>
>
> Also note that running 'ant test -Dtestcase=...' tests the version of
> Ant in $PATH, not that from the source tree! I fixed this for JUnit
> tests but I guess it is still broken for AntUnit tests.
>
>
Thanks this is useful. Can you point me to the changes you did to make
ant test the version of the source tree ? For antunit tests yes, this is
certainly broken as you say, you are testing the version of ant in the
PATH or the one pointed to by ANT_HOME.
Regards,
Antoine
[1]
http://svn.apache.org/viewvc/ant/core/trunk/src/tests/antunit/taskdefs/optional/junit/junit-test.xml?r1=1050993&r2=1055099&diff_format=h
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org