You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Craig Ambrose (Created) (JIRA)" <ji...@apache.org> on 2011/11/05 22:28:51 UTC

[jira] [Created] (OFBIZ-4540) Item Issuance does not work with MARKETING_PKG_PICK order items

Item Issuance does not work with MARKETING_PKG_PICK order items
---------------------------------------------------------------

                 Key: OFBIZ-4540
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4540
             Project: OFBiz
          Issue Type: Bug
          Components: order, party
    Affects Versions: SVN trunk
            Reporter: Craig Ambrose


There is a problem when I "quick ship" an order that contains one or more MARKETING_PKG_PICK. I used the product in the eCommerce demo data, GZ-BASKET-PICK. When I submit the order and then do a "quick ship" I end up without an OrderShipment entity even though the OrderItemShpGrpInvRes rows are removed, the ItemIssuance rows are created, the OrderItem rows are marked completed and other data is affected.

I believe the problem is with the "issueOrderItemShipGrpInvResToShipment" service. It doesn't seem to know that an OrderItem can represent multiple ShipmentItems and it tries to determine, wrongly, that the OrderShipment needs to be removed and will be replaced.

What I expect to happen is that an OrderItem that is a MARKETING_PKG_PICK would end up as N ShipmentItem rows, one for each of the products that make up the bundle. And that would end up with multiple OrderShipment rows for the particular orderId/orderItemSeqId two-ple

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OFBIZ-4540) Item Issuance does not work with MARKETING_PKG_PICK order items

Posted by "Paul Foxworthy (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147530#comment-13147530 ] 

Paul Foxworthy commented on OFBIZ-4540:
---------------------------------------

Hi Craig,

The service is called once for each inventory item needed by the order, so it doesn't need to worry about an order item having multiple shipment items: it just focuses on the particular inventory item for this call. See for example the for loop at https://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/PackingSession.java?r=996892#to769, which calls a method issueItemToShipment, which calls the issueOrderItemShipGrpInvResToShipment service.

There's been recent work in this area. See Jira issue https://issues.apache.org/jira/browse/OFBIZ-4386, committed to trunk in r1185179. If your version predates that, getting a more recent one might help. If you are already on a more recent version, I'd be grateful if you could try a version *prior* to r1185179 and see if it works for you.

If there is a problem with the 4386 patch, please consider contributing a unit test that highlights the problem you're having. There is one in the patches for 4386 to exemplify the problem we were trying to solve.

Cheers

Paul Foxworthy



                
> Item Issuance does not work with MARKETING_PKG_PICK order items
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-4540
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4540
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order, party
>    Affects Versions: SVN trunk
>            Reporter: Craig Ambrose
>
> There is a problem when I "quick ship" an order that contains one or more MARKETING_PKG_PICK. I used the product in the eCommerce demo data, GZ-BASKET-PICK. When I submit the order and then do a "quick ship" I end up without an OrderShipment entity even though the OrderItemShpGrpInvRes rows are removed, the ItemIssuance rows are created, the OrderItem rows are marked completed and other data is affected.
> I believe the problem is with the "issueOrderItemShipGrpInvResToShipment" service. It doesn't seem to know that an OrderItem can represent multiple ShipmentItems and it tries to determine, wrongly, that the OrderShipment needs to be removed and will be replaced.
> What I expect to happen is that an OrderItem that is a MARKETING_PKG_PICK would end up as N ShipmentItem rows, one for each of the products that make up the bundle. And that would end up with multiple OrderShipment rows for the particular orderId/orderItemSeqId two-ple

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira