You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "smallzhongfeng (via GitHub)" <gi...@apache.org> on 2023/04/17 03:59:04 UTC
[GitHub] [incubator-uniffle] smallzhongfeng opened a new pull request, #823: [MINOR] Add `WORKDIR`
smallzhongfeng opened a new pull request, #823:
URL: https://github.com/apache/incubator-uniffle/pull/823
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
Add `WORKDIR` for DOCKERFILE.
### Why are the changes needed?
After entering the Docker, you can directly enter the home directory like https://github.com/apache/spark/blob/1820b18eea940cf7c93e6cb0e1d1d294d2d20d28/resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile#L55
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #823: [MINOR] Add `WORKDIR`
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #823:
URL: https://github.com/apache/incubator-uniffle/pull/823#issuecomment-1510666707
## [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/823?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#823](https://codecov.io/gh/apache/incubator-uniffle/pull/823?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (509e021) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/23e0a51e380d368a829b18386022d02ab6cb4076?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (23e0a51) will **increase** coverage by `0.47%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #823 +/- ##
============================================
+ Coverage 57.53% 58.01% +0.47%
+ Complexity 2065 1923 -142
============================================
Files 306 275 -31
Lines 14970 12025 -2945
Branches 1236 1158 -78
============================================
- Hits 8613 6976 -1637
+ Misses 5860 4645 -1215
+ Partials 497 404 -93
```
[see 34 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-uniffle/pull/823/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi merged pull request #823: [MINOR] Add `WORKDIR`
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #823:
URL: https://github.com/apache/incubator-uniffle/pull/823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org