You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@mesos.apache.org by "James DeFelice (JIRA)" <ji...@apache.org> on 2017/06/28 20:28:00 UTC

[jira] [Created] (MESOS-7734) More consistent/strict validation of role names please

James DeFelice created MESOS-7734:
-------------------------------------

             Summary: More consistent/strict validation of role names please
                 Key: MESOS-7734
                 URL: https://issues.apache.org/jira/browse/MESOS-7734
             Project: Mesos
          Issue Type: Improvement
            Reporter: James DeFelice


As per the currently implemented role validation rules:
https://github.com/apache/mesos/blob/63e08146aa7aa8efac3928922b6cdef92aa1d2ce/src/common/roles.cpp#L71 

... the following role names are allowed:
{code}
eng-
eng*
*eng
eng.
eng..
...
..eng
{code}

The `/` character has good validation semantics around it and it's a much less confusing character to use when composing hierarchical role names. The `*`, `.`, and `-` characters have specific validation rules within narrow context, but it's too easy for someone to compose confusing role names using these characters.

IMO, validation should severely restrict the context in which the `*` and `.` characters are used, as well as implement a symmetrical "endWith" check for `-` characters.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)