[jira] [Commented] (BEAM-6947) TestGCSIO.test_last_updated (gcsio_test.py) fails when the current timezone offset and the timezone offset on 2nd of Jan 1970 differ

["Beam JIRA Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-6947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17174746#comment-17174746 ] 

Beam JIRA Bot commented on BEAM-6947:
-------------------------------------

This issue is P2 but has been unassigned without any comment for 60 days so it has been labeled "stale-P2". If this issue is still affecting you, we care! Please comment and remove the label. Otherwise, in 14 days the issue will be moved to P3.

Please see https://beam.apache.org/contribute/jira-priorities/ for a detailed explanation of what these priorities mean.


> TestGCSIO.test_last_updated (gcsio_test.py) fails when the current timezone offset and the timezone offset on 2nd of Jan 1970 differ
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-6947
>                 URL: https://issues.apache.org/jira/browse/BEAM-6947
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Csaba Kassai
>            Priority: P2
>              Labels: stale-P2
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> The test TestGCSIO.test_last_updated uses timestamp 123456.78 as the last updated timestamp.  This timestamp is converted into a naive datetime in the Fakefile class get_metadata method (gcsio_test.py line 72) Then in the GcsIO class last_updated method (gcsio.py ) is converted back to timestamp. But the conversion is incorrect when the the timezone offset is different in 1970 and now. In my case now Singapore is GMT+8 and it was only GMT+7:30 in 1970. So the test fails. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)