You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by kxepal <gi...@git.apache.org> on 2015/03/06 12:55:41 UTC
[GitHub] couchdb-fauxton pull request: Add missed license headers
GitHub user kxepal opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/310
Add missed license headers
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kxepal/couchdb-fauxton license-headers
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/310.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #310
----
commit b1bc3a616c88a130abc061d56f2871d9a6cba693
Author: Alexander Shorin <kx...@apache.org>
Date: 2015-03-06T11:53:59Z
Add missed license headers
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add missed license headers
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/310#issuecomment-77559078
@robertkowalski hm...so in html block used `<%...%>` while on pages html - `<!--...-->` right? otherwise such strip isn't good for the releases we ships.
How to distinguish where is a block and where is a page? and what about *.less files?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add missed license headers
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/310
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add missed license headers
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/310#issuecomment-77615994
It's not about breaking release in term or...it wouldn't work at all. It's about breaking license requirements (have a ASF header in each file) for release artefacts. But I feel that would be another part of the story - just asked because of curiosity.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add missed license headers
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/310#issuecomment-77549590
@robertkowalski I also noticed that some .html files contains `<!--...-->`, while others `<%/*...*/%>` - any difference?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add missed license headers
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/310#issuecomment-77549321
+1 thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add missed license headers
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/310#issuecomment-77590737
i am not sure if i understand your question... fauxton's "html"-files are lodash templates where you can write javascript inside those guys: `<% %>`
the templates are then converted to js code and the the js in those <% %> is evaluated before the templates are converted to full js code and get embedded in our AMD modules - that process strips comments from the js (like /* foo */ or // foo )
i don't see why this could break a release build
in general we are slowly moving from <!-- --> in all of our html files to <% /* */ %> because it make sinspecting the DOM easier and has no negative effect on the production-build
in less files we use usually // but /* is also valid
// gets stripped on a build, /* not
(for less files)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add missed license headers
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/310#issuecomment-77558416
@kxepal we are migrating away from `<!--` because it gets rendered in development mode and clutters the DOM which makes it hard to inspect.
Using `/*` makes the license headers also disappear in development mode and not just after a production build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---